Al Poole
bfe02d2303
efm - fix popup if file is a fifo
...
this fixes T4815
@fix
2016-11-02 11:00:40 +09:00
Carsten Haitzler
fd8d41a2a6
e fm - fix popup to not crash by referring to possibly deleted data
...
fm icon info is transient because fm icons are transient. files may
get deleted, added or removed on the fly. keeping icon info around for
things like the popup is asking for tyrouble and does create trouble.
so look it up each time based on filename string. safe!
this fixes T4716 and fixes T4798 (they are the same bug basically).
2016-10-31 18:23:08 +09:00
Al Poole
382fe30688
fwin: prevent segv when the vaarg abi messup with unused parameter.
...
Quite a hack overall, but if you don't need those parameter, just put
nothing and it will work.
@fix T4112
Signed-off-by: Cedric Bail <cedric@osg.samsung.com>
2016-07-15 09:17:44 -07:00
Mike Blumenkrantz
768252740b
don't revert focus to desktop fileman during compositor grab
...
grabs indicate an action is already occurring and focus shouldn't be altered
2016-05-03 20:27:03 -04:00
Mike Blumenkrantz
6d45baa510
do not shortcut access of Efreet_Desktop->x hash in fileman
...
this subverts thread safety and also (now) avoids return data validation
fix T3096
2016-01-25 11:29:55 -05:00
Mike Blumenkrantz
d659b86478
remove fwin popup size hint change callback on win deletion
...
this callback also crashes if called during delete
2015-11-20 09:16:21 -05:00
Mike Blumenkrantz
b2706afe06
ensure fwin efm delete callback does not trigger crash
...
if this is called during fwin delete, dereferencing the passed data
will result in a crash
2015-11-20 09:09:38 -05:00
Mike Blumenkrantz
d2a9596753
use evas object callbacks for fwin mouse in/out, don't use ecore-x handlers in wayland
...
improve compatibility with wayland compositors
2015-07-06 14:23:54 -04:00
Mike Blumenkrantz
038df92cdd
only apply fwin focus to main efm object if no icon is editing
2015-04-30 16:06:09 -04:00
Mike Blumenkrantz
5db35cd85a
add focus callback to override elm_win being stupid
...
plz elm_win, you can't focus yourself. you aren't a real widget.
2015-04-27 16:03:42 -04:00
Mike Blumenkrantz
5ae00e6525
redo drop handlers to take an E_Object and Evas_Object
...
temp change to fix crashing when closing fwins with ctrl+w
2015-04-27 15:39:43 -04:00
Mike Blumenkrantz
471dcb24cb
__UNUSED__ -> EINA_UNUSED
...
this has been bugging me forever. __UNUSED__ is no longer a valid macro here.
2015-03-18 18:09:09 -04:00
Mike Blumenkrantz
f9fc4b13de
remove E_Comp usage from fileman/fwin
2015-03-18 17:40:04 -04:00
Mike Blumenkrantz
09ec213a31
remove e_util_zone_current_get() usage
2015-03-13 17:58:45 -04:00
Mike Blumenkrantz
ba7c1ac49c
remove E_Zone->comp member
2015-03-13 17:44:24 -04:00
Mike Blumenkrantz
b63e490a33
remove e_util_comp_current_get() usage
2015-03-13 16:28:08 -04:00
Mike Blumenkrantz
107ab84a19
Revert "disable fileman popups in wl-only mode"
...
This reverts commit e6c47e8d90
.
these no longer crash so reenable them
2015-03-06 16:06:17 -05:00
Mike Blumenkrantz
e6c47e8d90
disable fileman popups in wl-only mode
...
these crash for now and I'm annoyed
2015-02-27 14:45:45 -05:00
Chris Michael
96b3a04192
enlightenment: Don't crash if fwin app dialog has no exec_cmd
...
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2015-02-08 11:53:45 -05:00
Mike Blumenkrantz
ffd51904e2
ignore size hint changes for fileman popups if popup icon has been moused out
2015-01-14 20:43:32 -05:00
Mike Blumenkrantz
3afc36bbe4
de-e_comp_get()ify e_fwin
2015-01-13 22:44:55 -05:00
Mike Blumenkrantz
e30dd076e9
redo fileman tooltips to size correctly
...
exhibits edje min size calc bug/workaround
2015-01-13 22:44:55 -05:00
Mike Blumenkrantz
c978a045e6
e_entry -> elm_entry conversion
...
another dice roll in the board game of enlightenment development. next, I will attempt to roll doubles to get out of jail.
#teamborker
fix T1906
2015-01-11 12:20:46 -05:00
Mike Blumenkrantz
922af2c52f
remove e_comp_list(), deprecate all related functions for pending removal
...
there is only one E_Comp which can now be accessed by the e_comp global.
if you're editing a file with some uses of these deprecated functions, replace their usages with appropriate references to this variable
pass -Wno-deprecated-declarations to ignore these warnings during build
2015-01-05 15:39:15 -05:00
Carsten Haitzler
6510e8bd0e
Revert "all dialogs are now resizable"
...
This reverts commit 9157ca8ca7
.
this also makes all dialogs that have content in a toolbar that goes
off window at min size resizable - this is actually what you wanted ..
bgut this previous "all dialogs are resizable" thing was uber-lazy.
Conflicts:
src/modules/bluez4/e_mod_main.c
src/modules/conf_bindings/e_int_config_signalbindings.c
src/modules/conf_theme/e_int_config_theme.c
src/modules/mixer/conf_gadget.c
src/modules/shot/e_mod_main.c
2014-12-22 23:02:05 +09:00
Carsten Haitzler
87baecb098
Revert "windows - allow close button to work again in internal wins"
...
This reverts commit 285951c8cb
.
2014-11-23 13:54:14 +09:00
Carsten Haitzler
285951c8cb
windows - allow close button to work again in internal wins
...
since the move to elm_win ... windows don't close with close button in
the titlebar. this fixes that in the simplest way - enabling autodel
on the window.
2014-11-22 18:46:10 +09:00
Mike Blumenkrantz
18c1e3620d
fix fileman crash when restarting with window open
2014-11-20 15:26:22 -05:00
Mike Blumenkrantz
99589eb5af
remove E_Win+e_canvas, convert all internal wins to use elm_win
...
known issues:
* keybindings for efm windows (eg. ctrl+w) are broken until the rest of the conversion is completed
2014-11-20 15:26:21 -05:00
Chris Michael
c8dd1d95d3
modules/fileman: Fix Dereference before null check
...
Fixes CID1039814
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-09-05 10:57:21 -04:00
Mike Blumenkrantz
b944738d83
bugfix: don't save mime info when opening .desktop files
...
fix T1421
2014-07-16 10:48:48 -04:00
Mike Blumenkrantz
526bdab7c4
unset fwin win delete callback before delete during delete callback
2014-06-25 16:05:26 -04:00
Cedric BAIL
3f9af38da2
edje: remove use of deprecated functions.
2014-06-07 21:10:55 +02:00
Mike Blumenkrantz
9157ca8ca7
all dialogs are now resizable
...
any bug reports regarding issues resulting this will be ignored.
2014-05-14 13:00:35 -04:00
Chidambar Zinnoury
4db7e467c7
e fileman: Remove unused parameter.
...
Thanks Mike!
2014-05-09 16:49:43 +02:00
Mike Blumenkrantz
9e3dedb23f
hide fileman popups on window close
...
fix T1221
2014-05-07 17:46:24 -04:00
Mike Blumenkrantz
f21400e209
don't allow fileman popups to span multiple monitors
2014-05-07 11:33:48 -04:00
Chidambar Zinnoury
b4a58ad874
Bugfix: e fileman: Correct automagic window size computation.
...
When available width is less than minimum width, the height was computed according to the available width, but the window width was effectively the minimum width: its height was thus more than needed.
The function now takes the minimum dimensions so that correct height and width are computed.
2014-04-21 21:54:15 +02:00
Chidambar Zinnoury
233347209d
Bugfix: e fileman: Correct typo on height computation.
2014-04-21 21:53:05 +02:00
Chidambar Zinnoury
07cd656320
Bugfix: e fileman: Fixe information popup placement.
...
– Use zone coordinates on desktop icons to have the popup placed where it should be with multiple screens.
– Use correct window content coordinates to account for the client frame.
2014-04-21 19:36:37 +02:00
Chidambar Zinnoury
485fb36f02
Bugfix: e fileman: Client coordinates are not accounted against current zone position, so we should use them when computing maximum width and height.
...
This helps computing optimal dimensions when using multiple screens.
2014-04-21 15:56:03 +02:00
Chidambar Zinnoury
853f8b3c9a
e fileman: Use a macro for minimum dimensions instead of hardcoding them at several places.
2014-04-21 15:56:03 +02:00
Chidambar Zinnoury
3e95955a5c
Bugfix: e fileman: Typo on maximum height condition.
2014-04-21 15:56:03 +02:00
Mike Blumenkrantz
861db30df2
remove fileman dead code
...
CID 1039878
2014-04-04 15:04:28 -04:00
Mike Blumenkrantz
96806eb425
bugfix: swallow efm background objects after applying theme
...
fix T792
2014-03-28 12:23:18 -04:00
Mike Blumenkrantz
5503e29169
stringshare_replace in fwin: it exists for a reason, stop using macros ffs
2014-03-28 12:23:18 -04:00
Chris Michael
915f8f0613
@bugfix: Fix building for WAYLAND_ONLY by using the proper define
...
sed -i 's/WAYLAND_ONLY/HAVE_WAYLAND_ONLY/g'
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-03-18 07:43:04 +00:00
Mike Blumenkrantz
4b58fa9a4e
replace ev->keyname with ev->key
...
see efl 5ae4cfd1923e502731f4d8fc2bf67b1f536a9216
2014-03-13 13:03:34 -04:00
Mike Blumenkrantz
bc3e1fd94f
feature: add fileman option to clamp video size for video previews
...
T102
2014-01-27 12:28:35 -05:00
Mike Blumenkrantz
83a009c685
only block fileman zone refocus if top client is not ignored
...
T854
2014-01-27 10:58:41 -05:00