- Cleanup use of UNUSED (place after the variable).
- Add UNUSED where missing.
- Use PATH_MAX.
- Fix Formatting.
- Remove some whitespace (and other instances of wasted space).
SVN revision: 54131
The notnull.cocci script from Coccinelle finds places where you check if a
variable is NULL, but it's known not to be NULL. The check can be safely
removed. For example, this code would be caught by notnull:
if (!var) return;
if (var && var->fld) { ... }
It's needless to check again if var is not NULL because if it's in fact NULL,
it would have returned on the previous "if". This commit removes all the
trivial places where this pattern happens. Another patch will be generated for
the more complex cases.
SVN revision: 50241
This cleanup replaces snprintf() usage with specific calls, they have
the benefit of being cleaner (so easier to grep), typing less and also
marginal speed up compared to the other (specially concat_static),
although those are rarely used in critical paths.
I'm testing it for some time and seems to not break anything, but let
me know of any problem. If you can review the patch and try to spot
incorrect names, please do.
SVN revision: 40014
now a breeze to set up and use - unlike before. so now it's a wizard or
profile option out-of-the-box. it's a good example of a radical change in
profiel for a radical change in gui.
SVN revision: 37195