Commit Graph

63 Commits

Author SHA1 Message Date
Stephen 'Okra' Houston 671f881e42 Luncher/Batman: Don't access an invalid icon structure. 2017-02-10 16:22:49 -06:00
Stephen 'Okra' Houston 67a59e5df5 Luncher: Determine if client icon is an evas_object_image or edje_object. 2017-02-08 17:44:25 -06:00
Stephen 'Okra' Houston ed1d8ac971 Luncher: Don't update and show the preview on client del unless the preview exists. 2017-02-07 11:48:09 -06:00
Stephen 'Okra' Houston e41dfc7d5b Luncher: Remove closed clients from the preview popup if visible, and close the popup if no more clients are active.
This fixes T5097
2017-02-06 11:12:43 -06:00
Stephen 'Okra' Houston a89afe4186 Luncher - Free hashes at the appropriate time. 2017-02-06 10:45:58 -06:00
Derek Foreman 73aecd73ab Replace all timer_add with timer_loop_add
So yeah, I've literally used sed to replace every occurrence of
ecore_time_add() with ecore_timer_loop_add() because I'm reasonably
confident that no part of E has a legitimate need for timer based on the
exact current time.

It would be really nice if I'm not wrong. :)

The reason for this is the incredible spew of clock_gettime() calls I'm
seeing on an ARM system (that should have a vdso for gettime, but...)
This can amount to thousands of system calls per second.

 #YOLO
2017-02-03 15:52:28 -06:00
Mike Blumenkrantz 39476fad32 do not double-free lists during luncher bar empty
==15191== Invalid read of size 8
==15191==    at 0x2B6328A7: eina_list_next (eina_inline_list.x:32)
==15191==    by 0x2B637520: _bar_empty (bar.c:1405)
==15191==    by 0x2B639301: _bar_recalculate_job (bar.c:1958)
==15191==    by 0xDBDA800: _ecore_job_event_handler (ecore_job.c:98)
==15191==    by 0xDBD3AC6: _ecore_call_handler_cb (ecore_private.h:317)
==15191==    by 0xDBD4A55: _ecore_event_call (ecore_events.c:518)
==15191==    by 0xDBDDABF: _ecore_main_loop_iterate_internal (ecore_main.c:2380)
==15191==    by 0xDBDB86D: ecore_main_loop_begin (ecore_main.c:1290)
==15191==    by 0x441A94: main (e_main.c:1093)
==15191==  Address 0x1ff97dc8 is 6,520 bytes inside a recently re-allocated block of size 8,192 alloc'd
2017-01-20 11:52:27 -05:00
Stephen 'Okra' Houston 84f06597ec Enlightenment - Luncher Gadget - This fixes a massive bug in client comparisons within luncher.
This is very embarrassing.  Nothing to see here. Carry on people.
2017-01-12 16:50:37 -06:00
Stephen 'Okra' Houston 25e36fcf91 Enlightenment - Luncher gadget - Don't assume all internal windows are the same. 2017-01-12 14:31:26 -06:00
Stephen 'Okra' Houston 7422e9102f Enlightenment: Luncher gadget - Don't proceed with hiding the preview if the preview's icon is NULL. 2017-01-12 11:12:54 -06:00
Stephen 'Okra' Houston 58a9333580 Enlightenment: Sysinfo Gadget - Add an informative popup, as well as a config panel to memusage, cpumonitor, and netstatus.
Left click will give you some informative detail and right click will show the config panel with t he option to configure how often to poll.
2017-01-11 21:21:34 -06:00
Stephen 'Okra' Houston bae6700f8c Enlightenment - Luncher Gadget - Show preview immediately for icons that have iconified windows.
This fixes T4806
2017-01-11 13:21:04 -06:00
Stephen 'Okra' Houston 2565055eeb Enlightenment: Luncher - Use internal icons for non .desktop clients.
This fixes T5003
2017-01-11 12:01:30 -06:00
Stephen 'Okra' Houston 9f43e67a73 Enlightenment: Luncher gadget - don't allow .desktop actions on non .desktop icons. 2017-01-11 10:13:05 -06:00
Stephen 'Okra' Houston ddb9f99692 Enlightenment: Luncher gadget - Add more duplicate checking. 2017-01-10 16:46:39 -06:00
Stephen 'Okra' Houston 08d853ab16 Enlightenment: Luncher gadget - Don't delete the hash if there is more than one client using it. 2017-01-10 16:08:24 -06:00
Stephen 'Okra' Houston cf1d083b38 Enlightenment: Fix luncher to not duplicate clients who report as both having and not having a .desktop. 2017-01-10 15:45:13 -06:00
Stephen 'Okra' Houston 3a7509fd38 Revert "luncher: do not add clients twice"
This reverts commit 382dc8e3b0.
2017-01-10 15:38:37 -06:00
Marcel Hollerbach 382dc8e3b0 luncher: do not add clients twice
they can be part of the exec and of the Icon.

this fixes T4970
2017-01-10 14:04:50 -06:00
Stephen 'Okra' Houston a918738e65 Revert "luncher: do not add clients twice"
This reverts commit e34d1aaba9.
2017-01-10 13:54:51 -06:00
Marcel Hollerbach ecfe4fd289 luncher: free the timers
otherwise the timeout can kick in when the icon is already destroyed.

fixes T5033
2017-01-10 20:45:54 +01:00
Marcel Hollerbach e34d1aaba9 luncher: do not add clients twice
they can be part of the exec and of the Icon.

this fixes T4970
2017-01-10 20:45:13 +01:00
Stephen 'Okra' Houston 70c9fa1211 Enlightenment: Luncher gadget - Scroll the window previews when the extend beyond the current screen.
This fixes T4804
2017-01-09 11:49:54 -06:00
Stephen 'Okra' Houston 02224ae8b3 Luncher: Fix right click menu popup crash. 2017-01-06 16:16:51 -06:00
Stephen 'Okra' Houston ad32cee563 Fix luncher crash on right click
I mean really, I don't know why I write code like this, it makes
everyone around me so sad.

(commit log by Derek, paraphrased from an irc conversation)
2017-01-05 15:45:03 -06:00
Stephen 'Okra' Houston 27c8413700 Luncher: Pass the e_comp client to the preview add callback. 2016-12-14 10:27:48 -06:00
Stephen 'Okra' Houston d7f22721a2 Luncher: Add preview windows to the popup on exec if they are already visible. 2016-12-14 10:23:25 -06:00
Stephen 'Okra' Houston 49c3b1ab9b Luncher: Be aware when a ctxpopup has been dismissed but not yet deleted. 2016-12-13 14:05:17 -06:00
Stephen 'Okra' Houston f5f9bd5338 Luncher: Fix leaking caused by luncher. 2016-12-13 13:40:02 -06:00
Stephen 'Okra' Houston 396f0fe8b1 Luncher: Make sure to delete preview when icon is deleted.
This fixes https://phab.enlightenment.org/T4916
2016-12-13 09:49:56 -06:00
Stephen 'Okra' Houston 2fa1d39a0f Luncher: Make sure previews are hidden and destroyed.
This fixes https://phab.enlightenment.org/D4976
2016-12-13 09:39:31 -06:00
Marcel Hollerbach a4a9a5a628 luncher: delete the popup if there is already one
Otherwise we have two which are locking the bryce onto the screen
2016-12-02 17:17:55 +01:00
Stephen okra Houston d4a045278c Luncher: Fix Coverity Issues: CID 1366276 1366275 2016-11-28 13:05:14 -06:00
Stephen okra Houston 57f854bc59 Luncher: Add the second gadget to luncher: Luncher Grid.
Use this gadget on your desktop for a grid of icons to be used to launch applications.  The grid is simply a launcher and doesn't have all of the features that the bar has such as iconify, taskbar, styles, etc...  Please make sure to update your efl with this to get the related theme updates.
2016-11-22 21:17:22 -06:00
Stephen okra Houston 5898477cee Luncher: Make sure to correctly create config. 2016-11-22 10:46:22 -06:00
Stephen okra Houston 571f688e32 Luncher: Share common code for dismissing the window preview. 2016-11-21 13:02:19 -06:00
Chris Michael 7bcc7565f6 mark unused function parameter in Luncher as EINA_UNUSED
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2016-11-21 11:39:37 -05:00
Stephen okra Houston 16d48c353b Luncher: Make sure to free the previous window preview, not the current one on mouse in. 2016-11-21 10:02:47 -06:00
Stephen okra Houston 85d20824af Luncher: Fix ctxpopup delete leak -- Add the style chooser to the config and the engage style. 2016-11-18 14:13:53 -06:00
Stephen okra Houston 4b9ed5cee9 Luncher: Fix shadowed declarations. 2016-11-09 09:56:41 -06:00
Stephen okra Houston bc0ccf9ebb Luncher Gadget: Don't set aspect twice. 2016-11-08 12:18:38 -06:00
Stephen okra Houston 51772d1596 Luncher/Pager gadgets: Make sure to lock/unlock the gadget site on dnd. 2016-11-08 11:20:07 -06:00
Stephen okra Houston 77a0316be9 Luncher: Make sure that there is a valid drop before object on dnd. 2016-11-08 10:55:57 -06:00
Stephen okra Houston ec326b304b Luncher/Pager Gadgets: Fix coverity warnings for CID 1365330, CID 1365332 and CID 1365405
This commit also fixes T4831
2016-11-07 09:35:34 -06:00
Stephen okra Houston 6b1726dc4a Luncher: Use more accurate buffer sizes. 2016-11-05 10:53:56 -05:00
Stephen okra Houston d26900b72d Luncher: Send the off signal with orientation detail so themers can theme icons based on orientation.
You will need to make sure you update efl with this change as well.
2016-11-05 10:27:41 -05:00
Stephen okra Houston 1d202c513d Luncher: Remove useless if statements and make sure to delete an order when instance is deleted. 2016-11-04 10:22:34 -05:00
Stephen okra Houston 6c28cf2e51 Luncher: Use E_FREE_FUNC to del variables that are checked for null. 2016-11-04 10:07:13 -05:00
Stephen okra Houston ef8d86d7f3 Luncher/Pager Gadget: Fix coverity issues. 2016-11-02 09:36:03 -05:00
Stephen okra Houston 4d32ec9e4e Luncher: Use the desktop for client population if exists. 2016-11-01 19:33:37 -05:00