This cleanup replaces snprintf() usage with specific calls, they have
the benefit of being cleaner (so easier to grep), typing less and also
marginal speed up compared to the other (specially concat_static),
although those are rarely used in critical paths.
I'm testing it for some time and seems to not break anything, but let
me know of any problem. If you can review the patch and try to spot
incorrect names, please do.
SVN revision: 40014
In E_Dialog space key grabbed before than keydown event reach to entry widget
in E_Entry_Dialog.
Thus, I forced ungrab space key in e_entry_dialog_show constructor.
Moreover, I added escape key handling in _e_entry_cb_key_down callback.
I do not delete space key grub in E_Dialog, because, I think, it may be
usefull here,
when we need selecting controls with space. Or not?
SVN revision: 39936
I was replicating this code in many places, it should go into eina itself.
It's the right way to change strings that you don't know are
stringshared before, since it will first add a reference and then
remove, making it impossible to have references to go 0 and string
being released before adding new references, fixing the following
possible problem:
x = eina_stringshare_add("x");
replace(x, x);
then:
incorrect_replace(const char **b, const char *a) {
eina_stringshare_del(*b); /* reference gets to 0 */
eina_stringshare_add(a); /* BUG!!! */
*b = a;
}
SVN revision: 39903
the e_main.c change might prove useful as it will minimize path
resolution a lot, something that is not that cheap, even more durin e
startup where disc is still spinning due other tasks
starting. HOWEVER, it might bring problems to those using pre
GLibC-2.4 (we're at 2.9 these days) and maybe people using Solaris or
BSD, let's see if they have any trouble.
SVN revision: 39880
for it - need to improve the thum frames anyway. also the all desktops/this
desk/this screen now works. need to next add add pic/add exhcange/add
gradient buttons
SVN revision: 39867
The edc was generated as
align: 1,3333 1,333;
and thus edje_cc refused to build.
I have done a quick HACK. simply set locale to "C" and the reset to previous locale.
If someone know a cleaner way to solve this issue please let me know.
POSSIBLE ALTERNATIVE SOLUTION:
Why we don't make E able to directly load image files?
I think it's just a matter of 2 lines of code...or am I wrong?
Doing this we can remove all this hackish code to generate edc.
Thanks
Dave
SVN revision: 39848