Commit Graph

118 Commits

Author SHA1 Message Date
Mike Blumenkrantz 14a6ac6458 unset E_Client->internal_elm_win before deleting the client in e_win
==24509== Invalid write of size 8
==24509==    at 0x502D00: _e_elm_win_trap_del (e_win.c:39)
==24509==    by 0x509BFC2: _elm_win_evas_object_smart_del (elm_win.c:1886)
==24509==    by 0x91F4643: evas_obj_smart_del (in /usr/lib/libevas.so.1.15.99)
==24509==    by 0x91F5B5C: evas_object_smart_del (evas_object_smart.c:1021)
==24509==    by 0x91E9107: _evas_object_eo_base_destructor (evas_object_main.c:739)
==24509==    by 0xE54A8A3: eo_destructor (in /usr/lib/libeo.so.1.15.99)
==24509==    by 0x5086715: _elm_widget_eo_base_destructor (elm_widget.c:5744)
==24509==    by 0xE54A8A3: eo_destructor (in /usr/lib/libeo.so.1.15.99)
==24509==    by 0xE5443EC: _eo_del_internal (eo_private.h:221)
==24509==    by 0xE5443EC: _eo_unref (eo_private.h:295)
==24509==    by 0xE5443EC: _eo_do_end (eo.c:546)
==24509==    by 0x4D5B1A: _e_obj_dialog_free (e_obj_dialog.c:125)
==24509==    by 0x4D61FB: e_object_free (e_object.c:152)
==24509==    by 0x4D61FB: e_object_unref (e_object.c:152)
==24509==    by 0x4EDC54: _e_sys_logout_after (e_sys.c:750)
==24509==    by 0x4ED7AC: _e_sys_action_do (e_sys.c:925)
==24509==    by 0x4EE348: e_sys_action_raw_do (e_sys.c:311)
==24509==    by 0x4EE43F: _e_sys_comp_done_cb (e_sys.c:66)
==24509==    by 0x6097348: _edje_emit_cb (edje_program.c:1476)
==24509==    by 0x6097348: _edje_emit_handle (edje_program.c:1405)
==24509==    by 0x60924EE: _edje_message_queue_process (edje_message_queue.c:787)
==24509==    by 0x60926A6: _edje_job (edje_message_queue.c:154)
==24509==    by 0xCC5087A: _ecore_job_event_handler (ecore_job.c:121)
==24509==    by 0xCC4B204: _ecore_call_handler_cb (ecore_private.h:390)
==24509==    by 0xCC4B204: _ecore_event_call (ecore_events.c:565)
==24509==    by 0xCC52AE7: _ecore_main_loop_iterate_internal (ecore_main.c:1927)
==24509==    by 0xCC52CD6: ecore_main_loop_begin (ecore_main.c:983)
==24509==    by 0x4383F4: main (e_main.c:1047)
==24509==  Address 0x14fb1a28 is 1,176 bytes inside a block of size 1,352 free'd
==24509==    at 0x4C2A65B: free (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==24509==    by 0x4D61FB: e_object_free (e_object.c:152)
==24509==    by 0x4D61FB: e_object_unref (e_object.c:152)
==24509==    by 0x502CED: _e_elm_win_trap_del (e_win.c:37)
==24509==    by 0x509BFC2: _elm_win_evas_object_smart_del (elm_win.c:1886)
==24509==    by 0x91F4643: evas_obj_smart_del (in /usr/lib/libevas.so.1.15.99)
==24509==    by 0x91F5B5C: evas_object_smart_del (evas_object_smart.c:1021)
==24509==    by 0x91E9107: _evas_object_eo_base_destructor (evas_object_main.c:739)
==24509==    by 0xE54A8A3: eo_destructor (in /usr/lib/libeo.so.1.15.99)
==24509==    by 0x5086715: _elm_widget_eo_base_destructor (elm_widget.c:5744)
==24509==    by 0xE54A8A3: eo_destructor (in /usr/lib/libeo.so.1.15.99)
==24509==    by 0xE5443EC: _eo_del_internal (eo_private.h:221)
==24509==    by 0xE5443EC: _eo_unref (eo_private.h:295)
==24509==    by 0xE5443EC: _eo_do_end (eo.c:546)
==24509==    by 0x4D5B1A: _e_obj_dialog_free (e_obj_dialog.c:125)
==24509==    by 0x4D61FB: e_object_free (e_object.c:152)
==24509==    by 0x4D61FB: e_object_unref (e_object.c:152)
==24509==    by 0x4EDC54: _e_sys_logout_after (e_sys.c:750)
==24509==    by 0x4ED7AC: _e_sys_action_do (e_sys.c:925)
==24509==    by 0x4EE348: e_sys_action_raw_do (e_sys.c:311)
==24509==    by 0x4EE43F: _e_sys_comp_done_cb (e_sys.c:66)
==24509==    by 0x6097348: _edje_emit_cb (edje_program.c:1476)
==24509==    by 0x6097348: _edje_emit_handle (edje_program.c:1405)
==24509==    by 0x60924EE: _edje_message_queue_process (edje_message_queue.c:787)
==24509==    by 0x60926A6: _edje_job (edje_message_queue.c:154)
==24509==    by 0xCC5087A: _ecore_job_event_handler (ecore_job.c:121)
==24509==    by 0xCC4B204: _ecore_call_handler_cb (ecore_private.h:390)
==24509==    by 0xCC4B204: _ecore_event_call (ecore_events.c:565)
==24509==    by 0xCC52AE7: _ecore_main_loop_iterate_internal (ecore_main.c:1927)
==24509==    by 0xCC52CD6: ecore_main_loop_begin (ecore_main.c:983)
==24509==    by 0x4383F4: main (e_main.c:1047)
2015-09-29 12:58:13 -04:00
Mike Blumenkrantz 8491e11570 always set alpha for internal wins
due to the presence of color classes on internal windows, e must
ensure that users who set translucent colors for window base objects
get transparency as expected on those parts of the window. it's impossible
to determine in advance whether alpha is needed, so it's best to just
set alpha in all cases

fix T2050
2015-09-21 15:16:30 -04:00
Mike Blumenkrantz 847d3fe358 reject internal window moves when they originate from a wl configure event
fixes a number of internal win positioning issues
2015-07-30 16:22:08 -04:00
Chris Michael 0a94e8ba71 enlightenment: Make E build again with EFL from git
sed -i 's/EAPI/E_API/g'

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2015-05-07 15:13:10 -04:00
Chris Michael 93971bb6fc Fix T2385 : internal windows not showing resize cursor
If we are going to set the internal elm windows to borderless and
handle frames inside E, then we need to also unset any existing
pointer objects which may be on the wayland Ecore_Evas.

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2015-05-04 12:40:06 -04:00
Mike Blumenkrantz e4298517dd add internal win trap to set override property on windows 2015-04-27 13:56:56 -04:00
Mike Blumenkrantz 59ea27e819 set internal win icccm name/class/title during win trap show
wl clients have no concept of icccm name, so this is the only way to set it

also, setting it here makes it available sooner for other functionalities
2015-04-27 13:55:47 -04:00
Mike Blumenkrantz 9c573a49ac fix internal win pixmap id int size in show trap 2015-04-23 12:35:22 -04:00
Mike Blumenkrantz 96f07bff8a wl client pixmaps now use a different method for creating the pixmap id 2015-04-21 15:19:20 -04:00
Derek Foreman 1fb1f17db0 Fix wayland compositor on 32 bit systems
Summary:
_e_elm_win_trap_show() treats Ecore_Window as a 64bit data type when
it's actually the same size as the system's pointer type.

 #24HourFullPowerNoToiletNoShower

Reviewers: devilhorns, zmike

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D2388

fix T2194
2015-04-20 18:18:20 -04:00
Mike Blumenkrantz 471dcb24cb __UNUSED__ -> EINA_UNUSED
this has been bugging me forever. __UNUSED__ is no longer a valid macro here.
2015-03-18 18:09:09 -04:00
Mike Blumenkrantz 1736d1ecb9 e_client functions no longer require E_Comp param 2015-03-13 16:53:19 -04:00
Mike Blumenkrantz 08328f0c19 conditionally compile elm win trap wayland functionality 2015-03-12 14:28:18 -04:00
Mike Blumenkrantz a7dae25236 Revert "e - fix build when wayland not enabled"
This reverts commit 413ca8046e.

broke wayland runtime: wrong define names, wrong usage
2015-03-12 14:23:22 -04:00
Chris Michael 3dff7d4dad enlightenment: Fix 'type' may be used uninitialized message
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2015-02-07 11:18:45 -05:00
Carsten Haitzler 413ca8046e e - fix build when wayland not enabled 2015-02-07 12:30:19 +09:00
Mike Blumenkrantz 270bc92f81 add wl util function for calculating pixmap id 2015-02-06 18:32:07 -05:00
Carsten Haitzler 6ef73fb3f0 adapt to new win center trap in 1.13 efl
also require 1.13 now as we want he win trap h/v info
2015-02-06 11:37:52 +09:00
Mike Blumenkrantz d9fec13343 don't hide client before delete in win del trap 2015-02-01 19:05:21 -05:00
Mike Blumenkrantz 1680de7ff2 use new pixmap id for internal wl wins 2015-01-28 17:34:05 -05:00
Mike Blumenkrantz d94a76db15 preserve internal window borderless state when set prior to showing window 2015-01-23 16:22:14 -05:00
Mike Blumenkrantz 03c5915245 force server borders on internal wl wins again
this goes back to previous behavior before elm win conversion
2015-01-23 14:10:58 -05:00
Mike Blumenkrantz 665a399b14 de-e_comp_get()ify e_win 2015-01-23 14:10:58 -05:00
Mike Blumenkrantz 847ce5b0d5 never uncenter a centered internal window
a window which has received a call to elm_win_center() can now never auto-uncenter in either axis

ref T2031
2015-01-22 22:39:46 -05:00
Mike Blumenkrantz f8d846e0c9 set client frame geometry for new internal wins based on ee geometry 2015-01-20 19:20:07 -05:00
Mike Blumenkrantz f6fa99eb5f only set internal win name/class if not already set 2015-01-15 03:05:20 -05:00
Mike Blumenkrantz fc01bac0bf Revert "fix centering of elm wayland windows"
This reverts commit 1ec2a4e91c.

this may have fixed wayland window centering, but only because it effectively turns the function into a no-op instead of actually centering the window
2015-01-13 22:44:55 -05:00
Chris Michael 1ec2a4e91c fix centering of elm wayland windows
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2015-01-12 13:36:58 -05:00
Mike Blumenkrantz 915d3089ea unwrap INLINE_IMAGE window creation 2015-01-10 00:58:49 -05:00
Mike Blumenkrantz 922af2c52f remove e_comp_list(), deprecate all related functions for pending removal
there is only one E_Comp which can now be accessed by the e_comp global.

if you're editing a file with some uses of these deprecated functions, replace their usages with appropriate references to this variable

pass -Wno-deprecated-declarations to ignore these warnings during build
2015-01-05 15:39:15 -05:00
Mike Blumenkrantz 521a7f071e use frame geometry in win resize trap to get accurate sizes
ref T1905
2014-12-30 17:00:23 -05:00
Mike Blumenkrantz f3f3cedd03 only use elm win title for internal windows if it has been set 2014-12-14 15:40:25 -05:00
Marcel Hollerbach ec64288d4f e_win: Fix Dialog Titles
We should not set the title to "E" in the trap function of show.
If we do this we will override the icccm title and the netwm name, this
mean e_comp_x will set E as title of the window if the call to
elm_win_title_set was BEFORE the window was shown.

Now the name which was set before will be inserted.
2014-12-14 12:21:16 +01:00
Carsten Haitzler 87baecb098 Revert "windows - allow close button to work again in internal wins"
This reverts commit 285951c8cb.
2014-11-23 13:54:14 +09:00
Mike Blumenkrantz a16206c6f1 only show comp obj during internal win show if win not already visible
fix T1863
2014-11-22 12:47:19 -05:00
Carsten Haitzler 285951c8cb windows - allow close button to work again in internal wins
since the move to elm_win ... windows don't close with close button in
the titlebar. this fixes that in the simplest way - enabling autodel
on the window.
2014-11-22 18:46:10 +09:00
Mike Blumenkrantz a4b1d63fea fix internal window closing with frame button 2014-11-21 13:34:32 -05:00
Mike Blumenkrantz eaa471b418 resolve recent coverity complaints 2014-11-21 10:21:13 -05:00
Mike Blumenkrantz 462c2ef4aa rename elm win trap functions for easier namespace debugging 2014-11-20 15:26:22 -05:00
Mike Blumenkrantz ffa98586a4 add macro wrapper to force elm win accel disabling on internal windows 2014-11-20 15:26:21 -05:00
Mike Blumenkrantz 99589eb5af remove E_Win+e_canvas, convert all internal wins to use elm_win
known issues:

* keybindings for efm windows (eg. ctrl+w) are broken until the rest of the conversion is completed
2014-11-20 15:26:21 -05:00
Chris Michael ffe713d0df bugfix: use existing compositor canvas pointer as the windows pointer
when doing wayland windows (internal dialogs), and in such a case
don't free the window pointer on window hide/destroy.

NB: This fixes the case when running wayland-only and dialogs would
actually show 2 pointers.

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-09-04 15:55:18 -04:00
Chris Michael 7f9eefbd7b destroy pointer when destroying window since we create new pointers
for every window again.

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-08-28 11:40:19 -04:00
Chris Michael 6440aa513f create window pointer based on compositor type
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-08-28 11:08:36 -04:00
Chris Michael 6b56465bac use a new e_pointer for the window canvas
This fixes an issue where internal dialogs were not using the e
cursors but would default back to an x cursor

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-08-26 14:36:57 -04:00
Chris Michael 8c90407ce7 use the pointer from the compositor for e_win and don't free the pointer when the window closes
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-08-26 10:10:37 -04:00
Chris Michael 86ca279327 Fix defines for building with wayland-only or wayland-client support.
NB: This fixes internal dialogs not having frames

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-08-26 10:10:36 -04:00
Chris Michael c40d085ccf check for existing pixmap when showing a window so we don't create a
new pixmap if we don't need to.

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-08-26 10:10:35 -04:00
Mike Blumenkrantz e0125a483a fix internal transient clients 2014-08-26 00:27:08 -04:00
Chris Michael 3d28a91c6b @bugfix: Create window pointer for wayland clients
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-03-18 07:43:05 +00:00