a11492784d
fix formatting
...
NB: No functional changes
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2016-12-15 10:19:21 -05:00
3a714c6e04
add missing EINA_UNUSED for unused function parameters
...
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2016-12-15 10:17:19 -05:00
30ba420c6d
E_Config: Fix auto load of luncher
...
This fixes T5007 https://phab.enlightenment.org/T5007
2016-12-15 09:00:35 -06:00
46ae444069
E_Config: Auto load luncher if ibar is enabled and bump config.
2016-12-14 11:52:10 -06:00
a73ad1b190
plug iterator leak in e_comp_object_render()
...
==13307== 96 bytes in 1 blocks are definitely lost in loss record 6,598 of 11,698
==13307== at 0x4C2DA60: calloc (vg_replace_malloc.c:711)
==13307== by 0xCECA287: eina_tiler_iterator_new (eina_tiler.c:1299)
==13307== by 0x46D13D: e_comp_object_render (e_comp_object.c:3966)
==13307== by 0x46DB42: e_comp_object_dirty (e_comp_object.c:3923)
==13307== by 0x46017D: _e_comp_client_update (e_comp.c:343)
==13307== by 0x46017D: _e_comp_cb_update (e_comp.c:400)
==13307== by 0xB34D4BA: _ecore_job_event_handler (ecore_job.c:98)
==13307== by 0xB34909C: _ecore_call_handler_cb (ecore_private.h:317)
==13307== by 0xB34909C: _ecore_event_call (ecore_events.c:518)
==13307== by 0xB350527: _ecore_main_loop_iterate_internal (ecore_main.c:2359)
==13307== by 0xB3508A6: ecore_main_loop_begin (ecore_main.c:1287)
==13307== by 0x43C88A: main (e_main.c:1093)
2016-12-14 11:44:58 -05:00
27c8413700
Luncher: Pass the e_comp client to the preview add callback.
2016-12-14 10:27:48 -06:00
d7f22721a2
Luncher: Add preview windows to the popup on exec if they are already visible.
2016-12-14 10:23:25 -06:00
49c3b1ab9b
Luncher: Be aware when a ctxpopup has been dismissed but not yet deleted.
2016-12-13 14:05:17 -06:00
0493abf457
Fix wayland frame callback times
...
ecore_time_unix_get() * 1000 is too big to fit in a uint32, so take the
time we instantiate the wayland pixmap hash and use that as a base.
2016-12-13 13:54:21 -06:00
f5f9bd5338
Luncher: Fix leaking caused by luncher.
2016-12-13 13:40:02 -06:00
e62423603a
correctly set E_POINTER_RESIZE_BR mode for client keyboard resizing
...
typo from when this was refactored
fix T2452, T2579
2016-12-13 11:10:13 -05:00
396f0fe8b1
Luncher: Make sure to delete preview when icon is deleted.
...
This fixes https://phab.enlightenment.org/T4916
2016-12-13 09:49:56 -06:00
2fa1d39a0f
Luncher: Make sure previews are hidden and destroyed.
...
This fixes https://phab.enlightenment.org/D4976
2016-12-13 09:39:31 -06:00
179979ccb0
do not set aspect on luncher grid gadgets
...
this is not a 1:1 gadget, it automatically fills whatever size the gadget
has allotted and performs layout optimally based on that size
2016-12-12 11:55:57 -05:00
15c0d46050
xkbswitch: rewrite the config panel to improve the gui design
2016-12-11 21:25:17 +01:00
b4f3a8da0a
Enlightenment: Factor all sysctl battery code for bsd into e_mod_sysctl.c
...
This commit should now allow battery to support OpenBSD, FreeBSD, Dragonfly BSD, and NetBSD
2016-12-09 11:02:43 -06:00
485f250880
don't track gadget drop handler objects for deletion
...
the user should be managing this
2016-12-09 11:59:24 -05:00
4e3ea4f6b3
add some internal functions for triggering fake screen hotplug events
...
debugging is fun
2016-12-09 11:52:03 -05:00
3bae673848
null out bryce and site pointers when deleting bryce object
...
fixes handling of bryces when changing screen setup
2016-12-09 11:52:03 -05:00
20166f16be
make mouse pointer visibility syn with hotplug/un-plug
...
This patch makes the mouse pointer disappear when the physical mouse
device is unplugged. It also makes the mouse pointer reappear when a
physical mouse is hotplugged.
NB: There is one small hiccup with this patch and that is: when you
re-plug the mouse in the pointer itself doesn't show until you
physically move the mouse. Tried several things locally to sort it
out, but no success :/
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2016-12-09 08:56:32 -05:00
f1c70e626f
null out animator pointers in efx stop() operations
2016-12-08 11:20:45 -05:00
ae9d2904c7
test dmabuf pixmaps properly
...
If we can't handle a dmabuf format we now properly tell the client instead
of accepting it anyway and falling apart later.
2016-12-06 16:37:35 -06:00
fd6b264b1d
maintain "empty" object's size hints when ibar/ibox resizes
...
the sizing issue in all of these tickets was caused by the "empty" object
being deleted, thus allowing the box to reset to 0x0 size hints and
returning this value as the overall size during recalc; the result is that
all icons would be sized at 0x0 instead of using the preserved orient size
as expected
fix T4509, T4647, T4830, T4733, T4524
2016-12-06 11:39:33 -05:00
3b1242e314
revert all sizing commits to ibar/ibox for the past year
...
the assumption that this code was making assumptions about elm_box
internals based on a shallow reading of the code was incorrect, and
the resulting "fix" (and subsequent attempts to bandaid it) has left these
gadgets in an unusable state for the past half year.
disappoint.jpg
this reverts the following commits:
f97f8f61acebfa4a97cd50030dc69342aa6be359504706d45ab1f608c5e6b107dc1cdc3fc195cd9f
2016-12-06 11:27:50 -05:00
0e4ddaffbe
use better check for getting wl surface alpha from cursor pixmaps
...
ref 6ba85cf864
2016-12-05 11:05:24 -05:00
b1037cbc5c
Revert "Check for deleted client in e_pixmap_image_is_argb"
...
This reverts commit 6ba85cf864
2016-12-05 11:05:24 -05:00
8f39054965
handle pass_event clients in e_comp_object_coords_inside_input_area
...
fix T4966
2016-12-05 11:05:24 -05:00
ca7c77d05e
fix internal wl windows to exit when border X is clicked
2016-12-05 10:49:06 -05:00
Carsten Haitzler
a15ac5f039
temp module - avoid a bit of cpu sendingh edje message if temp same
...
each poll - check if temp actually changed and only send edje message
if tempt actually did change. saves some cpu while polling in the bg
for these things.
@optimize
2016-12-04 22:46:02 +09:00
Carsten Haitzler
bdbd0f4753
e cpufreq - dont emit message for min/max/cur freq if they didnt change
...
saves some cpu when idile and polling cpu fre and finding nothing
changed.
@optimize
2016-12-04 22:42:47 +09:00
Carsten Haitzler
1c8c57b702
temp - udev pol - do in mainloop and suffer as appropriate
...
if a poll takes a few hundred ms ... the so be it. udev is for
mainloop only. don't use it - that's my advice (for temp module).
:)
2016-12-03 11:30:01 +09:00
cf1d253c56
Pager Gadget: Don't recalculate the pager if the zone is NULL.
...
This fixes https://phab.enlightenment.org/T4960
2016-12-02 11:28:10 -06:00
a4a9a5a628
luncher: delete the popup if there is already one
...
Otherwise we have two which are locking the bryce onto the screen
2016-12-02 17:17:55 +01:00
e42b072f38
attempt to re-set wl surface pointer when popping back to "default" pointer type
...
this automatically handles the case where enlightenment has commandeered the
cursor temporarily and the active client has not unset+set a new cursor in the
meantime
2016-12-02 10:54:06 -05:00
5f246e079b
set wl pointer surfaces to E_LAYER_CLIENT_PRIO during setup
...
these later get overridden onto the pointer layer, but setting a layer
here ensures that the pointer surface will always be the client
returned by e_client_top_get()
2016-12-02 10:54:06 -05:00
647e998b72
do not pop pointer types on client hide events if the client is pass_events
...
these clients cannot receive events and thus have no pointer to pop
2016-12-02 10:54:06 -05:00
4aba7e7beb
remove unused variables in e_comp_wl
...
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2016-12-02 10:41:46 -05:00
531fcb8577
apply better algorithm during xdg6 positioner slide calc
...
try useful geometry, then base zone geometry. also restrict slide to being
adjacent to parent surface's anchor
2016-12-02 10:23:04 -05:00
6f4d77d10a
disable xdg6 positioner resize hints
...
this is stupid so we're not going to do it
#leadership
2016-12-02 10:04:52 -05:00
ba035ff807
mark Ecore_Thread parameter as EINA_UNUSED
...
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2016-12-02 09:34:24 -05:00
7d8266995d
verify shell client delete functions are operating on wayland clients.
...
ref cc795bfbda
2016-12-02 09:29:44 -05:00
cc795bfbda
Revert "verify valid client comp_data before accessing it directly"
...
Reverting this in favor of a different fix.
This reverts commit bbad744060
2016-12-02 09:25:54 -05:00
bbad744060
verify valid client comp_data before accessing it directly
...
ref 8173c06c4d
2016-12-02 09:12:29 -05:00
Carsten Haitzler
c5a293919b
temperature module - more non-eeze system fixes
...
i have eeze so i didnt notice. thanks @netstar
fixes D4446
2016-12-02 11:53:54 +09:00
f740616961
bsd patch from netstar fixing threaded tempget
...
this fixes T4945 .
2016-12-02 11:52:12 +09:00
cd4c3ecc5d
free xdg-shell data for xdg5 surfaces
2016-12-01 12:14:25 -05:00
8173c06c4d
add handler for triggering xdg-shell data cleanup on client del
...
in the case of internal windows, the client is deleted before any surfaces
are destroyed. this requires a special case to perform cleanups in order to
prevent client objects from leaking
2016-12-01 12:14:25 -05:00
41e60d251e
Stop sending key up/down events on focus change under wayland
...
We shouldn't be doing this, but there's a collective memory that
this was put in place to fix stuck modifier bugs.
If we run into stuck modifiers again because of this patch, then we
should be fixing them in a different way.
If anyone bisects to this point, I apologize - assign me a ticket.
2016-12-01 10:55:49 -06:00
08ee9293df
feed mouse move and canvas mouse up upon breaking a wl surface grab
...
ensure that the hw pointer location and the cursor location match after grabs
fix T4939
2016-12-01 11:22:42 -05:00
Carsten Haitzler
a94ba7cbfd
e tempget module - mode to using threads instead of tempget binary
...
this should reduce mem usage by a sub binary and aso solve the sub
shell kill issue too nd still keep the polling of system status out of
the mainloop and keep it unblocked.
2016-12-01 08:49:33 +09:00
Carsten Haitzler
8934ada4d8
e_util_defer_object_del - ensure order of deferred deletions are right
...
so since e_util_defer_object_del used a before idler this would
reverse deletion order vs the order submitted. this may cause issues.
not sure. chasing netstar's "animator stops" issue, but if defered
deletion if disabled seems to stop it from happening.
at least fix order if multiple deferred deletions are queued
@fix
2016-12-01 08:49:33 +09:00
60617c82d7
More aggressively prune keyboard focus list
...
Even if a client is deleted we still need to get its resources off the
keyboard focus list.
2016-11-30 14:48:54 -06:00
ce34c550e7
Fix crash when exiting an xdg shell application
...
The focus in timer has been firing for deleted clients, this causes a
NULL pointer dereference.
Then again, maybe the timer should've been disabled by now...
2016-11-30 14:48:54 -06:00
8245c1eb7a
Fix keyboard tracking when leaving an xdg shell window
...
_parent_client_contains_pointer() shouldn't return true if there is no
parent client. This could result in leaving stale resources in the
keyboard focus list and crash the compositor.
2016-11-30 14:48:54 -06:00
ca5176e6fa
handle input detection for wl surface grabs more accurately using stacking
...
this should more accurately handle cases where mouse movements over grabbed
surfaces are intercepted by overlapping windows
2016-11-30 12:46:54 -05:00
f83045dc62
move the comp canvas cursor object during wl surface grabs
...
the struct member is not guaranteed to be the visible object, so get
the ee cursor and move that
2016-11-30 12:34:30 -05:00
a3a239c1d0
use correct coords for determining input region calcs on comp objects
2016-11-30 12:34:30 -05:00
3313f0f26d
Fix crash on xdg shell unbind
...
Running weston-simple-dmabuf-intel and killing it could crash E in
xdg_shell_unbind.
2016-11-30 10:19:40 -06:00
f58eb2db7b
use more accurate determination for applying xdg-shell (un)maximize operations
...
fixes maximizing again
2016-11-30 11:16:24 -05:00
d0b0f81fb7
teamwork: Use emile SHA1 functions
...
Remove the SHA1 functions in the module in favour of the ones now present in
EFL
2016-11-29 11:32:25 -06:00
6ba85cf864
Check for deleted client in e_pixmap_image_is_argb
...
Fixes a crash when closing Qt applications.
2016-11-29 11:13:50 -06:00
f5788293b5
check gravity variable for gravities when applying xdg6 positioners
...
fixes positioning
--(typo--)
2016-11-29 11:45:39 -05:00
632e4097b5
always send valid size geom when configuring xdg6 popups
...
sending 0x0 here when passed (which happens during initial commit)
breaks the universe
2016-11-29 11:44:29 -05:00
79d157f5d5
fix use of E_CONTAINS macro for xdg-shell positioners
...
last week was backwards week
2016-11-29 11:30:27 -05:00
7851769eab
handle illegal xdg-shell resource unbinds
...
this occurs when the shell resource dies before all the surfaces/positioners
are destroyed. usually this means the client has aborted, so there's no point in
sending an error or doing anything beyond performing a thorough cleanup
2016-11-29 11:30:24 -05:00
50b2712f61
destroy xdg role surfaces if base surface is destroyed
...
this is illegal, but at least we should not leak the client when it happens
2016-11-29 11:09:31 -05:00
2a9d4e73c5
correctly handle xdg surface deletion and pointer clearing
...
fixes crashing/leaking when deleting surfaces
2016-11-29 11:08:46 -05:00
19a902ec09
stack subsurfaces above their parents upon creation
...
handles the case where no explicit stacking is set on the subsurface
2016-11-29 10:11:23 -05:00
bf40d92ad8
handle xdg-shell maximize/unmaximize calls correctly
2016-11-29 10:11:23 -05:00
d3b5b5a48d
remove unused variable in Luncher module
...
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2016-11-29 08:56:55 -05:00
d4a045278c
Luncher: Fix Coverity Issues: CID 1366276 1366275
2016-11-28 13:05:14 -06:00
cf088eb989
Add temperature support for DragonFly BSD.
...
Reviewers: zmike!
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D4432
2016-11-28 10:43:28 -05:00
c8f5f942d0
E: fix Wayland without xwayland build
...
When building enlightement without xwayland, we need to provide
MESA_EGL_NO_X11_HEADERS in the CFLAGS to avoid including X11/Xlib.h.
This define is provided by WAYLAND_EGL_CFLAGS, so add it for E modules
and e_fm build.
Fixes:
In file included from /usr/include/EGL/egl.h:39:0,
from ./src/bin/e.h:108,
from src/modules/mixer/lib/backends/pulseaudio/pulse.c:1:
/usr/include/EGL/eglplatform.h:119:22: erreur fatale : X11/Xlib.h
Signed-off-by: Romain Naour <romain.naour@gmail.com>
2016-11-28 10:43:28 -05:00
b133dbd35d
prevent divide by zero when calculating gadget aspect sizing
2016-11-28 10:43:28 -05:00
76d787b7c9
use ecore_evas_screen_dpi_get to get screen dpi under wayland
...
This small patch modifies the conf_theme module to use screen dpi from
the compositor canvas (thus getting server screen dpi) for use in
scaling.
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2016-11-28 10:26:20 -05:00
96d517a6f2
use ecore_evas_screen_dpi_get when updating e_scale value
...
Now that the ecore_evas_drm code can return screen dpi, we can use
that rather than using a client API function (ecore_wl2) to get server
screen dpi.
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2016-11-28 10:10:28 -05:00
9f3de5e346
Fix wayland deferred buffer free crash
...
We'd sometimes get a stale pointer when doing a deferred buffer free.
2016-11-25 11:14:38 -06:00
a3f2752fe0
removed unused variable from luncher code and add missing EINA_UNUSED
...
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2016-11-23 11:04:16 -05:00
ddaf5b9a20
add missing EINA_UNUSED for unused function parameters
...
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2016-11-23 11:02:49 -05:00
975366ba7b
Cpufreq: Don't check for NULL then depend on the value not being NULL. Fixes CID 1365406
2016-11-23 09:59:29 -06:00
57f854bc59
Luncher: Add the second gadget to luncher: Luncher Grid.
...
Use this gadget on your desktop for a grid of icons to be used to launch applications. The grid is simply a launcher and doesn't have all of the features that the bar has such as iconify, taskbar, styles, etc... Please make sure to update your efl with this to get the related theme updates.
2016-11-22 21:17:22 -06:00
5898477cee
Luncher: Make sure to correctly create config.
2016-11-22 10:46:22 -06:00
8f8b25ae7d
make fake mouse-out upon focus-out conditional on pending pointer warp
...
in the case where warping would not occur and a mouse-based focus policy was
not in use, this would break mouse eventing on wayland when a window lost focus
but the cursor remained inside the window
ref 3e6d6b348f
2016-11-22 11:31:22 -05:00
e95541635e
clarify some wl surface checks to require elm wins
...
these should not apply to role-less surfaces
2016-11-22 11:31:22 -05:00
7b7e56af0c
require an elm win to apply auto-visibility for internal wins in wl surface commit
...
other internal surfaces could be things like cursors, and these should not be made visible
before setting a role
2016-11-22 11:31:22 -05:00
5497fadce4
xdg6 support
2016-11-22 11:31:22 -05:00
232c73fe83
add e_comp_object_coords_inside_input_area()
2016-11-22 11:31:22 -05:00
5130935284
add e_client_util_top_parent_get()
2016-11-22 11:31:22 -05:00
689441781a
connman: avoid random memory walk in case dbus data aren't provided by connman.
2016-11-21 12:46:59 -08:00
571f688e32
Luncher: Share common code for dismissing the window preview.
2016-11-21 13:02:19 -06:00
5efc978513
Luncher module: Use the correct icon for the .desktop.
2016-11-21 12:30:30 -06:00
7bcc7565f6
mark unused function parameter in Luncher as EINA_UNUSED
...
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2016-11-21 11:39:37 -05:00
16d48c353b
Luncher: Make sure to free the previous window preview, not the current one on mouse in.
2016-11-21 10:02:47 -06:00
33ecfe5b99
scale: Allow user to choose scale not multiplier
...
Misleading text now makes sense.
2016-11-19 15:54:50 +00:00
85d20824af
Luncher: Fix ctxpopup delete leak -- Add the style chooser to the config and the engage style.
2016-11-18 14:13:53 -06:00
506317e4ba
make confirm dialogs autoselect the confirm option
...
esc is already used for cancel, having an easier confirm makes sense (tm)
2016-11-18 11:17:14 -05:00
348a3be719
reject non-printable characters from lokker entry
...
previously characters such as tab would be injected into the entry when pressed.
this is the same check which is used in various other places in efl for string
validation
2016-11-18 10:19:14 -05:00
02fc2fffa8
disable bindings during desklock
...
hopefully nobody noticed this before now...
2016-11-18 10:18:51 -05:00
0a696f5fa3
fix missing definition of DRM_FORMAT_XRGB8888
...
As we do not compile-time link with libdrm inside Ecore_Drm2 anymore,
we need to include relivant bits of drm_fourcc header here in order to
define DRM_FORMAT_XRGB8888 else we fail to compile Enlightenment Wayland
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2016-11-16 09:17:15 -05:00
Carsten Haitzler
c3ec526cec
wizard - do not set scale to 1.2 forcibly. use dpi as the def prof says
...
the default profiel is configureed to use dpi to scale. if dpi goes up
so does wizard scaling. setitng to 1.2 forcibly is just wrong. imagine
a uhd screen thats 13" or imagine an 8k display... at least if dpi can
be read correctly things work out find. think the base dpi of 90 is
too high - then adjust that in profile... but not in wizard code.
this has been here a while and i always thought this scaling bumping
was a dpi effect. it wasnt. it was hardcoded. bad bad.
@fix.
2016-11-16 11:25:11 +09:00
573035e262
focus confirmation option in efm delete dialog
...
fix T4797
2016-11-11 09:58:58 -05:00
f7f0cc5b3e
only unset cur_mouse_action on client menu delete for the right action
...
ref 50198ecdde
2016-11-10 11:55:10 -05:00
7d29dbf4ec
send orientation signal to bryce scroller theme
2016-11-10 11:52:04 -05:00
50198ecdde
unset cur_mouse_action upon deleting client menu
...
fix T4522
2016-11-10 11:14:36 -05:00
7911827a21
keep bryce starting size unscaled
2016-11-09 11:21:15 -05:00
4b9ed5cee9
Luncher: Fix shadowed declarations.
2016-11-09 09:56:41 -06:00
464eded3a3
handle e_scale correctly in bryces
2016-11-09 10:48:47 -05:00
bc0ccf9ebb
Luncher Gadget: Don't set aspect twice.
2016-11-08 12:18:38 -06:00
c267535bfa
unalias internal wl client pixmaps in elm win hide trap callback
...
this seems to be the best place to remove the alias since it is initially
added in the corresponding show callback
2016-11-08 12:49:24 -05:00
38e4e2b9a9
always free wl pixmap buffer list on non-cache image clear
...
this is only used when the pixmap is freed, after which point accessing
the list guarantees a crash
2016-11-08 12:49:23 -05:00
6f5feb99b2
remove wl client pixmap aliasing on del
...
not sure why I added this but it was wrong
2016-11-08 12:49:23 -05:00
886d29d5d5
unset wl client surface pointer on surface destroy
...
leaving this around after this point is dangerous and has a high probability
of crashing
2016-11-08 12:49:23 -05:00
1c4b11ef9f
reset initial internal wl client states when hiding (but not deleting)
...
ensure that these windows are not able to be shown again until commits occur
2016-11-08 12:49:23 -05:00
51772d1596
Luncher/Pager gadgets: Make sure to lock/unlock the gadget site on dnd.
2016-11-08 11:20:07 -06:00
77a0316be9
Luncher: Make sure that there is a valid drop before object on dnd.
2016-11-08 10:55:57 -06:00
1cbba1232c
Gadcon Pager: Don't show popup if no gadcon pagers exist.
2016-11-08 10:48:15 -06:00
8540e6b99b
Pager Gadget: Use the current zone for popups.
2016-11-08 10:04:48 -06:00
7ef2098f2a
add docs for e_place_desk_region_smart() calc code
...
hhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhh
2016-11-07 13:06:50 -05:00
22add39474
break out repeated code from _e_place_desk_region_smart_area_calc() into separate function
...
no functional changes
2016-11-07 12:52:32 -05:00
65b6906614
break out e_place_desk_region_smart() area calcs into separate function
...
no functional changes
2016-11-07 12:40:51 -05:00
8df16724f7
clamp e_place calcs to zone geometry
...
fixes some cases where windows would place wrong due to placement code
checking offscreen coords
2016-11-07 12:27:34 -05:00
5930643de5
use only zone coords when moving bryce to its zone during editing
...
prevent coords from accidentally resulting in offscreen placement
fix T4826
2016-11-07 11:48:51 -05:00
a08654f773
force bryce repositioning onto target zone during startup
...
ensure that subsequent operations do not accidentally the bryce's zone
fix T4784
2016-11-07 11:38:34 -05:00
49d9cea5aa
center menu-triggered volume popup on same zone as client
2016-11-07 11:26:46 -05:00
ec326b304b
Luncher/Pager Gadgets: Fix coverity warnings for CID 1365330, CID 1365332 and CID 1365405
...
This commit also fixes T4831
2016-11-07 09:35:34 -06:00
be154b60c8
mixer: close the file descriptor on error.
...
CID: 1365407
2016-11-07 10:32:04 +01:00
568a676073
mixer: Don't sync volume sink with e_client if they have more than one.
...
If we got more than one volume sink in e_client and we change the volume
of one of them all sink of this e_client are updated to the same volume.
So don't update e_client volume if we got more than 1 sink.
T4821
2016-11-07 10:26:56 +01:00
ec12cff9f4
mixer: fix a typo spotted by coverity
...
CID: 1365340
2016-11-07 10:19:28 +01:00
b0fd89ac04
Pager Gadget: Use the correct value for the popup checkbox when config window is opened.
2016-11-05 12:00:30 -05:00
6b1726dc4a
Luncher: Use more accurate buffer sizes.
2016-11-05 10:53:56 -05:00
d26900b72d
Luncher: Send the off signal with orientation detail so themers can theme icons based on orientation.
...
You will need to make sure you update efl with this change as well.
2016-11-05 10:27:41 -05:00
b5205a0ca3
Stop passing dimensions to _e_comp_wl_surface_state_init
...
The dimensions we passed were frequently wrong anyway, so let's stop
doing that.
2016-11-04 16:25:58 -05:00
a9d710ab27
Fix wayland opaque regions
...
Similar set of changes to the recent input region changes. They may not
have been quite so broken to begin with, but it's probably less confusing
to treat both types of region the same way.
2016-11-04 16:25:58 -05:00
404a23f7d3
Fix massive wayland input region brokenness
...
It was impossible to set an empty input region.
Input regions were being clipped to the size of whatever buffer was
previously attached when they should really be clipped at commit
time to whatever buffer was attached in the commit.
The intersection operation created round off errors and
e_comp_object_input_area_set is clipping anyway, so we can simplify this
and retain precision.
2016-11-04 16:25:58 -05:00
e74f2a45af
Increase area of tilers for regions
...
We don't have any idea at this point what the region will be used for,
and tilers clip to their area on ingress. If we're going to use tilers
for wayland regions we need to make them huge and clip them later.
2016-11-04 16:25:58 -05:00
1d202c513d
Luncher: Remove useless if statements and make sure to delete an order when instance is deleted.
2016-11-04 10:22:34 -05:00
6c28cf2e51
Luncher: Use E_FREE_FUNC to del variables that are checked for null.
2016-11-04 10:07:13 -05:00
353ad6be11
move bryces to E_LAYER_DESKTOP_TOP when not above windows
...
moderately sure this won't conflict with anything important...
fix T4819
2016-11-03 12:54:53 -04:00
03ad3620c7
add special case for returning pixmap argb of unusable wl cursor pixmaps
...
this is usually called before the surface commits, so ensure that the
most likely case is returned as the default until the commit occurs
fixes black rect flickerings around the cursor
2016-11-03 12:28:24 -04:00
13f408f1e1
add more parens for previous pixmap commit
2016-11-03 12:28:06 -04:00
669f00e2e2
avoid crash when calling e_pixmap_image_exists on wl pixmaps without buffers
2016-11-03 12:24:25 -04:00
e3590f6c3e
determine wl pixmap argb solely based on image_argb flag
...
the existence of a buffer does not mean that the pixmap can stop being
argb
fixes random black rects
2016-11-03 12:07:46 -04:00
33740ca306
return correct values from bryce post event callbacks
...
I referenced elm scrollable for this when writing it. past me was a moron
for using reference code instead of reading the underlying implementation.
fixes scrolling
2016-11-03 11:45:35 -04:00
99e89b708f
cleanup unused variables and parameters for pager module
...
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2016-11-03 11:27:28 -04:00
Carsten Haitzler
d2104b23af
cpufreq - move cpuinfo polling into thread to not block mainloop ever
...
on some devices asking the cpu for info like current frequency,
governors etc. seems to be expensive and if done in the mainloop can
block for multiple ms causing framerate hiccups, so move it to a
thread...
2016-11-03 10:21:22 +09:00
9c26487b37
Fix out of tree builds
...
I broke out of tree builds when I landed the wayland protocol autogen
patches. This should fix it up.
2016-11-02 16:16:49 -05:00
46cad09e3e
force gadget site recalc from style object if gadget's hints change
...
ensure that these intermediate objects trigger recalcs as expected
fix T4809
2016-11-02 11:31:59 -04:00
602b01b8b2
use only aspect hints for new pager gadget
...
ref T4809
2016-11-02 11:31:59 -04:00
df0c4cf658
Pager Gadget: Respect HOLD flag as well as modifiers on mouse events.
2016-11-02 10:22:50 -05:00
ef8d86d7f3
Luncher/Pager Gadget: Fix coverity issues.
2016-11-02 09:36:03 -05:00
2a0b4dfbc4
mixer: fix coverity issues
2016-11-02 15:27:38 +01:00
6723756d6b
feed mouse-up when dropping a gadget site before enabling events on the site
...
prevents unintentional activation of gadget actions during moves
2016-11-02 10:20:04 -04:00
4e08ad17e8
add bool return for e_exec_phony_del() to return deletion success
...
CID 1181927
2016-11-02 10:11:02 -04:00
bfe02d2303
efm - fix popup if file is a fifo
...
this fixes T4815
@fix
2016-11-02 11:00:40 +09:00
4d32ec9e4e
Luncher: Use the desktop for client population if exists.
2016-11-01 19:33:37 -05:00
9d33d6c15b
Pager Gadget: Only empty/fill pager if zone has changed.
2016-11-01 16:56:26 -05:00
96f328b7ff
Pager: Fix gadget zone.
2016-11-01 16:31:41 -05:00
e9b270f993
Time Gadget: Change the calendar month on mouse wheel.
2016-11-01 16:13:14 -05:00
c3b5c4a1bf
Luncher and Pager gadgets: Handle multi head and use the correct zone.
...
This fixes T4807 and T4787
2016-11-01 15:16:06 -05:00
665c7072d7
Luncher: Improve client/exec count.
2016-11-01 14:21:23 -05:00
722ef64426
Merge branch 'master' of git+ssh://git.enlightenment.org/core/enlightenment
2016-11-01 13:28:33 -05:00
73047583f6
Luncher: Improve client tracking.
2016-11-01 13:28:21 -05:00
4d86c98ce7
do not return early from _bryce_position()
...
this causes the returned coords to be garbage values, likely leading to
the bryce being positioned or animating off to the upper-right corner
of the universe that exists beyond the canvas
2016-11-01 13:56:08 -04:00
6e39997ad1
add smart callback for when gadgets get reparented
...
this can be useful for gadgets which (inexplicably) need to set min size hints
2016-11-01 13:29:45 -04:00
debd88b91c
do not create new luncher cfg id for demo gadgets
...
-1 indicates a temporary gadget which should not be saved
2016-11-01 13:01:51 -04:00
ffef2d0770
update luncher aspect hints whenever icon list is modified
2016-11-01 13:01:33 -04:00
814ee0dc84
use only aspect sizing in luncher
...
using min size hints will break gadget scaling
fix T4809
2016-11-01 12:56:51 -04:00
cea551578c
do not apply efx anchoring to move effects if a resize effect is not active
...
this is useless without an animator
fix T4810
2016-11-01 11:12:26 -04:00
193771d58c
Luncher: Don't send mouse events when modifiers are set.
2016-11-01 10:03:35 -05:00
fd22bb34c2
Luncher: Respect events when on hold.
2016-10-31 15:12:49 -05:00
df48b2dc09
Luncher: Preview popup should have a shorter delay.
...
This fixes T4790
2016-10-31 14:59:31 -05:00
d6c6961ab4
check if a client is internal or not before deleting
...
This fixes a crash where mousing back into internal windows would
cause a crash (from efl wayland mouse pointers).
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2016-10-31 14:22:03 -04:00
2970f4d76f
Revert "don't crash is surface resource has no e_client"
...
This reverts commit fbb17af2d6
2016-10-31 13:57:52 -04:00
692b394617
do not apply pager rotation when placed on desktop
...
fix T4786
2016-10-31 13:40:13 -04:00
c3a01ba16c
attempt to recalc gadgets which overflow their container
2016-10-31 13:07:21 -04:00
3d1334e883
delete current dragging gadget during edit if escape is pressed
2016-10-31 13:07:03 -04:00
b0831d5f0d
allow scaling gadgets using wheel events during initial placement
2016-10-31 13:06:18 -04:00
1f9801f922
attempt to handle non-orient gadget resizes based on anchor corners
2016-10-31 13:05:44 -04:00
b9d59616e9
track desktop gadgets based on their zones
...
ensure positioning is accurate with multiple displays
2016-10-31 12:34:29 -04:00
35df03a596
center desktop gadget editor popups upon the zone they have activated
2016-10-31 12:34:29 -04:00
5d2028a300
do not modify bryce zone/name during startup
...
this breaks bryce init by moving all bryces to zone 0
fix T4784
2016-10-31 12:34:29 -04:00
349fc5e910
avoid potential divide by zero during bryce startup
2016-10-31 12:34:29 -04:00
bf1075ff4b
clamp bryce position to its parent zone
...
fixes case where large bryces could overflow their zones
ref T4784
2016-10-31 12:34:29 -04:00
fbb17af2d6
don't crash is surface resource has no e_client
...
wl_resource_get_user_data(surface_resource) could return NULL if the
surface resource has no user data set. This happens with Ecore_Wl2
Windows which are set to type 'None', so add check for valid e_client.
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2016-10-31 09:25:51 -04:00
c9e69e5176
e_client_colume: remove unused variables and add EINA_UNSED where needed
2016-10-31 11:37:47 +01:00
cb51487c3d
e_comp_object: remove unused variable
2016-10-31 11:37:16 +01:00
455935466f
e_fm: remove unused variable
2016-10-31 11:36:53 +01:00
b13486599e
mixer: remove unused variables
2016-10-31 11:34:31 +01:00
f606935067
mixer: mark unused function parameter as such
2016-10-31 11:34:02 +01:00
ea680a33ba
luncher: mark unused function parameters as such
2016-10-31 11:31:58 +01:00
e464e25211
luncher: fix shadowed local variable
...
Make sure the local variable names not actually shadow each other.
2016-10-31 11:30:57 +01:00
7bb858d2a3
e_fm: fix last commit to compile again with clang
...
Commit fd8d41a2a6
2016-10-31 11:03:44 +01:00
Carsten Haitzler
fd8d41a2a6
e fm - fix popup to not crash by referring to possibly deleted data
...
fm icon info is transient because fm icons are transient. files may
get deleted, added or removed on the fly. keeping icon info around for
things like the popup is asking for tyrouble and does create trouble.
so look it up each time based on filename string. safe!
this fixes T4716 and fixes T4798 (they are the same bug basically).
2016-10-31 18:23:08 +09:00
f8ddfd3245
fix use after free when renaming a bryce
...
fix T4784
2016-10-29 11:36:48 -04:00
6ab8c48892
use eina_streq for string comparison in e_zone_for_id_get()
...
zone->randr2_id is not guaranteed to be non-null
crash--
2016-10-29 11:00:49 -04:00
e82ec31175
Luncher: Introduce Enlightenment's new launcher/taskbar/iconify manager: Luncher
...
You are required to update efl along with this update to have the luncher theme files.
2016-10-28 13:26:28 -05:00
41b861214a
block remembers of e_sys windows
...
fix T2879
2016-10-28 10:45:22 -04:00
420b54a151
optimize out re-applying of borderless client theme
2016-10-28 10:36:21 -04:00
c6b091980a
allow client frame changes when switching from frame -> no frame
...
fix T4358
2016-10-28 10:19:01 -04:00
c56cebe945
bump modapi
2016-10-28 10:19:00 -04:00
8724313b8e
mixer: do not set back the value from emix once the drag is finished
...
emix can still have wrong values from pa, and thus the value will jump
back and later come back to the right pos:
Here a video of what is happening:
http://omicron.homeip.net/filedump/mixer_gadget_bug.ogv
Thank you morluxus!
2016-10-28 11:41:00 +02:00
b2d67bd68a
Revert "mixer: lock up the slider for the case a drag is in progress"
...
This reverts commit eed35d3c4f
2016-10-27 22:38:46 +02:00
b65cb5df92
mixer: add volume control to e_client menu
...
Add a button to the window menu, when clicked this one make a new window to
control the volume of the app.
@features
2016-10-27 22:34:17 +02:00
718ef898d7
e_client: add a volume control to the window theme
...
This commit brings 2 objects to the group "e/widgets/border/default/border", an
icon and a slider. If you click the icon the volume is muted.
The slider set the volume level.
Theme part added "e.swallow.volume_icon" and "e.swallow.volume"
@features
2016-10-27 22:34:13 +02:00
6e8070d226
e_remember: add e_client sound volume support
...
@features
2016-10-27 21:54:40 +02:00
307f0831ce
mixer: use the new e_client api to export volume control by app.
...
We use the pulseaudio backend to export volume control by app.
This commit introduce 3 news shortcuts to control the volume with the current
focused window.
@features
2016-10-27 21:54:40 +02:00
06ea6cadbd
E_Client: add an abstraction api to control volume by app
...
This api give the possibility to add sink to an E_Client and control the volume
or the mute state of the sinks associated with this E_Client.
@features
2016-10-27 21:54:39 +02:00
1943cee080
mixer: fix the volume conversion calc into pulseaudio backend
...
a get and a set don't give the same result
@fix
2016-10-27 21:54:39 +02:00
f434891137
redo session recovery handling to use separate E_Remember
...
I tried to be too clever with the initial implementation of this and it was
a lot more complex and nonfunctional than expected
2016-10-27 11:22:27 -04:00
653e671bf5
Revert "prevent editing of session recovery remembers"
...
This reverts commit 890008cdf2
2016-10-27 10:35:01 -04:00
6b7631d204
Revert "update secondary remembers when a session recovery remember is updated"
...
This reverts commit 10eb06b377
2016-10-27 10:34:27 -04:00
b640872edf
Revert "only find the session recovery remember if ec->remember is not it"
...
This reverts commit 8e61889336
2016-10-27 10:34:14 -04:00
98bc594299
Revert "correctly handle applying of non-SR remember in remember config"
...
This reverts commit 62068912e9
2016-10-27 10:34:05 -04:00
a9d0a27ea3
add generic handler for desktop gadget layers
...
...and a menu item for triggering basic editing
2016-10-26 13:59:29 -04:00
6c16988adc
calc new gadget size based on ratio of size:target site size
...
no use case for this yet...
2016-10-26 13:58:15 -04:00
edee519304
copy gadget position from pointer gadget -> drop gadget when executing drop
...
fixes desync which would cause gadgets to move offscreen
2016-10-26 13:57:07 -04:00
0b40aade50
force gadget site recalc on gadget object creation to ensure sizing
...
fixes initial sizing for no-orient gadget sites
2016-10-26 13:55:45 -04:00
ef2cb47daf
handle no-orient gadget visibility based on site->events visibility
2016-10-26 13:54:25 -04:00
87515abd2a
force recalc on bryce scroller when doing recalc on gadget site
...
should have no functional change
2016-10-26 11:33:12 -04:00
3e6f2f1fa7
add workarounds for ctxpopup geometry for use in input shape tiling
...
ref T4687
2016-10-26 10:28:30 -04:00
2af066c97a
Remove EVAS_CALLBACK_HIDE on shelf when freeing
...
Prevents a use after free when an evas callback fires later.
2016-10-25 14:12:15 -05:00
30e9f45dfc
Block session recovery for internal windows
2016-10-25 14:12:15 -05:00
4251e12462
bump modapi
2016-10-25 12:02:15 -04:00
ef33638c42
create substruct for E_Comp to put canvas objects into
...
allow adding/removing objects in the future without breaking abi
2016-10-25 12:01:17 -04:00
989675f310
force min size on wireless popup during show
...
box+list inside a ctxpopup may result in an unreliable min size at the time
of show, so force the size wanted at this time in order to avoid positioning
errors
2016-10-25 11:30:23 -04:00
2c096f685c
Revert "reset elementary softcursor config on shutdown"
...
This reverts commit bdd290591c
2016-10-25 11:06:07 -04:00
d4b9ad591e
Revert "disable elementary softcursor mode for wayland compositing"
...
This reverts commit f7592166eb
2016-10-25 11:06:07 -04:00
ec37884a31
add dbus message 'org.enlightenment.wm.Window.SendToDesktop'
...
Signed-off-by: Mike Blumenkrantz <zmike@osg.samsung.com>
2016-10-25 10:45:59 -04:00
bdd290591c
reset elementary softcursor config on shutdown
...
This is needed because if we shutdown E then try to run EFL apps in
Weston, the Elm Softcursor mode would have been saved as 'off' so we
should be sure to reset this.
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2016-10-25 07:44:41 -04:00
f7592166eb
disable elementary softcursor mode for wayland compositing
...
This commit disables elementary softcursor mode when running as a
wayland compositor. This stops any EFL Wayland Client apps from
creating their own mouse pointer and thus we do not have 2 mouse
pointers on EFL apps anymore.
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2016-10-24 13:52:09 -04:00
21422fd256
trigger zone geometry events when updating zone/desk obstacles
2016-10-21 10:02:24 -04:00
3e186b1509
reject successive zone_geometry_dirty() calls
...
no point in thrashing the compositor if events are already pending
2016-10-21 10:01:50 -04:00
62068912e9
correctly handle applying of non-SR remember in remember config
...
fix T4512
2016-10-20 12:15:03 -04:00
e365848406
apply non-session recovery remember to client when creating recovery remember
...
ensure that the attributes get applied before engaging SR mode
ref T4512
2016-10-20 12:14:16 -04:00
8e61889336
only find the session recovery remember if ec->remember is not it
...
ref T4512
2016-10-20 12:13:22 -04:00
41f5a3e1fd
loop bryce autosize recalc when gadget site has not yet calculated its size
...
fixes moving of autosizing bryces
2016-10-20 12:12:27 -04:00
fb94f1e069
rename bryces when changing anchors
2016-10-20 12:11:39 -04:00
8bf7999c31
add gadget site sizing workaround to avoid elm box sizing desync
...
ref T4747
fix T4732
2016-10-19 11:38:34 -04:00
2c4316633b
avoid extra recalc when resizing a bryce on its oriented axis
2016-10-19 11:38:04 -04:00
e690d70512
set ON_HOLD flag more accurately when activating gadget actions
...
fixes handling of actions which have same binding as gadget site's container bindings
2016-10-19 11:13:32 -04:00
39d561c8b4
fix bryce upgrade path from 0 -> 2 re:naming
2016-10-18 10:59:04 -04:00
7a06a6b661
trigger bryce menus from right click if event has not been consumed
2016-10-17 12:44:32 -04:00
b9afecde41
remove unused attribute from used param
2016-10-17 12:44:08 -04:00
491b18b920
set ON_HOLD flag when triggering gadget mouse buttion actions
...
allow detection that this event is being consumed
2016-10-17 12:42:28 -04:00
79b24ea884
handle gadget_popup smart callback on gadget's display object
...
fixes case where this signal was not accurately propagated
ref T4732
2016-10-17 11:57:05 -04:00
d5847e8ca6
call gadget_popup smart callback when configuring gadgets
...
ensure visibility changes are received by containers
ref T4732
2016-10-17 11:56:32 -04:00
d0e21c912a
add gadget_site_(un)locked smart callbacks for forcing gadget site visibility
...
useful for cases where the gadget site has no popups to manage but visibility must
be maintained
ref T4732
2016-10-17 11:55:23 -04:00
ae628b214b
force bryce visibility during editor activity
...
ref T4732
2016-10-17 11:25:43 -04:00
7dc0930c8a
add new flag for zone edge objects to allow shape cutting while repeating events
...
fixes case where edge binding would (possibly) trigger but then not allow input
to any canvas objects at the screen edge
2016-10-17 11:18:46 -04:00
dece6a5514
also do full bryce rename when moving between zones
2016-10-14 08:10:43 -04:00
b86efbe301
further improve bryce portability across zones
...
also fix typo from yesterday which broke everything and was definitely not
noticed by anyone
2016-10-14 08:03:43 -04:00
ebefa49e4b
do not check for shelf/bryce existence in opposing anchorages during bryce wizard
...
fixes false positives when detecting positions
2016-10-13 11:27:43 -04:00
afa358fa9e
add zone number to bryce names
...
fixes usage of bryces in identical setups on different zones
2016-10-13 11:27:40 -04:00
d5ada5c1d5
fix bryce check for shelf existence on orientation/anchor to break when expected
...
restores missing anchor points when adding/moving bryces
2016-10-13 11:27:40 -04:00
baa7e85e61
add EINTERN function for renaming gadget sites
2016-10-13 11:27:12 -04:00
a9bab812ec
enforce bryce resizing when orientation changes
...
screens are not square, so this would never have worked
2016-10-13 11:20:21 -04:00
838dde02ee
mixer: we changed that name when we merged the mixer in
2016-10-11 14:16:53 +02:00
f0ef2198c5
wizard: make page 065 translatable
...
we should use here the translation for plural or singular, everything
else makes it hard to translate
This commit also adds the file to POTFILES so it gets recognized by the
pot file
2016-10-11 14:16:52 +02:00
ad3d0bd8c5
split wl_desktop_shell into separate files per shell
...
this should make it easier to selectively disable shells, and it will
definitely simplify future shell additions
2016-10-10 11:30:52 -04:00
abb97ca0fb
force zone useful geometry recalc on desk flip if prev/next desk has obstacles
...
ensure that this gets calculated accurately any time it's applicable
2016-10-04 09:22:05 -04:00
0354f8a5b1
remove unused variable
...
ref b83cfb858c
2016-10-04 09:22:05 -04:00
e20b439020
handle "unmaximize" smart callback differently depending on fullscreen state
...
this is a bit hacky, but it seems to provide accurate results to fix more maximize bugs
ref c29157189f
2016-10-04 09:22:05 -04:00
Carsten Haitzler
1afddc3b5e
explicitly use eina list types passing into EINA_LIST_FREE()
2016-10-03 11:55:55 +09:00
2642e8c95a
clamp gadget util ctxpopups to E_LAYER_POPUP at the lowest
...
avoid having these be obscured by windows when the gadget is on a lower layer
2016-10-02 09:35:40 -04:00
7cbca19705
print object type in shape debug if name does not exist
2016-10-02 09:34:48 -04:00
b47b3cd75f
force shape queue when gadget util ctxpopups change visibility
...
fixes some input region issues in x11
2016-09-30 12:59:10 -04:00
9d63a1db3e
do not show wireless gadget popups if desklock is active
...
this gadget may be allowed on lockscreen, but configuration should be disabled
2016-09-28 10:43:00 -04:00
ab56bc4662
remove (wrong) setting of layer for time's clock gadget popup
...
e_gadget_util_ctxpopup_place() already handles this correctly
2016-09-28 10:41:21 -04:00
b83cfb858c
remove x11 input window from desklock grab process
...
now the compositor canvas is grabbed, simplifying handling of grabs which
persist through the desklock activation
2016-09-28 10:40:38 -04:00
90fcc55f1e
add e_util_open(), unify all callers of enlightenment_open
...
ref adbba1042b
2016-09-27 11:19:00 -04:00
bb53d4606f
do not consume key events in comp autoclose key callback if desklock is active
...
fix T4655
2016-09-27 10:59:52 -04:00
e4da5ba56a
Auto generate wayland protocol
...
Replaces any checked-in wayland protocol files with auto-generation.
In some cases this means renaming include files that didn't use "standard"
names, or adding missing xml files. Any source edits are simple search and
replace, there should be no functional changes.
2016-09-26 15:23:50 -05:00
b7d37e9d51
Add the capability to auto-generate protocol code and headers
...
We'd like to drop all the generated files and keep just the xml files.
This is a step in that direction but we've been naming things irregularly
and some of our checked in generated code doesn't have an associated xml
yet, so this'll be a bit of a process.
2016-09-26 15:23:50 -05:00
Carsten Haitzler
adbba1042b
e exec - fix exec of enlightenment_open to use actual e prefix
...
so this code path was using the COMPILED IN prefix like broken
old-school unix apps that cannopt be relocated. efl and e have runtime
prefix detection so use it properly. stop doing things the broken way
just because people have written broken code for 30+ years and
continue to. we don't do that in e/efl land.
@fix
2016-09-25 23:53:08 +09:00
5b2f952c85
Introduce pager gadget using new gadget api.
2016-09-23 10:17:54 -04:00
22a99c5b5a
NULL out xwayland fd handlers after deleting them
...
This fixes a valgrind error that can happen when we accidentally
free these again later because they still had non-NULL values.
2016-09-21 16:45:57 -05:00
494f76b0ab
Don't kill self during shutdown
...
When Xwayland is running we end up with a client with the same pid
as the compositor in the client list. We need to avoid killing that
client, as it will interrupt the proper shutdown procedure.
fix T4439
2016-09-21 16:45:57 -05:00
ff0b513daa
Revert "protect against non-nul terminated string from mmap in filepreview"
...
This reverts commit 5861d9bef9ae23533b0d
2016-09-21 09:34:31 -07:00
Carsten Haitzler
5861d9bef9
protect against non-nul terminated string from mmap in filepreview
...
this should address 2nd gdb bt and fix T4543
@fix
2016-09-21 20:19:01 +09:00
0074c1ca27
remove extraneous recalc trigger when deleting a gadget
...
CID 1362898
2016-09-21 07:12:49 -04:00
509443af55
do not update bryce layer when restacking to a higher layer than CLIENT_ABOVE
2016-09-20 12:46:48 -04:00
f700a57baf
clean up gadget drop handlers correctly
...
use drop_handler_del when deleting gadget drop handlers, also delete spacer rects
2016-09-20 12:46:46 -04:00
17909e4fb5
always delete gadget's display object and ensure gadget object is null
...
fixes some object errors during container deletion
2016-09-20 11:20:22 -04:00
ae23533b0d
fix text preview to use eina_strbuf_append_length that doesn't call strlen and crash.
2016-09-19 14:50:57 -07:00
a85d142b93
force bgpreview widget to resize after a wallpaper update
...
ref be1b11ca28
2016-09-19 16:18:48 -04:00
09cf90b05a
add gadget doc note for gadget_destroyed callback re:object lifetimes
2016-09-19 16:18:47 -04:00
d1953c2205
always use largest available size for free-oriented gadgets
...
ensure that gadgets don't unexpectedly clamp to minimum size
2016-09-19 15:50:55 -04:00
9439228816
add backspace/delete for clearing all lockscreen gadgets
...
this was turning into a total wasteland
2016-09-19 15:18:06 -04:00
682dd5f835
check visibility of gadget site 'events' member to determine drop availability
...
the layout object of a gadget site does not need to be visible since it may be
used for desktop gadgets or a transparent overlay
2016-09-19 15:04:47 -04:00
b5701bdb1b
adjust gadget drop coords for pointer offset
...
gadgets are centered on the pointer when moved, so the drop coord needs to
then be uncentered to avoid unintended movement
2016-09-19 14:55:53 -04:00
d4450d8eb6
attempt to retain gadget size when executing move operations
2016-09-19 14:55:28 -04:00
8923415f8b
force smart calc on gadget sites at key points during move operations
...
ensure that gadget info and visuals match up
2016-09-19 14:54:35 -04:00
4dd99ed669
add separate codepath for handling layout of moving gadgets
...
these get sized and positioned in a passthrough manner, so avoid doing any calc
2016-09-19 14:53:20 -04:00
42056009a5
set gadget added flag any time a gadget is created or wizarded
...
ensure that desktop gadget editor doesn't exit when attempting to add
subsequent gadgets
2016-09-19 14:32:20 -04:00
6ee205ec57
use same layer in bryce editor for "above window" setting
2016-09-19 09:56:38 -04:00
9313121e79
clamp bryces to a lower canvas layer
...
note to self: if you remember why you had these at POPUP, annotate the reason
here...
2016-09-19 09:54:21 -04:00
f456215828
always use compositor object stacking when performing internal drags
...
attempting to use a client window for any internal drag operation will always
yield wrong results and broken behavior
ref 1a982fd72a
2016-09-16 18:05:07 -04:00
eea3bdfacf
handle e_comp deref during e_dnd shutdown to avoid crash
2016-09-15 15:10:42 -04:00
ca7bc28286
set the spacer rect as the drop handler base when creating gadget drop handlers
...
this provides layering info to dnd internals
2016-09-15 14:48:28 -04:00
2d9ee4233e
use comp canvas win by default for any drop handler with an E_Object
...
this is always going to be the case anyway
2016-09-15 14:48:28 -04:00
Chris Michael
Stephen 'Okra' Houston
Mike Blumenkrantz
Derek Foreman
Michaël Bouchaud (yoz)
Al Poole
Carsten Haitzler
Marcel Hollerbach
Derek Foreman
Romain Naour
Cedric Bail
Andy Williams
Stefan Schmidt
Joshua McBeth
Stephen Houston