Mike Blumenkrantz
fcc996545c
always end drag operations on failure
...
fix T3507
2016-04-25 12:24:44 -04:00
Mike Blumenkrantz
42d67d51c3
do not perform input ungrab twice during dnd end in wayland
...
this was happening in both drag free and drag end: once is sufficient
2016-04-21 13:55:23 -04:00
Mike Blumenkrantz
194b1ab336
disable binding activation when grab dialog, menus, or dnd is active
...
these are all cases where bindings should fail to activate in order to
avoid interfering with current operations
also fixes an issue where attempting to add or modify an existing
mouse/key/wheel binding would fail as a result of that binding activating
while the grab dialog was active
2016-01-22 12:58:16 -05:00
Mike Blumenkrantz
21ee21bc1f
end wl xdnd drags on the compositor canvas using the full dnd end codepath
...
fix T2652
2015-08-19 14:35:04 -04:00
Mike Blumenkrantz
3f13b6889d
replace existing usage of x/wl_comp_data with corresponding globals
2015-08-13 16:05:57 -04:00
Chris Michael
e31441bb48
enlightenment: Replace old comp_type conditionals
...
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2015-08-13 10:33:48 -04:00
Mike Blumenkrantz
442d63d8d6
track button mask for all drags, only end drag when mask has depopulated
...
previously, beginning a drag with the left button, then pressing and
releasing another button would result in the drag terminating without
the original button being released
2015-08-12 15:39:42 -04:00
Mike Blumenkrantz
8e211f1950
implement wl->x11 dnd operations
...
seems to work fine, large selection data (ref T2330) still untested
2015-08-07 21:07:34 -04:00
Mike Blumenkrantz
5bde1a8648
implement x11->wayland dnd operations
...
still a little rough, but the basics are functional. works by showing
the x11 compositor selection window, which has rects to exclude geometries
of xwl clients, for getting x11 xdnd events, and then manually sending
all the related client messages in order to inform the x11 client that
enlightenment is, in fact, an extremely credible xdnd drop site and not
a rogue compositor which will mangle/destroy the dnd data.
still render crashes after the operation completes, so possibly not the
most useful thing to be using now
2015-08-06 19:31:20 -04:00
Mike Blumenkrantz
8557da360c
make dummy e_drag rect invisible
2015-08-06 19:31:20 -04:00
Mike Blumenkrantz
b7cc0e07b8
enable x11 dnd in wayland compositors
...
maximize footgun potential since this currently crashes immediately
2015-08-05 16:07:10 -04:00
Mike Blumenkrantz
6a50d5f581
fix compositor type detection for dnd operations
...
wayland compositors will always use a compositor grab
2015-08-04 19:39:09 -04:00
Mike Blumenkrantz
b33d8bdf10
allow new drags to be created with no associated mime types
2015-08-04 19:39:09 -04:00
Mike Blumenkrantz
b011c4a045
reduce explicit ecore-x type usage in e_dnd
2015-08-04 19:39:09 -04:00
Mike Blumenkrantz
fa11e0ecd7
further unify drag start functions
2015-08-04 19:39:09 -04:00
Mike Blumenkrantz
9669dc1dc5
show drag object immediately when beginning a drag
...
fixes flicker at start of drag
2015-08-04 19:39:09 -04:00
Mike Blumenkrantz
5526bd357a
unify most of drag start functions
2015-07-31 15:35:55 -04:00
Chris Michael
33414c0a0d
enlightenment: Remove static function prototype for unused function
...
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2015-07-24 13:16:04 -04:00
Chris Michael
f25f074be5
enlightenment: Remove listener for XDnD status
...
As we don't do anything within this handler, having it is just
pointless. Remove it. Fixes Coverity CID1267214
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2015-07-24 13:09:36 -04:00
Mike Blumenkrantz
32c48f9a40
...and also ungrab the compositor when internal drags end
2015-07-16 12:59:04 -04:00
Mike Blumenkrantz
2e5ab5a947
only use input xwindows for internal drags in x11 compositor
...
this fixes input region detection for dnd operations
fix T1831
2015-07-16 12:52:00 -04:00
Mike Blumenkrantz
c128d54690
disable size debug on drags
2015-07-11 08:37:56 -04:00
Mike Blumenkrantz
311f524094
only register dnd xwindow with compositor canvas in x11 compositor mode
...
registering it under wayland creates spurious mouse events
2015-07-10 16:03:45 -04:00
Mike Blumenkrantz
4a779ef03d
fix xdnd in (x)wayland
...
this is a real thing, so don't abort immediately if it happens
2015-07-10 16:03:18 -04:00
Chris Michael
0a94e8ba71
enlightenment: Make E build again with EFL from git
...
sed -i 's/EAPI/E_API/g'
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2015-05-07 15:13:10 -04:00
Mike Blumenkrantz
5ae00e6525
redo drop handlers to take an E_Object and Evas_Object
...
temp change to fix crashing when closing fwins with ctrl+w
2015-04-27 15:39:43 -04:00
Mike Blumenkrantz
8ed4ee3b38
remove E_Comp->x/y
...
canvas coords start at 0,0...always
2015-03-19 16:59:59 -04:00
Mike Blumenkrantz
58447e9508
completely remove E_Manager
...
the final step in flattening all the canvas/screen apis
2015-03-19 16:53:32 -04:00
Mike Blumenkrantz
471dcb24cb
__UNUSED__ -> EINA_UNUSED
...
this has been bugging me forever. __UNUSED__ is no longer a valid macro here.
2015-03-18 18:09:09 -04:00
Mike Blumenkrantz
1736d1ecb9
e_client functions no longer require E_Comp param
2015-03-13 16:53:19 -04:00
Mike Blumenkrantz
bacf638d73
remove E_Drag->comp and E_Comp param from e_drag_new()
2015-03-13 16:21:15 -04:00
Mike Blumenkrantz
1fe1c94245
comp canvas functions no longer require an E_Comp param
2015-03-13 16:07:08 -04:00
Mike Blumenkrantz
ba684aacd3
de-e_comp_get()ify e_dnd
2015-01-22 14:59:25 -05:00
Chris Michael
d11c42fd23
Fix Coverity CID1261286. Identical code for different branches
...
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2015-01-12 12:12:52 -05:00
Mike Blumenkrantz
922af2c52f
remove e_comp_list(), deprecate all related functions for pending removal
...
there is only one E_Comp which can now be accessed by the e_comp global.
if you're editing a file with some uses of these deprecated functions, replace their usages with appropriate references to this variable
pass -Wno-deprecated-declarations to ignore these warnings during build
2015-01-05 15:39:15 -05:00
Marcel Hollerbach
a6f7d9ac1e
Register the new window into out evas.
...
Summary:
Otherwise the mouse up event is emitted to the evas but the evas does
not work with it, because it does not know the window it is from. This
leads to a evas_event_down_count_get bigger than 1 which leads to a
missing mouse_out event. With this missing mouse_out event _post_up_handle
in evas_event.c is not called anymore, this means all the click events
are getting emitted to the object which was last clicked.
This fixes T1894.
Test Plan: Drag and Drop a icon somewhere and click somewhere after that, the evas will not get stuck anymore
Reviewers: raster
Subscribers: cedric, abyomi0, zmike, raster
Maniphest Tasks: T1894
Differential Revision: https://phab.enlightenment.org/D1771
2014-12-13 09:17:21 +01:00
Mike Blumenkrantz
99589eb5af
remove E_Win+e_canvas, convert all internal wins to use elm_win
...
known issues:
* keybindings for efm windows (eg. ctrl+w) are broken until the rest of the conversion is completed
2014-11-20 15:26:21 -05:00
Chris Michael
4f59146512
fix compiler warnings when building for wayland-only
...
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-10-03 13:35:34 -04:00
Chris Michael
e8b3be70ab
fix dnd compiler warnings when building for wayland-only
...
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-08-28 12:36:02 -04:00
Mike Blumenkrantz
c04d754ac5
enabling drm output module should NOT require X-less build.
...
these defines all need to be changed from HAVE_WAYLAND_ONLY to something like WITH_X or we're going to have lots of problems with xwayland later on
2014-03-18 16:14:04 -04:00
Chris Michael
915f8f0613
@bugfix: Fix building for WAYLAND_ONLY by using the proper define
...
sed -i 's/WAYLAND_ONLY/HAVE_WAYLAND_ONLY/g'
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-03-18 07:43:04 +00:00
Mike Blumenkrantz
b9cdeb17f5
add note about switch statement fallthrough
...
CID 1040128
2014-03-13 13:09:43 -04:00
Mike Blumenkrantz
d391e5c130
validate params for e_dnd_util_text_uri_list_convert()
...
CID 1040144
2014-03-13 12:52:36 -04:00
Mike Blumenkrantz
450d6cf321
add comments to suppress false positives in intentional switch fallthroughs
...
CIDs 1155283, 1155282, 1155281
2014-03-13 12:20:38 -04:00
Mike Blumenkrantz
6dd98df0d6
remove all remaining efl version check defines
2014-03-13 11:55:29 -04:00
Mike Blumenkrantz
ebeffa1a91
bugfix: hide drag icons after dnd operation ends
...
T797
2014-02-03 11:14:04 -05:00
Mike Blumenkrantz
fdc3d29899
bugfix: remove drop handlers from responsive hash on deletion
2014-01-22 22:14:33 -05:00
Mike Blumenkrantz
3e0cbdc441
bugfix: efm dnd to external windows
...
deleting the drag at this point deletes the window which owns the current selection, guaranteeing that the operation will fail
T797
2014-01-22 22:14:33 -05:00
Mike Blumenkrantz
d86051ff82
bugfix: multiple drop handlers using same window no longer overwrite each other
2014-01-22 22:14:33 -05:00
Mike Blumenkrantz
a658e4c198
add e_drag_current_get
2014-01-15 18:52:57 -05:00