Commit Graph

12490 Commits

Author SHA1 Message Date
Carsten Haitzler 5ab8396f24 ok - strdupa make sure its defined after other includes in case,.. and
add to e_fm_ipc.c...



SVN revision: 81036
2012-12-16 01:17:45 +00:00
Chidambar Zinnoury 22c81bcfa2 e xsettings: state that the theme applies only to GTK apps.
Maybe put icons as first item as it applies to everything?


SVN revision: 81032
2012-12-15 20:20:59 +00:00
Chidambar Zinnoury 23299743a2 e: Unicode makes you look better, gives you luck, brings back lost love,
SVN revision: 81031
2012-12-15 20:19:33 +00:00
Chidambar Zinnoury d2f9a1cc7d e main menu: remove parentheses and disable item when there are no elements.
SVN revision: 81030
2012-12-15 20:07:02 +00:00
Chidambar Zinnoury a82810c3d5 e: Revamp a 'lil bit the remember config dialog.
- Add check changed.
- Have the details section actually show something.
- Show a meaningful “Any” (disabled) when a discriminant is not set.
- Show “No selection” (disabled) when there is none.

 Still bothering: deletions are being done immediately, not upon validation, unlike other settings.


SVN revision: 81029
2012-12-15 20:03:41 +00:00
Boris Faure 114eb6d6ae e:tiling: tiled windows shouldn't get maximised by users
Refs: #1996

SVN revision: 81027
2012-12-15 18:06:39 +00:00
Maxime Villard 5ebf793f1b From: Maxime Villard <rustyBSD@gmx.fr>
Subject: [E-devel] [e] Patch acpi

A little patch to fix a possible warning - and overflow.

'buf' is PATH_MAX, but PATH_MAX is not necessary 1024. If
PATH_MAX < 1024 -> overflow.

Also, fgets() fills the buffer and nullterminate it, so we
don't need to buff[0] = '\0'.



SVN revision: 81024
2012-12-15 14:42:19 +00:00
Maxime Villard 534ae45303 From: Maxime Villard <rustyBSD@gmx.fr>
Subject: Re: [E-devel] [e] [patch] Leak (was FreeBSD patch)

I would also move some {free(x); x = null} to E_FREE.



SVN revision: 81023
2012-12-15 14:29:38 +00:00
Carsten Haitzler d77fca2234 also all the pointer push/pops are going to be bad in that they mess
with the manager pointer... that is bad - at most mess with your own
win pointer.. push and pop that. fix... and use plus pointer for power
led button so it doesnt look like the hand ptr for dragging. :)



SVN revision: 81019
2012-12-15 13:30:13 +00:00
Carsten Haitzler 1f7c977b79 ummm randr.. why do pointer differently for rotate.. when e_poitner
already does it? fix - use e_pointer.



SVN revision: 81018
2012-12-15 13:18:10 +00:00
Carsten Haitzler 8c3c6c57a0 provide debug printfs for cedric.. my init splash comes up fine...
debug loosk good.



SVN revision: 81014
2012-12-15 07:51:16 +00:00
Carsten Haitzler 18b1eb7111 revert that.. its not a double free... its a bizarre-arse macro!
SVN revision: 81012
2012-12-15 07:44:11 +00:00
Carsten Haitzler 320ec625b0 wtf? thats like double-free land.. why strdupa at all? nuts! remove
strdupa's and make code consistent with neighbouring code.



SVN revision: 81006
2012-12-15 01:56:35 +00:00
Mike Blumenkrantz 8a38414ec8 same for mouse wheel bindings...
SVN revision: 80993
2012-12-14 22:36:35 +00:00
Mike Blumenkrantz f03730cee5 apparently people have been adding keybinds to default config and not updating the keybind reset to defaults list
SVN revision: 80992
2012-12-14 22:31:17 +00:00
Mike Blumenkrantz 679cae4fad patch from maxime villard fixing strdupa definition and moving a variable to local scope
SVN revision: 80990
2012-12-14 21:09:21 +00:00
Massimo Maiurana 60a8c29681 typo
SVN revision: 80978
2012-12-14 17:40:12 +00:00
Hannes Janetzek 37150a8715 e17/evry: add some debug info to exebufs path scanning/loading
SVN revision: 80974
2012-12-14 17:10:35 +00:00
Hannes Janetzek a3dab23b61 e17/evry: remove logging stuff from api..
SVN revision: 80973
2012-12-14 17:09:00 +00:00
Mike Blumenkrantz 90659a081c "share" button on screenshot now has a confirm dialog because apparently "share" is too vague and we need users to explicitly waive their privacy rights
ticket #1985


SVN revision: 80959
2012-12-14 16:02:03 +00:00
Hannes Janetzek f920665d49 e17/evry: free window in _evry_window_free
SVN revision: 80952
2012-12-14 14:28:16 +00:00
Hannes Janetzek 5b4c85d75b evry valgrinding: dont leak initial item (when no input was given)
SVN revision: 80947
2012-12-14 14:25:48 +00:00
Hannes Janetzek c6cbc0e22c evry valgrinding: not sure if this is correct solution but evas_smart_class_new:35 leaked in one log
SVN revision: 80945
2012-12-14 14:24:37 +00:00
Mike Blumenkrantz 9d68775725 fix pointer warping on desk change + revert focus
ticket #1994


SVN revision: 80942
2012-12-14 13:47:53 +00:00
Mike Blumenkrantz 381425f538 improper E_FREE usage
SVN revision: 80939
2012-12-14 13:04:32 +00:00
Mike Blumenkrantz acdc863299 fix magic fail when deleting desklock popup: popup already hidden, so don't need to delay delete
SVN revision: 80938
2012-12-14 13:04:16 +00:00
Massimo Maiurana 88d44a9291 other duplicates with different case
SVN revision: 80936
2012-12-14 12:04:57 +00:00
Mike Blumenkrantz e034e33f17 remove unnecessary efm refresh on fwin spring dnd end, fixes crash
ticket #1975


SVN revision: 80934
2012-12-14 11:30:55 +00:00
Mike Blumenkrantz 8b698680df reorder efm dnd finished cb to prevent crash when accessing possibly deleted icon
SVN revision: 80933
2012-12-14 11:29:50 +00:00
Mike Blumenkrantz 1d7d7def2a update widget min size when changing label text
SVN revision: 80932
2012-12-14 11:29:19 +00:00
Mike Blumenkrantz 926ee6f360 pulse_recv() no longer has the most confusing return of any function, also only prevent event list from building, not sinks (we need them!)
SVN revision: 80925
2012-12-14 09:38:59 +00:00
Mike Blumenkrantz 8347b33d9c more leaks gone in trash code that isn't used
SVN revision: 80924
2012-12-14 09:19:50 +00:00
Mike Blumenkrantz 799e6b5a5e it seems that this variable in e_exec does not actually need to be strdup()ed, and thus does not need to leak...
SVN revision: 80923
2012-12-14 09:13:07 +00:00
Mike Blumenkrantz 31b66a272e improper E_FREE usage
SVN revision: 80922
2012-12-14 09:07:57 +00:00
Mike Blumenkrantz 53c7cc643f small leak in config registry item add
SVN revision: 80920
2012-12-14 09:04:23 +00:00
Mike Blumenkrantz 6c68615ca3 better fix for mixer buffer overflow, copy to epulse
SVN revision: 80919
2012-12-14 09:03:34 +00:00
Mike Blumenkrantz cc694477f6 better fix for mixer pointer
SVN revision: 80918
2012-12-14 08:39:15 +00:00
Cedric BAIL dda71fa2ff e: revert r80871.
This commit make E go crazy and use 100% all time. Reading the code,
we do check the returned value, but discard it without looking at it
in many case. A proper review of that piece of code to fix potential
memory leak and avoid reusing dead pointer would be a must.


SVN revision: 80915
2012-12-14 06:59:29 +00:00
Carsten Haitzler 3dc01f3e7a fix filedesc leak in tempget when errs happen - based on info from
maxime, but written differently.



SVN revision: 80914
2012-12-14 05:28:16 +00:00
Carsten Haitzler 819fa7c948 have a theme fallback in preview so it works right.
SVN revision: 80904
2012-12-13 23:33:29 +00:00
Mike Blumenkrantz f4440456f7 actually we can just strdupa here instead
SVN revision: 80899
2012-12-13 21:28:54 +00:00
Mike Blumenkrantz 925645792e grr meant strncpy!
SVN revision: 80898
2012-12-13 21:25:29 +00:00
Boris Faure 4e35962cb1 e:tiling: fix some overflows and add a bunch of asserts
SVN revision: 80892
2012-12-13 20:55:54 +00:00
Mike Blumenkrantz 0d579688ae add object_repack function for frametable
SVN revision: 80890
2012-12-13 20:12:32 +00:00
Mike Blumenkrantz 6ae01a1b09 unbreak e_intl.h #ifdefs
SVN revision: 80889
2012-12-13 19:12:37 +00:00
Mike Blumenkrantz b5011f94bb fix wizard comp cfg leak
SVN revision: 80877
2012-12-13 15:02:20 +00:00
Mike Blumenkrantz d2058ecbad some small leaks in tempget
SVN revision: 80876
2012-12-13 14:59:50 +00:00
Mike Blumenkrantz 8f0efbf740 fix possible crash in shot module
SVN revision: 80875
2012-12-13 14:56:53 +00:00
Mike Blumenkrantz ededae7ee5 notification module no longer crashes when its config is reset
SVN revision: 80874
2012-12-13 14:54:19 +00:00
Mike Blumenkrantz 8c4457aed4 don't leak event infos when no cb is set for pulse events
SVN revision: 80873
2012-12-13 14:51:00 +00:00
Mike Blumenkrantz f243a81f94 another leak on failure
SVN revision: 80872
2012-12-13 14:46:15 +00:00
Mike Blumenkrantz 6f981cc6a5 NULL variable after freeing
SVN revision: 80871
2012-12-13 14:44:55 +00:00
Mike Blumenkrantz 1eb2f32879 buffer overflow in pulse
SVN revision: 80870
2012-12-13 14:44:11 +00:00
Mike Blumenkrantz ca69b505a6 possible buffer overflow, review needed from someone who knows this better
SVN revision: 80869
2012-12-13 14:36:24 +00:00
Mike Blumenkrantz e85807052b no, you don't need to allocate label strings for list
SVN revision: 80868
2012-12-13 14:35:56 +00:00
Mike Blumenkrantz 964c8ec66e fileman_opinfo improper E_FREE and possible leak depending on asprintf implementation
SVN revision: 80867
2012-12-13 14:25:04 +00:00
Mike Blumenkrantz 9220325253 fileman menu leak
SVN revision: 80866
2012-12-13 14:23:41 +00:00
Mike Blumenkrantz 33700ff362 leak in fileman mime edit config
SVN revision: 80865
2012-12-13 14:21:58 +00:00
Mike Blumenkrantz 4449f72f85 another fileman mime config leak
SVN revision: 80864
2012-12-13 14:20:06 +00:00
Mike Blumenkrantz 1f9e621fca formatting
SVN revision: 80860
2012-12-13 14:16:34 +00:00
Mike Blumenkrantz b4d060ab1c fun typo, I'd think gcc would warn against this
SVN revision: 80859
2012-12-13 14:14:44 +00:00
Mike Blumenkrantz f8ed2a752a do calloc after possible return; leak--
SVN revision: 80858
2012-12-13 14:13:39 +00:00
Mike Blumenkrantz a82e3688a1 another evry apps leak
SVN revision: 80857
2012-12-13 14:13:08 +00:00
Mike Blumenkrantz 6e72b63508 more evry apps leaks and wrong E_FREE usage
SVN revision: 80856
2012-12-13 14:09:55 +00:00
Mike Blumenkrantz aa04f119e2 leak in evry apps
SVN revision: 80855
2012-12-13 14:08:03 +00:00
Mike Blumenkrantz 0f091f6dd9 dropshadow leak
SVN revision: 80854
2012-12-13 13:57:37 +00:00
Mike Blumenkrantz a111090fa4 formatting
SVN revision: 80853
2012-12-13 13:52:41 +00:00
Mike Blumenkrantz bd5690e78f small leak in old display dialog
SVN revision: 80852
2012-12-13 13:45:58 +00:00
Mike Blumenkrantz 1e75ff35e1 formatting
SVN revision: 80851
2012-12-13 13:42:50 +00:00
Mike Blumenkrantz 006a014982 gadcon positioning leak
SVN revision: 80850
2012-12-13 13:41:35 +00:00
Mike Blumenkrantz 42f02658c8 more profile config dialog leaks
SVN revision: 80849
2012-12-13 13:38:32 +00:00
Mike Blumenkrantz d2bad66fd5 fix leaks in profile config dialog
SVN revision: 80848
2012-12-13 13:37:04 +00:00
Mike Blumenkrantz 5e04704e3e apps menu no longer leaks in some impossible case
SVN revision: 80847
2012-12-13 13:23:38 +00:00
Mike Blumenkrantz ef6267c7c3 fix some comp leaks when window attributes are not found
SVN revision: 80846
2012-12-13 13:21:43 +00:00
Mike Blumenkrantz fdcdd7a168 void functions don't return values
SVN revision: 80845
2012-12-13 13:19:30 +00:00
Mike Blumenkrantz 0774c6bf65 ensure path length fits in buffer in batget
SVN revision: 80844
2012-12-13 13:18:07 +00:00
Mike Blumenkrantz 41236712d9 use PATH_MAX for path buffers
SVN revision: 80843
2012-12-13 13:16:01 +00:00
Mike Blumenkrantz 44442a8e45 reorder some stuff in static_grab to be more successful
SVN revision: 80842
2012-12-13 13:11:21 +00:00
Mike Blumenkrantz 3d9ac54d21 even more leaks in randr11 refresh rates fail
SVN revision: 80841
2012-12-13 13:01:57 +00:00
Mike Blumenkrantz 4e23dd680e fix leak in randr11 refresh rate failure
SVN revision: 80840
2012-12-13 12:59:43 +00:00
Mike Blumenkrantz 7fb5b16ee4 void functions don't return values
SVN revision: 80839
2012-12-13 12:55:59 +00:00
Mike Blumenkrantz 3111aa6120 another pedantic free for the analyzers
SVN revision: 80838
2012-12-13 12:53:28 +00:00
Mike Blumenkrantz 251ee5a5d6 another pedantic and probably unneeded null check
SVN revision: 80837
2012-12-13 12:52:13 +00:00
Mike Blumenkrantz 3a82001c8b fix leak in client menu generation
SVN revision: 80836
2012-12-13 12:50:58 +00:00
Mike Blumenkrantz 6388913775 another pedantic and probably unneeded null check
SVN revision: 80835
2012-12-13 12:47:34 +00:00
Carsten Haitzler 1a891cf8a3 lets be awesome ... and make the theme preview.. look a lot more like
a REAL PREVIEW OF A THEME!



SVN revision: 80834
2012-12-13 12:27:03 +00:00
Mike Blumenkrantz 6d0a11236f fix possible buffer overflow in module config dialog
SVN revision: 80832
2012-12-13 12:03:41 +00:00
Mike Blumenkrantz 8f1f764359 don't leak on iterate in intl path searching
SVN revision: 80831
2012-12-13 11:58:06 +00:00
Mike Blumenkrantz 1358b91d2b pedantic free() here to shut up analyzers
SVN revision: 80829
2012-12-13 11:56:22 +00:00
Mike Blumenkrantz b51d7c6eda fix leak in import dialog
SVN revision: 80828
2012-12-13 11:55:10 +00:00
Mike Blumenkrantz da5caff466 inlist_count is not O(1)
SVN revision: 80827
2012-12-13 11:52:38 +00:00
Mike Blumenkrantz 9b4ec19471 fix guaranteed crash in efm_op...rustyBSD check this if you happen to read
SVN revision: 80826
2012-12-13 11:49:07 +00:00
Mike Blumenkrantz 4a2837830b another efm_op leak, also wrong E_FREE usage
SVN revision: 80824
2012-12-13 11:34:09 +00:00
Mike Blumenkrantz e0926014a1 fix possible NULL deref in efm_op
SVN revision: 80823
2012-12-13 11:30:40 +00:00
Mike Blumenkrantz c637b2874f fix small leak in efm_op
SVN revision: 80822
2012-12-13 11:27:47 +00:00
Mike Blumenkrantz b48d65af00 fix lots of stupidity in efm daemon trash code that isn't even enabled
SVN revision: 80821
2012-12-13 11:18:26 +00:00
Mike Blumenkrantz 0743fd1ea2 fix efm daemon leak in every command made
SVN revision: 80820
2012-12-13 11:13:17 +00:00
Mike Blumenkrantz b2b336ed7d fix leak in efm daemon when reordering files
SVN revision: 80819
2012-12-13 11:10:01 +00:00
Mike Blumenkrantz 67b24415d6 fix efm leak when symlinking out of an ASK DND action
SVN revision: 80818
2012-12-13 11:07:06 +00:00
Mike Blumenkrantz 52ca7afc9a fix leak in e_exec when DISPLAY is too long
SVN revision: 80817
2012-12-13 11:03:13 +00:00
Mike Blumenkrantz 59aa402a46 fix wrong E_FREE usage
SVN revision: 80816
2012-12-13 11:02:36 +00:00
Mike Blumenkrantz c0910ad0d4 only create config registry item once its category has been found to prevent dangling registry items
SVN revision: 80815
2012-12-13 10:56:59 +00:00
Mike Blumenkrantz f81c0f3d93 fix uninitialized border geom in SMART/EXPAND maximizes
SVN revision: 80814
2012-12-13 10:48:39 +00:00
Mike Blumenkrantz 7877c41869 handle NULL more gracefully in e_bindings_signal_handle
SVN revision: 80813
2012-12-13 10:38:24 +00:00
Mike Blumenkrantz e3c0e6bbcc shut up e_exehist
SVN revision: 80812
2012-12-13 10:37:14 +00:00
Mike Blumenkrantz 4078be3fab fix icon finding for evry mime types
ticket #1988


SVN revision: 80810
2012-12-13 10:34:52 +00:00
Mike Blumenkrantz 9cc54e74c7 formatting
SVN revision: 80804
2012-12-13 09:46:11 +00:00
Carsten Haitzler 47e53b259e provide some help for when pkgers mess up suid bits on freqset.
SVN revision: 80801
2012-12-13 09:02:20 +00:00
Carsten Haitzler dae7d45236 add small detail to error printf on e_sys.
SVN revision: 80799
2012-12-13 08:32:37 +00:00
Mike Blumenkrantz 6999eb8ad1 add new event for when managers regrab keys
SVN revision: 80774
2012-12-12 19:21:31 +00:00
Mike Blumenkrantz 55ae26fcd3 prevent config dialogs from crashing if create/free data functions are not defined
SVN revision: 80772
2012-12-12 16:54:48 +00:00
Mike Blumenkrantz a4cb0df4ea prevent double pager settings menus
SVN revision: 80769
2012-12-12 14:56:59 +00:00
Mike Blumenkrantz 8077e1aafb always unpopulate shelf before changing orientation so systray doesn't ibtch
SVN revision: 80768
2012-12-12 14:56:17 +00:00
Mike Blumenkrantz 86aa333211 disable currently-set orientation for shelf on orientation change menu
SVN revision: 80766
2012-12-12 14:44:10 +00:00
Mike Blumenkrantz dbce2eaed3 show files again when an overwrite dialog pops up
ticket #1974


SVN revision: 80762
2012-12-12 13:50:43 +00:00
Mike Blumenkrantz a8143270cd always re-set xmodmap after changing kbd layout group
SVN revision: 80761
2012-12-12 13:31:18 +00:00
Mike Blumenkrantz 15df42143e add some null checks before monitor deletion to account for people still affected by the frenchman's laziness
SVN revision: 80757
2012-12-12 12:34:49 +00:00
Carsten Haitzler ddbf106d6e ensur emensu dont go futzing about whileu use them... allocate
POTENTIAL space for submenus later. :)



SVN revision: 80751
2012-12-12 11:06:40 +00:00
Mike Blumenkrantz d0eff6a730 fix initial name string for New Directory action
SVN revision: 80748
2012-12-12 10:12:29 +00:00
Mike Blumenkrantz a93a4d56f0 New Directory action in efm now renames inline like New File action
SVN revision: 80747
2012-12-12 10:08:04 +00:00
Carsten Haitzler 353b588347 10k files.... ok! :)
oh and fix a segv people will get when queue process timeout is hit...

and reduce timeout to 0.01 sec :)



SVN revision: 80746
2012-12-12 09:59:53 +00:00
Mike Blumenkrantz 65d7ceb910 backlight gadgets now update themselves on events
ticket #1976


SVN revision: 80745
2012-12-12 09:52:28 +00:00
Mike Blumenkrantz fc3c05f50e warn--
SVN revision: 80740
2012-12-12 09:00:52 +00:00
Mike Blumenkrantz a04ef6cce1 wallpaper previews now maintain aspect ratio when resized
ticket #1981


SVN revision: 80735
2012-12-12 08:05:21 +00:00
Carsten Haitzler da9336c9dd fix menu box packing for submenu itms so when set up in specific
orners with a pre callback... its packed WITH fill



SVN revision: 80661
2012-12-11 14:37:17 +00:00
Mike Blumenkrantz 90ce8a3f24 fix buffer length for deskenv_init
SVN revision: 80660
2012-12-11 14:31:12 +00:00
Mike Blumenkrantz b341cd4689 unbreak mouse move events when autohiding shelves are present
ticket #1961
ticket #zmikeisdumb


SVN revision: 80659
2012-12-11 14:20:53 +00:00
Mike Blumenkrantz 6c751918b8 warn--
SVN revision: 80656
2012-12-11 13:04:53 +00:00
Mike Blumenkrantz 69b94914ea force defaults for recently-removed comp config options
SVN revision: 80655
2012-12-11 13:04:29 +00:00
Mike Blumenkrantz fde12e4225 simplify pager dnd leave cb
SVN revision: 80654
2012-12-11 12:48:49 +00:00
Mike Blumenkrantz b577c7e900 pop an error message about systray's ugliness when shelf style is invisible
SVN revision: 80653
2012-12-11 12:47:10 +00:00
Carsten Haitzler 83e7a0a401 disable "useless" options from the comp gui.
SVN revision: 80647
2012-12-11 11:25:42 +00:00
Mike Blumenkrantz ab1a9e5e80 efm no longer eats pager dnd events
SVN revision: 80646
2012-12-11 11:14:25 +00:00
Carsten Haitzler 54faad046f dont focus noedit entries! :)
SVN revision: 80645
2012-12-11 10:54:31 +00:00
Carsten Haitzler 36523293d2 fix read-only status of file name in desktop editor
SVN revision: 80644
2012-12-11 10:50:54 +00:00
Mike Blumenkrantz c94aac1b87 fix gadman load/shutdown
SVN revision: 80641
2012-12-11 10:49:17 +00:00
Mike Blumenkrantz 00cac2c0a4 add function for determining whether modules are still loading
SVN revision: 80640
2012-12-11 10:30:06 +00:00
Mike Blumenkrantz f287acc53c warn--
SVN revision: 80639
2012-12-11 10:29:48 +00:00
Mike Blumenkrantz a7cba639ab when desklocked, notifications do nothing
SVN revision: 80638
2012-12-11 10:08:49 +00:00
Mike Blumenkrantz 1ecfd5bb0e don't need to iterate on pager drop move cb
SVN revision: 80636
2012-12-11 09:54:50 +00:00
Carsten Haitzler 6e27f1ee5b use a proper specific icon for variables prefs.
SVN revision: 80635
2012-12-11 09:36:03 +00:00
Mike Blumenkrantz 92cdc69ead typo
SVN revision: 80633
2012-12-11 09:19:27 +00:00
Mike Blumenkrantz d4e3ceb6c2 clean up pager enter dnd event cb
SVN revision: 80632
2012-12-11 09:19:15 +00:00
Mike Blumenkrantz 486c74738d use EINA_LIST_FOREACH in pager
SVN revision: 80631
2012-12-11 09:02:13 +00:00
Mike Blumenkrantz c4115615f0 s/creat/open/
SVN revision: 80630
2012-12-11 08:44:05 +00:00
Mike Blumenkrantz 370ba1b3fe okay, after considering the words of a certain frenchman we no longer write anything to new files
SVN revision: 80629
2012-12-11 07:50:06 +00:00
Carsten Haitzler 762b170e75 dont comp fullscreen windows -> off by default.
SVN revision: 80627
2012-12-11 03:51:45 +00:00
Mike Blumenkrantz e61159e49e write \n to new files instead of ""
ticket #1947


SVN revision: 80608
2012-12-10 14:16:16 +00:00
Mike Blumenkrantz c30e42e9ec fix fsel path changing and entry setting
SVN revision: 80606
2012-12-10 13:06:04 +00:00
Carsten Haitzler d65ddc4d66 ok - so not 2 times...
SVN revision: 80603
2012-12-10 11:59:34 +00:00