Commit Graph

156 Commits

Author SHA1 Message Date
Mike Blumenkrantz 2810a4802a remove E_Comp usage from wl desktop shell 2015-03-18 17:34:16 -04:00
Mike Blumenkrantz 0ddedd09a4 wl compile fixes 2015-03-13 20:09:54 -04:00
Mike Blumenkrantz 1736d1ecb9 e_client functions no longer require E_Comp param 2015-03-13 16:53:19 -04:00
Mike Blumenkrantz 091142b032 remove E_Client->comp 2015-03-13 15:41:21 -04:00
Mike Blumenkrantz d42586869e fix wl shell client borders for internal, borderful clients...again 2015-03-13 15:03:13 -04:00
Mike Blumenkrantz b688ddbeb0 don't crash when creating external shell surface clients
sadconditionals.jpg
2015-03-12 14:53:46 -04:00
Mike Blumenkrantz bb77ddf22c correctly apply wl shell client border states only for non-internal clients 2015-03-12 14:48:46 -04:00
Mike Blumenkrantz f1b47ca2af don't create new wl shell clients for internal windows 2015-03-12 14:42:00 -04:00
Mike Blumenkrantz 3f5d25a535 don't identify all wl shell clients as internal...you crackhead 2015-03-12 13:13:55 -04:00
Mike Blumenkrantz 3e4d5ddfc3 always create new client for wl shell surfaces
this should be a more correct way of handling (shell) surfaces since
there's never a time when we won't want to create a new client
2015-03-10 18:27:08 -04:00
Mike Blumenkrantz 4140fb728a don't attempt to find wl shell E_Client when one cannot exist 2015-03-10 16:37:30 -04:00
Derek Foreman 9ef66f7fae Wayland: Don't consume serials when not sending events
Reviewers: zmike, devilhorns

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D2134
2015-03-10 15:52:31 -04:00
Mike Blumenkrantz b069009a16 grab wl shell surface geom and use for adjusting resize operations
I think this still may not be 100% perfect,
but it's more like 95% perfect now instead of 50%
2015-03-03 16:48:25 -05:00
Derek Foreman d576c58bd7 clamp to parent height, not parent y co-ordinate.
Summary:
Clamping to Y makes pop ups get shifted up if a window is
near the top of the screen.

Reviewers: devilhorns, zmike

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D2060
2015-02-26 15:27:52 -05:00
Bryce Harrington 89dbb9bd27 cosmetic: Whitespace cleanup of wayland client files
Summary:
cosmetic: Cleanup whitespace for wayland compositor

There is excess trailing whitespace in several of the files for the
wayland implementation.  These patches attempt to apply the spacing
rules for Enlightenment as documented at:
https://phab.enlightenment.org/w/coding_convention/

The whitespace rules are applied using the following emacs tabbing
settings:

 (defun start-efl-c-mode ()
  "C mode with adjusted defaults for use with Enlightenment
  development."
  (interactive)
  (c-mode)
  (c-set-style "gnu")
  (setq tab-width 8)
  (setq indent-tabs-mode nil)
  (setq c-basic-offset 3)
  (setq defun-block-intro 3)
  (setq statement-block-intro 3)
  (setq case-label 1)
  (setq statement-case-intro 3)
 )

This patchset also eliminates all tabs in favor of whitespace, as per
the coding style rules.

Reviewers: zmike, cedric, devilhorns

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D2048
2015-02-24 17:34:20 -05:00
Chris Michael 9e585e3f79 remove unused variable
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2015-02-24 15:36:34 -05:00
Bryce Harrington 40998b8a6e Code cleanup and check for OOM condition with wl_array_add
Summary:
wayland: Check wl_array_add return for OOM condition
cosmetic: Make error return check syntax consistent with rest of code
wayland: Reuse use_adj to track child-forced adjust
wayland: Refactor to collapse if chain
wayland: Refactor _e_comp_wl_client_priority_adjust to collapse if chain
 + This uses early returns to unwrap a couple if clauses to make the code a bit less nesty.
wayland: Refactor if statements for consistency with rest of file

Reviewers: cedric, zmike, devilhorns

Subscribers: devilhorns, cedric

Differential Revision: https://phab.enlightenment.org/D2034
2015-02-24 14:47:56 -05:00
Mike Blumenkrantz 62328e0c90 remove wl override clients from focus stack
no more client cursor clients in winlist hoorayyyyy
2015-02-13 15:48:00 -05:00
Mike Blumenkrantz 92079a11e7 allow focus on normal wl clients again 2015-02-13 15:45:03 -05:00
Mike Blumenkrantz 1ef496c9cc remove unneeded client attr setting in wl shell
these are always set by the wl new client hook
2015-02-13 15:41:58 -05:00
Mike Blumenkrantz af0508baf9 set wl popups to appropriate layer in shell module 2015-02-13 15:24:24 -05:00
Mike Blumenkrantz e80bd28d33 don't set geometry during wl client surface mapping
this happens automatically in other places, calling it here breaks client placement

 #barrel
2015-02-11 17:15:31 -05:00
Mike Blumenkrantz a9b56c4c28 reenable new_client for wl clients, but force moveresize actions to succeed 2015-02-11 17:00:59 -05:00
Mike Blumenkrantz 8541c13b06 unset new_client flag for wayland clients
this is only applicable for X clients
2015-02-10 15:51:35 -05:00
Mike Blumenkrantz c67e31f99b remove unnecessary EC_CHANGED from wl shell creation
new clients are always changed, this is redundant
2015-02-04 18:09:32 -05:00
Mike Blumenkrantz c196ce0c12 clamp wl popup coords to parent when possible 2015-02-04 18:09:00 -05:00
Mike Blumenkrantz ad41e45b84 set wl popups as overrides
not technically correct but will mimic expected behavior more accurately
2015-02-04 18:01:38 -05:00
Mike Blumenkrantz 8d5ab29625 don't create wl clients as re_manage 2015-02-02 12:41:39 -05:00
Mike Blumenkrantz 2a51535fc0 Revert "move wl pixmap creation into shell, fix pixmap id usage"
This reverts commit c1a93d893e.
2015-01-28 17:29:17 -05:00
Mike Blumenkrantz c1a93d893e move wl pixmap creation into shell, fix pixmap id usage
using raw surface id here guarantees overlap between surfaces for different apps. instead, shift and add app pid to ensure uniqueness

 #barrel
2015-01-28 17:04:59 -05:00
Mike Blumenkrantz 36e4eff943 clarify wl shell errors when failing to create clients 2015-01-28 17:01:16 -05:00
Mike Blumenkrantz a8bd9df733 Revert "simplify/fix wl client borderless setting"
This reverts commit 1b3d89c4c0.

I suck too much to fix this right now, maybe later
2015-01-23 16:30:28 -05:00
Mike Blumenkrantz 1b3d89c4c0 simplify/fix wl client borderless setting 2015-01-23 16:22:02 -05:00
Chris Michael fba5de7d6a Revert "only set wl client borderless state as necessary, don't overwrite existing states"
This reverts commit 5c80ce8e0e.

Revert this as it causes ALL internal windows to not have any borders
anymore.
2015-01-23 14:57:04 -05:00
Mike Blumenkrantz 5c80ce8e0e only set wl client borderless state as necessary, don't overwrite existing states 2015-01-23 14:31:35 -05:00
Mike Blumenkrantz 03c5915245 force server borders on internal wl wins again
this goes back to previous behavior before elm win conversion
2015-01-23 14:10:58 -05:00
Mike Blumenkrantz 1b321567bf simplify wl xdg/shell configure functions
setting changes.XYZ is generally bad and shouldn't be done. in this case, it was obscuring an infinite render resize loop

 #barrel
2015-01-22 23:45:11 -05:00
Mike Blumenkrantz 01b0f4a85d set wl client geometry before showing in desktop shell
bad things (tm) can happen if geometry doesn't get updated before the show

 #barrel
2015-01-22 23:45:08 -05:00
Chris Michael e8c7b82dab Ignore checking size of client and just always send new size. This
fixed basic-->advanced dialogs here

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2015-01-22 14:31:03 -05:00
Chris Michael cf675ad688 wl-desktop-shell: Fix issue where internal elm windows were not
borderless

This fixes the issue of elementary windows having 2 borders, however
it does expose a new issue where those same internal elm windows now
have a black shadow border around them.

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2015-01-09 12:48:04 -05:00
Chris Michael f2e7bd7204 wl-desktop-shell: Remove use of deprecated e_comp_get function
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2015-01-06 09:30:30 -05:00
Chris Michael dd983b2e79 wl-desktop-shell: Always set netwm.ping on the client
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-11-03 12:27:13 -05:00
Chris Michael 1fd35b0636 wl_desktop_shell: Remove silly debug message
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-10-30 10:39:08 -04:00
Chris Michael 1203b36635 wl_desktop_shell: Remove resize.width/height compositor data fields.
Add some debugging print outs.
Don't check client size compared to new size.

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-10-30 10:39:08 -04:00
Chris Michael 7cb087238d wl-desktop-shell: Don't call e_client_ping here.
Summary: As pointed out by shiin, this causes an infinite loop due to
e_client_ping already been called in the pre_frame callback. Thanks
for spotting this !! :)

@fix

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-10-30 08:41:04 -04:00
vivek bcd3c6de49 wl_desktop_shell: Fixed the issue to check if wl surface is active or hung up
Summary:
The patch will setup e_client_cb_ping_poller and as long as wl_surface is
active it will unset hung

Signed-off-by: vivek <vivek.ellur@samsung.com>

Reviewers: devilhorns

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D1608
2014-10-29 10:38:06 -04:00
Chris Michael 9ad13e4fcc wl_desktop_shell: Fix formatting
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-10-29 10:35:24 -04:00
vivek 0a60b1c553 wl_desktop_shell: Fixed the issue to check if client is active or hung up
Summary:
The patch will setup e_client_cb_ping_poller and as long as surface is
active it will unset hung

Signed-off-by: vivek <vivek.ellur@samsung.com>

Reviewers: devilhorns

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D1607
2014-10-29 10:34:26 -04:00
vivek 5f57c472b2 wl_desktop_shell: Implemented function to show xdg shell surface menu
Summary:
Implemented _e_xdg_shell_surface_cb_window_menu_show internal function
to show window menu.

Signed-off-by: vivek <vivek.ellur@samsung.com>

Reviewers: devilhorns

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D1606
2014-10-29 09:51:28 -04:00
Chris Michael 7498dbac99 don't crash when closing internal dialog boxes
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-10-12 10:08:05 -04:00