Commit Graph

93 Commits

Author SHA1 Message Date
Elyes HAOUAS cd5f79c814 tree-wide: get rid of trailing whitespace (part 4)
Remove trailing whitespaces

Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D11823
2020-05-14 13:49:15 +02:00
Alastair Poole 48f9529fbd filepreview: Fix aspect ratio of audio preview.
Artwork from an icon. Previously the image was squashed.
2020-04-06 11:52:01 +01:00
Carsten Haitzler 381c12bd19 cleared widgets handle part 2 2020-03-08 12:28:09 +00:00
Alastair Poole 7856939596 Revert "filepreview_widget: Show "Resolution" field when appropriate."
This reverts commit 555d64d5d5.

This is more fragile than I expected, reverting :/
2020-01-25 11:37:48 +00:00
Alastair Poole 555d64d5d5 filepreview_widget: Show "Resolution" field when appropriate.
Summary:
This adds additional checks to ensure we dont add this field
when it shouldn't be there. Currently files like .tgz are
listing a "Resolution" on mouseover in EFM.

Test Plan:
Mouse over different file types. See inappropriate field.
Apply patch.
Mouse over file types. Resolution should only show for media.

Reviewers: raster, devilhorns

Reviewed By: raster

Subscribers: cedric, zmike

Tags: #enlightenment-git

Differential Revision: https://phab.enlightenment.org/D10783
2020-01-01 14:04:08 +00:00
Mike Blumenkrantz 99db9e2557 more E_BITFIELD conversions 2017-11-08 09:22:24 -05:00
Al Poole b304e77f64 filepreview: unbreak netstar's changes.
The previous broke the video preview size. Was too complicated.
Generally just sucked. This is simpler. I don't want to touch
this again. Sorry!
2017-09-10 22:41:09 +01:00
Al Poole 12e0303e4b filepreview: show mime type icon when not video and no artwork.
This adds the icon associated with the file type to the preview.
If there's no artwork available the audio preview will no longer
be a large void, the mimetype icon will display.
2017-09-10 13:05:44 +01:00
Al Poole 8a9de1de69 filepreview: add support for album artwork in preview when applicable.
When available preview will display album artwork when previewing audio.
2017-09-09 22:23:14 +01:00
Mike Blumenkrantz e93f67e74a go back to image widget for video filepreviews
this still has some funkiness related to initial geometry but it looks
better and doesn't have weird resolution bugs

fix T4293
2017-08-25 14:47:10 -04:00
Mike Blumenkrantz c31cb51499 replace <br> with <ps/> for all text 2017-08-21 10:16:35 -04:00
Carsten Haitzler d196f25a2b filepreview - properly set min size on cells not in a broken way
this should fix T5891
2017-08-20 01:02:03 +09:00
Mike Blumenkrantz c242029cf7 resolve widget-related float-equal warnings
Reviewed-by: Derek Foreman <derekf@osg.samsung.com>
2017-01-06 12:57:33 -05:00
Cedric BAIL ff0b513daa Revert "protect against non-nul terminated string from mmap in filepreview"
This reverts commit 5861d9bef9.

T4543 was already fixed by ae23533b0d.
2016-09-21 09:34:31 -07:00
Carsten Haitzler 5861d9bef9 protect against non-nul terminated string from mmap in filepreview
this should address 2nd gdb bt and fix T4543

@fix
2016-09-21 20:19:01 +09:00
Cedric BAIL ae23533b0d fix text preview to use eina_strbuf_append_length that doesn't call strlen and crash. 2016-09-19 14:50:57 -07:00
Chris Michael 3c8ab9f175 add missing EINA_UNUSED for unused function params
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2016-07-19 13:57:34 -04:00
Cedric Bail 3e74bcb3d3 filepreview: avoid race condition when destroying txt file preview with slow hard drive.
@fix T4119
2016-07-18 16:45:49 -07:00
Stefan Schmidt be97356eaa e_widget_filepreview: Remove assign without effect
CID: 1316023
2015-08-12 09:25:16 +02:00
Yomi 0dc33a5aeb Fix misspellings in E's files.
Summary: Fix misspellings and spaces in E's files.

Reviewers: zmike

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D2676
2015-06-16 16:10:21 -04:00
Chris Michael 0a94e8ba71 enlightenment: Make E build again with EFL from git
sed -i 's/EAPI/E_API/g'

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2015-05-07 15:13:10 -04:00
Mike Blumenkrantz 471dcb24cb __UNUSED__ -> EINA_UNUSED
this has been bugging me forever. __UNUSED__ is no longer a valid macro here.
2015-03-18 18:09:09 -04:00
Mike Blumenkrantz 74bc0435b6 remove unnecessary filepreview size hinting 2015-01-15 03:05:20 -05:00
Mike Blumenkrantz 3fe721b521 enforce min width for filepreview attr entries 2015-01-15 03:05:20 -05:00
Mike Blumenkrantz 3fc96af2dd Revert "revert all the ui breakes in e - going the wrong direction in the"
This reverts commit 3ea6a3569d.
2015-01-15 03:04:42 -05:00
Carsten Haitzler 3ea6a3569d revert all the ui breakes in e - going the wrong direction in the
first place anyway. shoudl replace the entire dialgo one at a time by
an elm version not try and stuff elm widgets into where e widgets used
to be. this doesnt improve e's config dialogs, just makes them buggy
as all hell in the name of a move to elm.

Revert "e_widget_button -> elm_button conversion"
This reverts commit b1c976d80d.

Revert "update widget size hints when setting a resize object"
This reverts commit fdab0218b2.

Revert "remove no-longer-necessary size hinting in list widgets"
This reverts commit 21479f5019.

Revert "e_widget_textblock -> elm_entry conversion"
This reverts commit 8fe2f00f75.

Revert "e frame -> elm_frame conversion"
This reverts commit e9da6a02fc.

Revert "remove unnecessary size hinting"
This reverts commit b596623efd.

Revert "e_label -> elm_label conversion"
This reverts commit 049b318679.

Revert "set evas size hint min in widget min size"
This reverts commit 2f09aa2fda.

Revert "e_table -> elm_table conversion"
This reverts commit 6434012982.

Revert "remove unused vars"
This reverts commit b19e706b23.
2015-01-15 12:13:53 +09:00
Mike Blumenkrantz 720b19331f don't override entry min sizing in filepreview 2015-01-14 20:43:31 -05:00
Mike Blumenkrantz 6434012982 e_table -> elm_table conversion
if rebases were monopoly money, this commit would be able to buy mediterranean ave.

 #teamborker
2015-01-13 22:44:55 -05:00
Mike Blumenkrantz c978a045e6 e_entry -> elm_entry conversion
another dice roll in the board game of enlightenment development. next, I will attempt to roll doubles to get out of jail.

 #teamborker

fix T1906
2015-01-11 12:20:46 -05:00
Carsten Haitzler 069a1b169a use gstreamer1 emotion module now for video as its rather stable
this also fixes T1290
2014-05-29 14:30:34 +09:00
Wonguk Jeong cf6d509dfe filepreview: video size bug fix
Summary: after commit 36a4948085, video size was not proper size in preview. the commit was good refactoring. resize only when the video file is opened. but, the smart callback name was wrong. change smart callback name from "length_change" to "open_done"

Test Plan: enlightenment -> efm -> preview on video file -> check whether the video size is shown properly

Reviewers: raster, zmike

CC: seoz, cedric

Differential Revision: https://phab.enlightenment.org/D779
2014-04-22 13:10:00 -04:00
Chidambar Zinnoury 36a4948085 Bugfix: e filepreview widget: No need to compute dimensions and resize widgets at each and every single frame.
Doing it once on file opening should be enough.
2014-04-21 22:40:45 +02:00
Chidambar Zinnoury c52d6e201a Bugfix: e filepreview widget: Use correct units for devices sizes.
This will also make them consistent with file sizes.
2014-04-21 16:32:02 +02:00
Mike Blumenkrantz 6dd98df0d6 remove all remaining efl version check defines 2014-03-13 11:55:29 -04:00
Mike Blumenkrantz 927300053d feature: show video resolution in filepreview widget 2014-01-27 12:29:15 -05:00
Mike Blumenkrantz bc3e1fd94f feature: add fileman option to clamp video size for video previews
T102
2014-01-27 12:28:35 -05:00
Carsten Haitzler 9a56f95bad oops - remove debug commit that snuck in! 2013-11-24 13:50:45 +09:00
Carsten Haitzler a96f443c10 gadman - fix possible segv with conf being null 2013-11-24 12:35:47 +09:00
Carsten Haitzler 38bb5e09db file preview - increase preview text to 8192bytes 2013-11-18 06:08:17 +09:00
Carsten Haitzler a10d87a326 file preview text display - calculate minimum size so alignment is ok
this fixes T444 - the display of text is properly top-left aligned
with scrollbars now actually correct too for the text provided (note
that the preview doesnt put ALL text in there. just the first N bytes
which by default is 2048 but can be changed).
2013-11-18 06:05:24 +09:00
Carsten Haitzler a1d1e40559 elm integration improvement - copy themes over, fix includes and null config
provide a config upgrade path to version 13 which nulls/frees out
theme config (save memory - but more housekeeping), and that also
copeis ofer all files in ~/.e/e/themes to ~/.elementary/themes so you
don't lose themes you personally have and deletes the old e theme dir
if this succeeds.

also remove all #includes of Elementary.h and Emotion.h from single c
files as they are requirements now and in e.h

also remove theme path vars and code as theme path is no longer used.
2013-11-01 15:53:05 +09:00
Carsten Haitzler 6eca480e76 make emotion as well as elm requirements, ecore-imf is not used anymore. 2013-10-31 17:12:32 +09:00
Carsten Haitzler ba7bc6dba2 fix mounted fs used/free/reserved display to work again... 2013-07-14 18:04:27 +09:00
Carsten Haitzler 934e02b320 font previews in efm - in thumbnails and in efm preview 2013-07-02 14:24:16 +09:00
Mike Blumenkrantz 78e0d3c62e fix emotion filepreview backend setting with 1.8 2013-06-17 16:07:59 +01:00
Carsten Haitzler 9f530e27d2 fix valgrind null evas problem with preview.
fix preview aspect ratio out-of-bounds packing with videos when not
widescreen. :)



SVN revision: 84267
2013-02-21 01:11:00 +00:00
Mike Blumenkrantz 93478999a3 add support for edje files in filepreview widget
SVN revision: 83585
2013-02-04 09:09:15 +00:00
Mike Blumenkrantz 9e8e755cdf formatting: all at once
SVN revision: 82625
2013-01-11 10:34:29 +00:00
Mike Blumenkrantz 15df42143e add some null checks before monitor deletion to account for people still affected by the frenchman's laziness
SVN revision: 80757
2012-12-12 12:34:49 +00:00
Massimo Maiurana 8b38245df1 two more duplicate message with different case and also two with slash and hyphen
SVN revision: 80481
2012-12-07 18:15:14 +00:00