5b3408bb85
s/E17/E18/
2013-06-18 15:44:57 +01:00
5ac0b9df10
remove unnecessary call to evas_object_data_get during gadget deletion
2013-05-23 11:16:00 +01:00
70d68a30e0
giant comp rejiggering commit #4
...
* dnd canvas removed, dnd objects now drawn directly on compositor canvas
* dnd now correctly picks the top-most dnd-receiver location as its drop target instead of just using the first one in the list
* various other small changes to go along with this
2013-02-22 13:18:30 +00:00
19f79acb45
add e_gadcon_repopulate
...
this allows unpopulate+repopulate calls to occur while the layout is frozen, providing a substantial speedup
2013-02-22 13:18:30 +00:00
536254e2ce
start drag if gadget has been moved the size of the gadget
...
when a gadget is at the edge of its gadcon, it can't move more than this amount, so we have to start the drag immediately
2013-02-22 13:18:30 +00:00
56fdcf1faa
use e_gadcon_zone_get for dnd-related functions to ensure we get the right zone: fixes toolbar dnd
2013-02-22 13:18:30 +00:00
4b9113f3ba
use new comp layer functions to correctly set layer for gadget mover objects...this needs to be redone entirely along with the rest of gadcon
2013-02-22 13:18:30 +00:00
bf9933a336
E_FN_DEL macro renamed to E_FREE_FUNC with param order swapped for consistency
2013-02-22 13:18:30 +00:00
88f00310d7
e toolbar gadgets no longer crash when trying to display a popup
...
SVN revision: 84258
2013-02-20 09:13:03 +00:00
32157d8fe5
fix gadget event object layering for dnd
...
SVN revision: 84239
2013-02-19 14:29:57 +00:00
2297f7d071
gadcon now correctly freezes its container object when unpopulating
...
SVN revision: 84058
2013-02-18 13:43:37 +00:00
32bcde16af
add e_gadcon_client_visible_get()
...
SVN revision: 84055
2013-02-18 13:43:29 +00:00
aa6a2d173d
giant comp rejiggering commit because anything smaller would have broken something:
...
* remove xwin for container canvas: now drawn directly on the compositor canvas
* added SHAPE_DEBUG define for bored developers
* bindings now use new e struct for mouse/wheel events
* container+zone now get mouse events from smart callbacks instead of x events
* rename comp api namespace
* change comp underlay theme to have a swallow for the wallpaper
* add names to all zone/container/comp objects to make debugging much easier
* some minor related updates to go along with this
SVN revision: 83752
2013-02-07 13:20:07 +00:00
6dc0f1f64e
delete gadget evas objects on delete to prevent crash on restart now that comp is merged into core
...
SVN revision: 83505
2013-01-31 10:53:50 +00:00
9e8e755cdf
formatting: all at once
...
SVN revision: 82625
2013-01-11 10:34:29 +00:00
Massimo Maiurana
c4058ca063
Make some error dialogs translatable (patch from Igor Murzov)
...
SVN revision: 81394
2012-12-19 17:45:04 +00:00
aa35b742c5
don't stop filling a gadcon if one (systray) fails to create
...
SVN revision: 81331
2012-12-19 09:17:05 +00:00
a658db2782
use e_util_strcmp, set current gadcon style menu item to disabled, only use default style as menu item if current style not set
...
ticket #2023
SVN revision: 81226
2012-12-18 09:30:35 +00:00
558894792f
fix gadcon stringshare usage
...
SVN revision: 81225
2012-12-18 09:25:48 +00:00
006a014982
gadcon positioning leak
...
SVN revision: 80850
2012-12-13 13:41:35 +00:00
fbc12f2e3f
only save gcc during edit end if the gcc has a config
...
SVN revision: 79875
2012-11-30 08:50:12 +00:00
6600e453ec
delete gcc drag object if it exists when gcc is deleted
...
SVN revision: 79836
2012-11-29 15:19:24 +00:00
c21b0240ba
don't show gcc drag object when dragging desktop icons on same zone
...
SVN revision: 79833
2012-11-29 13:42:42 +00:00
d7a5385b2b
only run a gadcon populate event after module init end
...
SVN revision: 79829
2012-11-29 12:15:50 +00:00
25853a0c2a
fix possible null deref crash when deleting gadcon client config
...
SVN revision: 79827
2012-11-29 11:48:34 +00:00
af38ddf0a6
delete any invalid gadcon clients for custom gadcons since we don't validate as much here
...
SVN revision: 79823
2012-11-29 10:09:28 +00:00
011b6c7b02
NULL check gadcon dnd enter events so we don't crash on efm drag operations
...
ticket #1820
SVN revision: 79676
2012-11-26 08:29:22 +00:00
Carsten Haitzler
92d53b87a5
and remvoe debugging.
...
SVN revision: 79670
2012-11-26 06:40:35 +00:00
Carsten Haitzler
7277ce21b1
fix segv where menus are not actually popped down on deletion of gcc.
...
SVN revision: 79669
2012-11-26 06:38:43 +00:00
Carsten Haitzler
108b985e87
valgrind complain-- :
...
SVN revision: 79665
2012-11-26 03:49:55 +00:00
e5903f4740
add support for and use eina_list_last_data_get
...
SVN revision: 79144
2012-11-12 10:05:09 +00:00
68e70b0131
E: Fix bug. The "Look" submenu of a gadget would not have any item
...
selected (Plain/Inset) if no style was previously selected for this
gadget. This adds code that also checks the Client Class default style
if no gadget style has been assigned yet.
Signed-off-by: Christopher Michael <cp.michael@samsung.com>
SVN revision: 78505
2012-10-26 07:20:59 +00:00
8894fb5f50
E: Fix formatting for 80 columns
...
Signed-off-by: Christopher Michael <cp.michael@samsung.com>
SVN revision: 78504
2012-10-26 07:20:51 +00:00
ebef167dab
improve shelf gadget dragging
...
ticket #1658
SVN revision: 78420
2012-10-25 07:37:53 +00:00
Carsten Haitzler
53ad992c31
pointed out by Igor Murzov - fixed backlight thing, gadcon is cleaner.
...
SVN revision: 77980
2012-10-15 07:05:00 +00:00
Carsten Haitzler
35773a3241
add config for disabling delayed modules. this actually drastically
...
speeds up e startup - but this i mean the shelf comes up instantly
populated rather than taking 2 or 3 seconds to figure its life out.
SVN revision: 77558
2012-10-07 10:01:14 +00:00
43fb89ddb7
gadcon "Move to" menu no longer shows the gadget's current gadcon
...
SVN revision: 77523
2012-10-05 10:07:22 +00:00
71f57bb52d
gadcon location gadget_add callbacks now have a gadcon client param so the config can be retrieved since these callbacks are (currently) only used for changing locations of gadgets
...
also the related gcc param in gadget_del can now have a NULL config to signify that the gadget has been moved to a new gadcon
this means that moving a gadget to a new location will no longer cause it to lose its gadget config
ticket #1594
SVN revision: 77521
2012-10-05 09:57:34 +00:00
817bec21b1
prevent DND for systray gadgets in all cases
...
SVN revision: 77357
2012-10-03 09:19:26 +00:00
54d1715e58
debug printf--
...
SVN revision: 77272
2012-10-01 14:07:37 +00:00
4c09bb330f
yet another gadget overhaul, this time fixing:
...
* gadget dragging over windows (ticket #1563 )
* gadget dragging/resizing on the hover layer
* yet another gadget refcount bug
* lots of annoying inconsistencies when dragging around new desktop gadgets
SVN revision: 77271
2012-10-01 14:02:24 +00:00
8a7477d9a8
reflow some code
...
SVN revision: 77254
2012-10-01 08:54:36 +00:00
37f4478e0a
add last resort fix for an extremely rare corner case in gadman which causes objects to be undeletable at this point, preventing shutdown due to an infinite loop
...
SVN revision: 76930
2012-09-21 06:45:11 +00:00
8233970853
fix nulling of gadcon populate idler
...
SVN revision: 76908
2012-09-20 12:54:11 +00:00
5e0b6fd200
reorder shelf startup slightly, add gadcon populate event, only show created shelf after it's been populated, populate gadcons incrementally instead of all at once
...
this commit reduces my startup time by 0.5-1.0 seconds on average when using two shelves
SVN revision: 76894
2012-09-20 08:44:30 +00:00
03a578abae
initialize variable
...
SVN revision: 76808
2012-09-18 11:44:24 +00:00
ea61755d98
fix a bunch of questionably valid null derefs from clang
...
SVN revision: 76807
2012-09-18 11:42:44 +00:00
03dda786da
with massive hacks and huge other hacks, it's finally possible to seamlessly drag icons from the desktop to a shelf and vice versa
...
ticket #113
SVN revision: 76765
2012-09-17 14:49:48 +00:00
95ac2fdc8a
show/hide gadget drag object when leaving/entering gadcons
...
SVN revision: 76761
2012-09-17 13:10:19 +00:00
59d33a4a8b
remove debug info
...
SVN revision: 76758
2012-09-17 12:24:17 +00:00
040b87a604
clean up gadcon dnd code to not use static variables
...
SVN revision: 76757
2012-09-17 12:23:55 +00:00
fbc50eee75
prevent gadcon callbacks from being added multiple times
...
SVN revision: 76749
2012-09-17 09:50:49 +00:00
8bea4f9411
check for existence BEFORE getting geom
...
SVN revision: 76744
2012-09-17 09:27:05 +00:00
7031ce46b4
fix bug where gadgets could not be dragged left on shelf at the expected level of dragging, also increase drag threshold for moving gadgets to the right
...
SVN revision: 76736
2012-09-17 07:09:21 +00:00
9ccf1d988f
don't delete gadgets when drag is done if new gadget is dropped gadget
...
SVN revision: 76735
2012-09-17 06:10:49 +00:00
4036e9a3c5
need to unlock gadcon BEFORE checking whether gadcon is still editing, otherwise we never unlock and always break shelf autohide
...
SVN revision: 76731
2012-09-17 05:26:22 +00:00
092b37f981
hmm it seems that attempting to be clever and show/hide when leaving and entering the same gadcon during a drag is at least part of the problem with ticket #1462...
...
SVN revision: 76730
2012-09-17 05:25:15 +00:00
d181a362c6
fix gadget dnd bug where repeatedly dragging gadgets around from shelf to desktop to shelf to desktop to shelf to desktop would confuse gadman and prevent it from injecting gadgets properly
...
SVN revision: 76729
2012-09-17 05:02:23 +00:00
6cf37f95bf
delete newly-created gcc here if it isn't our current gcc since we won't be using it
...
SVN revision: 76728
2012-09-17 04:44:41 +00:00
46afc57359
check null here even though it SEEMS impossible to prevent jokers from injecting bad configs
...
SVN revision: 76727
2012-09-17 04:41:09 +00:00
194dbb13a3
fix rare gadget dnd crash
...
SVN revision: 76726
2012-09-17 04:29:49 +00:00
5193de5919
finally fix moving (dragging) gadgets from a shelf to the desktop in a super hackish way that will hopefully be fixable in e18 with a complete rewrite of gadcon/gadman
...
note: this will look really bad (giant black rectangle) if you have "Use ARGB instead of shaped" checked in Engine config
SVN revision: 76543
2012-09-12 16:23:02 +00:00
8f0aa351f8
reflow some code
...
SVN revision: 76536
2012-09-12 15:02:12 +00:00
e81c385e57
break out gadcon drop handler add into separate function to make it reusable
...
SVN revision: 76516
2012-09-12 10:37:29 +00:00
4c89c8ccb1
add mechanism for deleting gadcon configs, shelf deletion now triggers gadcon deletion, fix crash when renaming shelves, prevent shelves from being renamed to the same name as another shelf, fix bug where gadcon client ordering would increase infinitely when adding/removing/redrawing gadgets
...
SVN revision: 76297
2012-09-07 11:00:25 +00:00
e0c57c8244
remove this misleading line: there is NEVER a zone here.
...
SVN revision: 76280
2012-09-07 07:08:48 +00:00
0e414444b2
add flag to gadcons to mark them as being custom gadcons, don't refresh custom gadcons completely when repopulating, fix crash which occurred when gadcon container was deleted before gadcon
...
SVN revision: 76256
2012-09-06 18:26:09 +00:00
c66c6babeb
add events for gadcon provider add/del
...
SVN revision: 76233
2012-09-06 09:28:53 +00:00
0b9f1a9c17
add new events for gadcon clients being added/removed
...
SVN revision: 76225
2012-09-06 07:40:30 +00:00
0fc873f1b9
revert gadcon event thingy, this causes a stupid gadman bug crash which takes more than 5 mins to fix
...
SVN revision: 76203
2012-09-05 16:47:16 +00:00
0a50c49958
add events for gadcon populate/unpopulate
...
SVN revision: 76199
2012-09-05 14:17:43 +00:00
4c0fa2d381
big roundup commit fixing leaky submenus
...
SVN revision: 75973
2012-09-03 08:30:39 +00:00
5c3352c57f
add function for changing a gadcon client's menu
...
SVN revision: 75971
2012-09-03 08:02:33 +00:00
Carsten Haitzler
40a67e9222
streamline gadget menu to move move item to main menu.
...
SVN revision: 75407
2012-08-18 10:54:02 +00:00
3433a78ba2
gadcon util menu thingy now sets created menu to appropriate struct members to prevent unexpected behavior
...
SVN revision: 75282
2012-08-15 06:35:02 +00:00
8da7dd34b1
probably a good idea to actually delete menus when they hide instead of just praying for it
...
indirectly fixes ticket #1287
SVN revision: 75256
2012-08-14 12:39:19 +00:00
e9cb0d2085
gadget provider list is now sorted alphabetically
...
SVN revision: 75201
2012-08-13 09:51:50 +00:00
e3e11778fa
wait till after module init is over before drawing gadgets so we can draw them all at once, also don't need to bind to frametime anymore with this
...
SVN revision: 75067
2012-08-10 07:02:02 +00:00
f8eff99bf8
Dear all.
...
I found the bug which may occurs enlightenment crash.
There is code to insert E_Gadcon pointer to custom_populate_requests list in e_gadcon_custom_new(). However, there is no code to remove deleted E_Gadcon pointer from custom_populate_requests list in e_gadcon_custom_del(). So, if the e_gadcon_custom_del() is called before calling _e_gadcon_custom_populate_idler(), then enlightenment crash may occurs while e calls _e_gadcon_custom_populate_idler() because e accesses deleted E_Gadcon pointer.
I modified this problem. Please review this patch.
Thanks.
--
Doyoun Kang
SVN revision: 75033
2012-08-09 08:25:41 +00:00
7623fa4de0
add new functions for renaming a shelf/gadcon in the process of hunting #1286
...
SVN revision: 74973
2012-08-07 10:28:28 +00:00
031fc80e2f
clean up my earlier gadcon/menu idler work to be functional, thanks to jeffdameth for pointing it out
...
SVN revision: 74786
2012-08-02 07:20:51 +00:00
71ce826982
e_gadcon_client_find now takes an optional gadcon param to speed it up where possible
...
SVN revision: 74512
2012-07-27 16:10:06 +00:00
4ffafd3313
ensure gadcon class is populated before trying to create a client for it
...
SVN revision: 74507
2012-07-27 15:30:36 +00:00
f990c4d738
greatly simplify gadcon populate idler
...
SVN revision: 74491
2012-07-27 13:18:25 +00:00
df03a272e5
remove useless checks on gcc name
...
SVN revision: 74488
2012-07-27 12:29:55 +00:00
5db9d9fb00
change gadcon waiting classes list to a hash in order to remove some strcmps
...
SVN revision: 74487
2012-07-27 12:26:41 +00:00
5a6e5ec964
make client class population gadcon-specific so we don't end up populating every gadcon site with 500 client classes if they're only used on a single shelf
...
SVN revision: 74485
2012-07-27 10:54:00 +00:00
5070653af2
add debug timing info for gadcon idler populates
...
SVN revision: 74478
2012-07-27 09:28:25 +00:00
81cbce9d96
log error and fail when attempting to register a nameless gadcon client class to prevent massive failure later
...
it is once again a good time to update
SVN revision: 74477
2012-07-27 08:46:04 +00:00
8b0c1eaefe
fix gcc populates to actually set all necessary variables and prevent config from being wiped; fixes gadman gadgets randomly disappearing and probably a lot of other unnoticed bugs
...
SVN revision: 74476
2012-07-27 08:42:16 +00:00
f08e7423f2
make gadcon class function pointers require const as they should, add new custom populate request function, consolidate gcc populate code
...
compile warnings are being cleaned up next
SVN revision: 74472
2012-07-27 08:17:32 +00:00
5389c8a964
forgot to deregister client class from populated list
...
SVN revision: 74445
2012-07-26 14:13:49 +00:00
14b109ac78
fix gadcon crashing when enabling/disabling modules
...
SVN revision: 74443
2012-07-26 13:59:41 +00:00
812abd7c1d
actually I don't know wtf I was thinking with 74438, I was clearly a misguided genius in the code that I removed in this commit; fixes adding new gadgets and also speeds up the process greatly
...
SVN revision: 74441
2012-07-26 13:00:15 +00:00
f8b1dbf2e3
add function for finding a gadcon client from its config
...
SVN revision: 74439
2012-07-26 12:41:41 +00:00
512f48014c
not sure what I was thinking here, no need to repopulate a gadcon when client class is populated
...
SVN revision: 74438
2012-07-26 12:41:01 +00:00
ec019bae91
only populate custom gadcons with the gadgets that are actually loaded in the gadcon: huge speedup
...
SVN revision: 74433
2012-07-26 11:05:39 +00:00
c2b2d7e5ad
registering a gadcon client class no longer immediately tries to populate the class; we now populate classes only when a gadget for the class is loaded to further reduce the initial loading clusterfuck
...
SVN revision: 74432
2012-07-26 10:34:40 +00:00
f66e16178c
in general, any time e_icon_object_set is used, it's wrong. e_icon doesn't handle these cases and fails in every case other than the initial _set() call.
...
SVN revision: 74209
2012-07-20 06:53:52 +00:00
42ceb58540
merge a big e17 doc patch
...
ticket #91
SVN revision: 73408
2012-07-06 10:53:22 +00:00
Mike Blumenkrantz
Mike Blumenkrantz
Massimo Maiurana
Carsten Haitzler
Christopher Michael