cf6d509dfe
filepreview: video size bug fix
...
Summary: after commit 36a4948085https://phab.enlightenment.org/D779
2014-04-22 13:10:00 -04:00
36a4948085
Bugfix: e filepreview widget: No need to compute dimensions and resize widgets at each and every single frame.
...
Doing it once on file opening should be enough.
2014-04-21 22:40:45 +02:00
b4a58ad874
Bugfix: e fileman: Correct automagic window size computation.
...
When available width is less than minimum width, the height was computed according to the available width, but the window width was effectively the minimum width: its height was thus more than needed.
The function now takes the minimum dimensions so that correct height and width are computed.
2014-04-21 21:54:15 +02:00
c52d6e201a
Bugfix: e filepreview widget: Use correct units for devices sizes.
...
This will also make them consistent with file sizes.
2014-04-21 16:32:02 +02:00
edaf24d3b0
e: It’s now 2014!
2014-04-21 15:56:03 +02:00
Carsten Haitzler
8e49b69796
re-order icon finding for border to use the most reliable source first
2014-04-19 09:08:37 +09:00
ffcc5e72d9
null check ecstack
...
Summary: fix segmentation fault error
Test Plan:
run enlightenment (wl only server) -> run elementary_test -> run terminlogy
-> move cursor to elementary_test -> click on elementary_test
Reviewers: raster, devilhorns, zmike
CC: cedric
Differential Revision: https://phab.enlightenment.org/D770
2014-04-18 12:51:36 -04:00
Carsten Haitzler
4cce0080b8
fix resent eo changes to e that break updating labels and toggles
...
this fixes D1172
2014-04-18 09:53:00 +09:00
Carsten Haitzler
bdc3d5b5e3
formatting
2014-04-18 09:39:16 +09:00
fb437cd1b0
comp_x_screensaver: screensaver off bug fix
...
Summary:
Can not turn off screensaver due to condition check bug.
@fixes
Test Plan: enlightenment -> do nothing -> screen saver on -> mouse/key input -> check whether screen saver is turned off or not
Reviewers: raster, cedric, zmike
Reviewed By: raster
CC: seoz, cedric
Differential Revision: https://phab.enlightenment.org/D766
2014-04-18 09:35:45 +09:00
Carsten Haitzler
cf90b84a42
fix screensaver/blanking issue where a ss on/off events come in together
2014-04-17 13:55:39 +09:00
7274ffa742
improve eolian build dependency
2014-04-11 13:40:58 -04:00
a2026425d1
mfw I forget git add
...
..........................__......
.................,-~*`¯lllllll`*~,....
...........,-~*`llllllllllllllllll¯`*-,..
......,-~*lllllllllllllllllllllllllllll*-,.
...,-*llllllllllllllllllllllllllllllllll.\.
.;*`lllllllllllllllllllllllllll,-~*~-,llll\....
..\lllllllllllllllllllllllllll/......\;;;;,-`~-,.
...\lllllllllllllllllllll,-*....`~-~-,...(.(¯`*,`,.
....\llllllllllll,-~*..............)_-\..*`*;..).
.....\,-*`¯,*`)............,-~*`~.............../...
......|/.../.../~,......-~*,-~*`;................/.\..
...../.../.../.../..,-,..*~,.`*~*................*...\..
....|.../.../.../.*`...\...........................)....)¯`~,...
....|./.../..../.......)......,.)`*~-,............/....|..)...`~-,.
..././.../...,*`-,.....`-,...*`....,---......\..../...../..|...¯```*~-,,
...(..........)`*~-,....`*`.,-~*.,-*......|.../..../.../...............\.
....*-,.......`*-,...`~,..``.,,,-*..........|.,*...,*...|..............\.
.......*,.........`-,...)-,..............,-*`...,-*....(`-,............\.
..........f`-,.........`-,/...*-,___,,-~*....,-*......|...`-,..........\.
2014-04-10 19:33:05 -04:00
b49957bf9b
preserve client stacking after compositor effects
...
fix T1065
2014-04-10 19:01:50 -04:00
47cfb31752
comp_object now uses eo, e_comp_object_signal* -> edje_object_signal*
...
also cw->clip is gone
2014-04-10 19:01:47 -04:00
c5c7b4733a
efm: fix bugs during renaming multiple files and copying file into same directory
...
Summary:
Since E_FM_OP_OVERWRITE_RESPONSE_NO was sent before file renaming, src had been changed as next file.
->send E_FM_OP_OVERWRITE_RESPONSE_NO after file renaming.
File became empty if I copy a file into same directory
--> first of all, prevent move, rename, symlink into same directory. in case of copy, attach " (copy)" postfix after file name automatically. (need to decide postfix policy)
fixes T739
Reviewers: zmike, raster
CC: seoz, cedric
Maniphest Tasks: T739
Differential Revision: https://phab.enlightenment.org/D707
2014-04-10 11:09:36 +09:00
11f9dcfd72
fix null deref in e_shelf
...
CID 1039825
2014-04-04 15:26:11 -04:00
9d0f4b7036
use e_util_strcmp() in e_font stuff
...
CID 1039827, 1039826
2014-04-04 15:24:01 -04:00
05d09f7c51
null check xkb layout list
...
CID 1039869
2014-04-04 15:04:28 -04:00
ba3ffcf029
remove a bunch of unused e_util edje icon functions
...
CID 1039948, 1039946
removals: e_util_*edje_icon_list*
2014-04-04 15:04:28 -04:00
91aee716cc
bugfix: comp config dialog correctly detects effects disabled/fast states
...
CID 1039957, 1039956
2014-04-04 15:04:28 -04:00
1285ba4196
check import config dialog unlink() return value
...
CID 1039964
2014-04-04 15:04:28 -04:00
11197cb684
check rename() return value
...
CID 1039966
2014-04-04 15:04:28 -04:00
358ba0f36f
e_bindings_key_allowed() handles NULL param
...
CID 1191998
2014-04-04 15:04:27 -04:00
c17d33368c
check pixmap_size_get() return in e_pointer
...
CID 1195448
2014-04-04 15:04:27 -04:00
95a8fed0bf
unify comp object stacking
...
these were nearly identical, and sooner or later there was going to be an unfortunate c/p error
2014-04-02 14:16:34 -04:00
cfe26ff838
comp docs part 1: comp objects
2014-04-02 13:06:28 -04:00
b9e6a624ef
fix frame size calc check to account for themes with 0 height
2014-04-02 12:31:33 -04:00
3f2efbc548
fix client layer marker detection/usage in wayland
...
this is the correct fix for D687
2014-04-02 11:07:22 -04:00
597aec1710
remove unused comp object variable use and function call in show helper
...
Reviewers: zmike
Differential Revision: https://phab.enlightenment.org/D686
2014-04-02 09:27:20 -04:00
26d3075e3d
wl pointer configure: fix typo
...
Summary: ews->geometry.y needs to be set.
Test Plan: N/A
Reviewers: raster, devilhorns, zmike
Reviewed By: devilhorns
CC: cedric
Differential Revision: https://phab.enlightenment.org/D688
2014-04-02 10:39:07 +01:00
dc05d96659
Fix client border changing issues
...
The code was zeroing the flag that tells e to change the border after
the callbacks about frame changes. This means that one couldn't change
the border from within those callbacks. This commit fixes this issue.
2014-03-31 15:24:12 +01:00
a291211b13
bugfix: efm current .desktop fetching now returns the right .desktop
...
fix T792
2014-03-28 12:23:18 -04:00
114b411da1
never use new clients for stacking
...
fix Tcedric
2014-03-27 21:27:51 -04:00
da5bd16e12
greatly improve child dialog placement, FIXME--
...
fix T980
2014-03-27 19:47:31 -04:00
ea3439b664
Revert "move comp object tiler creation to helper function to catch retries"
...
This reverts commit f4e4b2fc4f
2014-03-27 17:01:22 -04:00
e49b3beff1
ensure minimum X parent window size of 1x1
...
fix T1098
2014-03-27 16:47:19 -04:00
f4e4b2fc4f
move comp object tiler creation to helper function to catch retries
2014-03-27 16:47:19 -04:00
6308846480
don't refocus hidden clients on desk flip
...
probably fix T1083
2014-03-27 16:47:19 -04:00
6e72796544
check key events for both key and keyname bindings
...
fix T1119
2014-03-27 16:47:19 -04:00
50a37adb6e
ignore mouse movements on client during keyboard actions
...
fix T1097
2014-03-27 16:47:19 -04:00
3f10e7557f
ignore X layer window mouse events
...
fix T1130
2014-03-27 16:47:19 -04:00
110f62ca61
always unclip/uneffect clients when changing desks
...
probably fix T1126
2014-03-27 16:47:18 -04:00
53824eb309
redo input rects after comp effect layer changes
...
fix T1070
2014-03-27 16:47:18 -04:00
18120e1b5a
remove invalid shelf autohide window check which would always be wrong
2014-03-27 16:47:18 -04:00
42f43c9311
disable comp object animation hooks if animations are disabled
2014-03-27 16:47:18 -04:00
daa98e867d
fix lots of edje emits on non-edje objects
2014-03-27 16:47:18 -04:00
f2f45428ff
+e_icon_edje_get()
2014-03-27 16:47:18 -04:00
Carsten Haitzler
1e50cb1dc6
don't delete client objects when _e_client_hook_call returns false.
...
_e_client_hook_call() returns false when object refcount hit 0... ie..
it's been deleted. it's simply invalid memory access to then del the
object thats already gone to 0 refcount and been deleted/freed.
2014-03-26 15:32:53 +09:00
24296fa005
use eo to shut up harmless eo menu errors
2014-03-24 12:34:07 -04:00
3d8f5d3b05
add eo headers, aka Captain #define
2014-03-24 12:34:07 -04:00
a08c40df7b
ilist: Remove unused assignment
...
CID 1039758
2014-03-24 13:26:20 +01:00
68719520e6
fm: Check return of strrchr
...
strrchr can return NULL, so we need to check the return value.
CID 1039861
2014-03-24 13:23:39 +01:00
2d9f5764a3
fm: Fix weird test
...
ic is always true for this function, else dereference would fail. So the
only valid thing to check is whether we already have a drop_icon.
CID 1039829
2014-03-24 13:20:25 +01:00
81c384de9f
dialog: allow setting of NULL icon
...
If NULL is passed as icon, icon should be disabled.
CID 1039951
2014-03-24 13:13:53 +01:00
168dc8ef38
comp: no need to assign pointer before return
...
As we return after the list free, no need to set the pointer.
CID 1087717
2014-03-24 13:02:56 +01:00
83475dad7e
set wayland display socket based on e_ipc_socket name
2014-03-20 14:06:41 -04:00
2bbab7e525
export e_ipc_socket filename as extern variable
2014-03-20 14:06:41 -04:00
c47bf94cdf
hook sticky smart callbacks properly inside comp object
2014-03-20 11:38:58 -04:00
b5a04496b7
add stick/unstick client smart callbacks
2014-03-20 11:31:32 -04:00
04a5a11a8f
e_pointer: Fix missing if for else if condition
...
Fixing devilhorns commit and run commit. If we have a condition we want
to check we need an else if not a simple else. Always compile before push.
Especially the small and simple changes. :)
2014-03-20 15:50:51 +01:00
d0b61e4b88
bugfix: Properly hide/show pointer_image & pointer_object based on if
...
the pointer is located on an existing canvas
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-03-20 14:16:42 +00:00
5ce5d2d90b
bugfix: Set pass_events and layer of the pointer image if we are
...
creating a new one.
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-03-20 14:16:42 +00:00
ffe4bf794e
e: let's just completely blacklist NVidia driver for Wayland.
2014-03-20 20:46:54 +09:00
db40e4b67e
bugfix: Fix crash on eglTerminate with buggy Nvidia blob driver
...
NB: Thanks for the report cedric ;)
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-03-20 10:18:44 +00:00
52532f9a32
Don't leak the allocated client object if we are returning null from
...
e_client_new
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-03-20 10:18:44 +00:00
5b77c566e6
Use ecore_wl functions to return the pointer location if we are
...
running as wayland-only
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-03-20 10:18:44 +00:00
30846ee4ea
randr: Update lid status when outputs change
...
If we only have lid, it will be active even though lid is closed. If we
connect a monitor we want the lid to deactivate.
2014-03-19 13:37:34 +01:00
c81e649992
fix more wayland crashes
2014-03-18 18:15:24 -04:00
c04d754ac5
enabling drm output module should NOT require X-less build.
...
these defines all need to be changed from HAVE_WAYLAND_ONLY to something like WITH_X or we're going to have lots of problems with xwayland later on
2014-03-18 16:14:04 -04:00
3d28a91c6b
@bugfix: Create window pointer for wayland clients
...
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-03-18 07:43:05 +00:00
9e68b402a4
@bugfix: Initialize the module idler even If we are wayland-only
...
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-03-18 07:43:05 +00:00
4bb1d8f390
@bugfix: Only load external compositing modules if we are wayland-only
...
@bugfix: Initialize e_comp_wl if we are wayland-only OR supporting
wayland clients.
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-03-18 07:43:05 +00:00
f3da557586
@bugfix: Fix e_win elm window trapping for wayland-only
...
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-03-18 07:43:05 +00:00
160412dcf2
Simplify e_canvas_new code slightly for wayland-only and
...
wayland-client support.
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-03-18 07:43:04 +00:00
3d10a3d34e
@bugfix: Fix pointer to work in drm and also fix some formatting
...
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-03-18 07:43:04 +00:00
915f8f0613
@bugfix: Fix building for WAYLAND_ONLY by using the proper define
...
sed -i 's/WAYLAND_ONLY/HAVE_WAYLAND_ONLY/g'
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-03-18 07:43:04 +00:00
a2025ddaad
ignore size change configurerequests during maximize if not also changing position
...
correcty fixes gtk window (un)maximize
2014-03-17 12:56:21 -04:00
d8375aaf9d
Revert "apply client resize limit for all possible size values during maximize calcs"
...
This reverts commit 08acb0c6aa
2014-03-17 12:49:44 -04:00
9859daee07
bugfix: get entry width based on viewport size, not entry size
...
things like icon properties dialog now fit on a 4k monitor
2014-03-17 12:24:03 -04:00
791ed12f7b
fix elm win usage
2014-03-14 12:38:01 -04:00
9f310291a7
don't change backlight on zone shutdown
2014-03-14 12:00:23 -04:00
Carsten Haitzler
ad6aa3db71
part of previous commit - also set delete_requested to 0
2014-03-15 00:00:27 +09:00
a6148e5e56
fix client resistance visibility check typo
...
fix T1087
2014-03-14 09:51:57 -04:00
Carsten Haitzler
b1373fe63f
fix hiding of windows when delete is requested
...
this is applicable to e19 only (you can't backport this patch as-is -
e19 is too different). this fixes T1063.
2014-03-14 16:25:14 +09:00
19f8126847
prevent fallthrough in determining gcc visibility
...
CID 1040127
2014-03-13 13:10:55 -04:00
b9cdeb17f5
add note about switch statement fallthrough
...
CID 1040128
2014-03-13 13:09:43 -04:00
4b58fa9a4e
replace ev->keyname with ev->key
...
see efl 5ae4cfd1923e502731f4d8fc2bf67b1f536a9216
2014-03-13 13:03:34 -04:00
d391e5c130
validate params for e_dnd_util_text_uri_list_convert()
...
CID 1040144
2014-03-13 12:52:36 -04:00
e0a5cd6e7d
bugfix: correctly calculate minimum flowlayout rows
...
CID 1132740
2014-03-13 12:44:47 -04:00
01abad3f64
bugfix: efm_op no longer tries to close invalid fds during delete ops
...
CID 1132741
2014-03-13 12:41:53 -04:00
b373b561e4
check X comp_data existence in pixmap PRESENT usage during refresh
...
CID 1155279
2014-03-13 12:22:04 -04:00
450d6cf321
add comments to suppress false positives in intentional switch fallthroughs
...
CIDs 1155283, 1155282, 1155281
2014-03-13 12:20:38 -04:00
c545deb81c
fix gadman resistance checking for fake/desk shelves
2014-03-13 12:15:11 -04:00
26cbbe6723
improve client positioning resistance accuracy for hidden clients and fake shelves
2014-03-13 12:12:28 -04:00
fe5f8df001
use E_CLIENT_FOREACH macro for resist calcs
...
CID 1155285
2014-03-13 12:07:49 -04:00
3f3322cb9c
null check auth current user get
...
CID 1155286
2014-03-13 12:06:04 -04:00
865dc17221
null check client on X stack request
...
CID 1155287
2014-03-13 12:05:13 -04:00
ddcc678d78
ensure va_end is called when creating new pixmaps
...
CID 1155292
2014-03-13 12:02:11 -04:00
de03331469
fix indent for iconic hint setting
...
seriously?
CID 1156985
2014-03-13 12:00:17 -04:00
537b4054d3
simplify/optimize e_win show trap
...
CID 1163853
2014-03-13 11:58:16 -04:00
6dd98df0d6
remove all remaining efl version check defines
2014-03-13 11:55:29 -04:00
d0589662c5
bugfix: check for unicode string end in client menu
...
CID 1186203
2014-03-13 11:51:21 -04:00
2b3906d8da
bugfix: don't crash when passing NULL desk to e_client_under_pointer_get
...
CID 1186204
2014-03-13 11:47:44 -04:00
dacb821f05
trivial dead code--
...
CID 1187922
2014-03-13 11:43:53 -04:00
3583d76839
trivial dead code--
...
CID 1187923
2014-03-13 11:42:49 -04:00
b8a3e1ed4f
fix probably-impossible divide-by-zero in menu item layout
...
CID 1187924
2014-03-13 11:41:17 -04:00
b25706727b
bugfix: don't iterate with or access freed pointer in comp match dialog
...
CID 1039740
2014-03-13 11:18:14 -04:00
9f3f5e29d1
bugfix: ensure use of non-garbage values for menu item icon placeholders
...
CID 1039769, 1039768
2014-03-13 11:11:14 -04:00
5f68ea5c8d
bugfix: prevent out of bounds write in e_intl_locale_parts_get()
...
CIDs 1039848, 1039847
2014-03-13 10:46:28 -04:00
8b227c33b7
Revert "e_exec - after an instance has its exe deleted - set exe to NULL"
...
This reverts commit 89fdebb9bf
2014-03-13 10:40:11 -04:00
2425ec363c
always init container coords when beginning gadcon drag
...
CIDs 1135457, 1135456
2014-03-13 10:37:01 -04:00
bf66547c15
fix null termination of client desktop string matching
...
CID 1155274
2014-03-13 10:28:33 -04:00
1abc612569
ensure valid client layers in client stack iterating functions
...
CIDs 1155288, 1155280
2014-03-13 10:27:35 -04:00
08acb0c6aa
apply client resize limit for all possible size values during maximize calcs
...
Summary:
there was a problem that the app like gnome-terminal had not been restored to origin size after maximization.
I think that's because E overwrite the data of saved.x/y to maximized size in ConfigureRequest handler.
The reason why ConfigureReuqest happen is that the window tried to resize itself properly, since E resize window without regard of size hints.
Reviewers: zmike, seoz
CC: cedric
Differential Revision: https://phab.enlightenment.org/D633
2014-03-13 10:15:13 -04:00
b137b7e741
fix use of same variable in e_desk double-loop
...
Reviewers: zmike, seoz
CC: cedric
Differential Revision: https://phab.enlightenment.org/D632
2014-03-13 09:38:11 -04:00
3f5ac7d9ab
use static array of inlists for client hooks to reduce overhead
2014-03-13 09:35:06 -04:00
ce3e7056ae
remove unused vars
2014-03-13 09:34:10 -04:00
48c28213c9
fix use of same temporary variable in for loop.
...
Summary: it caused crash when user edited desk's name after adding desk.
Reviewers: zmike, seoz
CC: cedric
Differential Revision: https://phab.enlightenment.org/D631
2014-03-13 08:46:39 -04:00
1a2f4087db
defer netwm maximize hint apply to reduce canvas ops
...
improves maximize performance on apps like chromium which incrementally apply maximize states
2014-03-10 00:27:16 -04:00
f9f6ddb971
bugfix: dim/undim actions don't require acpi triggers
...
fix T1067
2014-03-09 23:30:47 -04:00
ae81d76a3c
ignore ignored clients for X mouse events
...
fix T1058
2014-03-06 09:35:00 -05:00
8c3b7800c9
randr: TODO++
2014-03-06 15:18:15 +01:00
c0d0afad32
randr: function to apply current config
2014-03-06 15:18:14 +01:00
f6a0ec2753
randr: only activate outputs we want to connect
2014-03-06 15:18:14 +01:00
52751092f5
randr: store connection status in output
2014-03-06 15:18:14 +01:00
2e7964794b
randr: make current setup extern
2014-03-06 15:18:14 +01:00
9bd18c6272
randr: same param name in prototype and function
2014-03-06 15:18:14 +01:00
d6cec482d4
randr: don't let crtc changes change our config
2014-03-06 15:18:14 +01:00
ff750b2bb9
randr: add match for refresh rate
...
Store output config with refresh rate, so we don't just get correct
geometry for outputs.
2014-03-06 15:18:14 +01:00
f32426878c
randr: common function for fetching output name
...
Add a common function to get output name, and also check edid if no name
is set by randr.
2014-03-06 15:18:14 +01:00
82e7d1184c
randr: remember crtc in output struct
2014-03-06 15:18:14 +01:00
2b4a70b283
randr: remove wrong typedef
...
There is no struct for crtc config
2014-03-06 15:18:14 +01:00
5c6eed2307
randr: allocate hot-plugged outputs
2014-03-06 15:18:14 +01:00
11e21fd1ff
randr: allocate hot-plugged crtcs
2014-03-06 15:18:14 +01:00
8b5153130a
randr: Use already fetched root window
2014-03-06 15:18:14 +01:00
63b01101ee
fix comp util object initial visibility
2014-03-05 10:53:05 -05:00
851ef43c41
force comp render on dirty for hidden objects with visible mirrors
2014-03-05 10:08:09 -05:00
8b4162d681
fix maximization geometry on desks with shelves
...
in some cases during startup a client can get post-maximize geometry before the sizing algorithm is applied
fix T1052
2014-03-05 10:08:09 -05:00
ee6b8e8c38
simplify maximize shelf fill visibility check
2014-03-05 10:08:09 -05:00
267966834f
fix deskmirror visibility for re_manage previously-iconic clients
2014-03-05 10:08:09 -05:00
f82351d3e2
reset client urgency on focus-out and iconify
2014-03-05 10:08:09 -05:00
9ad04eb877
redo client urgency again with separate flag for actual urgent state
...
preserve icccm flag for accurate detection
2014-03-05 10:08:09 -05:00
58286beed4
e_comp_wl: Remove unused variable.
...
Later on we use state_w directly.
2014-03-05 13:41:35 +01:00
8568a76313
always set iconic client comp state as visible
...
pass: init_states
2014-03-04 15:20:24 -05:00
5241140dd2
don't run client visibility idler updates for iconic clients
2014-03-04 15:20:24 -05:00
7b44add514
redo iconic setting for new clients
2014-03-04 15:20:24 -05:00
043a3c17e0
fix some enum decls
2014-03-04 15:20:24 -05:00
Carsten Haitzler
5c8710ded3
fix screen blanking while fullscreen window is up - work again
...
@fix - this fixes T1019 - when a window is fullscreen the display just
NVER can blank no mater what. it's hrdcoded, and wrong to enforce. if
an app wants to display screensaver - there is the xscreensaver extn -
or maybe supporting an explicit property on a window would work
better, but just equating fullscreen == never blank is wrong. it's an
option now. off by default.
2014-03-01 08:04:09 +09:00
e77d536466
remove comp override immediately on screensaver disable
2014-02-28 15:27:35 -05:00
Wonguk Jeong
Chidambar Zinnoury
Carsten Haitzler
Gwanglim Lee
Mike Blumenkrantz
Seunghun Lee
Tom Hacohen
Sebastian Dransfeld
Stefan Schmidt
Chris Michael
Cedric BAIL