enlightenment/enlightenment
enlightenment
/
enlightenment
10
9
Fork 13
Code Issues 26 Pull Requests 2 Projects Releases Wiki Activity

Introduce convertible module #49

Merged
raster merged 35 commits from rafspiny/enlightenment:master into master 2024-03-12 07:20:21 -07:00
Conversation 2 Commits 35 Files Changed 16 +2 -2
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 4ea8172e51 - Show all commits

2
src/modules/convertible/dbus_acceleration.c
View File

@ -11,7 +11,7 @@
DbusAccelerometer* accelerometer_dbus;
raster commented 2023-08-02 03:50:37 -07:00
Outdated
Review
Copy Link

shouldnt accelerometer_dbus be static?

shouldnt accelerometer_dbus be static?
rafspiny commented 2023-08-23 23:49:58 -07:00
Outdated
Review
Copy Link

Made it static.

Made it static.
DbusAccelerometer*
raster commented 2023-08-02 03:07:20 -07:00
Outdated
Review
Copy Link

functions in C that take NO arguments are (void) not (). () means "i accept any number of arguments of an undefined type". :)

also some funcs are

int func(int x)
{
}

some are

int
func(int x)
{
}

with return type on previous line - be consistent and maybe do the latter?

functions in C that take NO arguments are (void) not (). () means "i accept any number of arguments of an undefined type". :) also some funcs are int func(int x) { } some are int func(int x) { } with return type on previous line - be consistent and maybe do the latter?
rafspiny commented 2023-08-02 12:46:38 -07:00
Outdated
Review
Copy Link

Corrected the linting for function to be

int
func(int x)
{
}

Also in the headers

int
func(int x);

Do we have a linting configi file somewhere? So we can get this kind of comments automatically? Like clang

Corrected the linting for function to be ``` int func(int x) { } ``` Also in the headers ``` int func(int x); ``` Do we have a linting configi file somewhere? So we can get this kind of comments automatically? Like clang
sensor_proxy_init()
sensor_proxy_init(void)
{
// Initialise DBUS component
if (accelerometer_dbus)

2
src/modules/convertible/dbus_acceleration.h
View File

@ -26,7 +26,7 @@ struct _DbusAccelerometer
/**
* Fetch the DBUS interfaces and fill the DbusAccelerometer struct
* */
DbusAccelerometer* sensor_proxy_init();
DbusAccelerometer* sensor_proxy_init(void);
rafspiny marked this conversation as resolved Outdated
raster commented 2024-01-16 04:07:45 -08:00
Outdated
Review
Copy Link

func() in c means zero OR more arguments - unknown. (void) means no arguments at all. different to c++ and other langs.

func() in c means zero OR more arguments - unknown. (void) means no arguments at all. different to c++ and other langs.
rafspiny commented 2024-01-23 13:29:19 -08:00
Outdated
Review
Copy Link

Done

Done
void
rafspiny marked this conversation as resolved Outdated
raster commented 2024-01-16 04:07:51 -08:00
Outdated
Review
Copy Link

func() in c means zero OR more arguments - unknown. (void) means no arguments at all. different to c++ and other langs.

func() in c means zero OR more arguments - unknown. (void) means no arguments at all. different to c++ and other langs.
rafspiny commented 2024-01-23 13:30:07 -08:00
Outdated
Review
Copy Link

Done

Done