503d7305db
As I've said before, I'm attached a patch for minor bugs in the e17 again.
Please take a look at attached patch.
01. missing E_FREE(wev) if zone is null
File: src/bin/e_actions.c: 1467
Function: ACT_FN_GO_EDGE macro function
null check of zone and wev, it would be better to separate them.
02. dead code
File: src/bin/e_configure.c: 338
Function: _e_configure_efreet_desktop_update
03. array buf might be overwritten by "buf[i] = '\0'"
File: src/bin/e_eap_editor.c: 412
Function: _e_desktop_edit_user_local_desktop_filename_generate
04. missing null check
File: src/bin/e_fm.c
Function: e_fm2_icon_get: 2196
It would be better to check ic->info.file in e_fm2_icon_get
before passing to _e_fm2_file_is_edje because it doesn't check
null pointer.
05. array 'path' might be overwritten by "path[i + 1] = XXX"
File: src/bin/e_fm.c: 4299
Function: _e_fm2_uri_parse
06. missing null check
File: src/bin/e_fm_device.c: 468
Function: e_fm2_device_mount_find
If the null pointer is passed to e_fm2_device_mount_find,
then it attempt to compare string using strncmp without null
check.
e.g., e_fm2_path_set
-> real_path = _e_fm2_dev_path_map: this function could return null.
-> sd->realpath = real_path;
-> e_fm2_device_mount_find(sd->realpath)
07. missing free(fstrip)
File: src/bin/e_import_config_dialog.c: 34
Function: _import_edj_gen
08. missing _module_free(cfm)
File: src/bin/e_int_config_modules.c: 530
Function: _load_modules
09. missing free(class) in for loop
File: src/bin/e_int_menus.c: 1187
Function: _e_int_menus_clients_add_by_class
10. missing free(roots)
File: src/bin/e_main.c: 1646
Function: _e_main_screens_init
Actually only e_win_init function could return 0.
But I've added free to other codes for the consistency.
11. missing null check of 'es->cfg'
File: src/bin/e_shelf.c: 2583
Function: _e_shelf_bindings_add
'es->cfg' might be null. please look at e_shelf_position_calc.
12. no ect->category check before comparing string values
File: src/bin/e_theme.c: 387
Function: e_theme_config_remove
I'm not sure, but inner if block checks ect->category before
deleting a string.
13. missing E_FREE(wcb) in while loop
File: src/bin/e_widget_ilist.c: 146
Function: _queue_timer
14. dereferencing freed pointer 'entry'
File: src/modules/quickaccess/e_mod_quickaccess.c: 583
Function: _e_qa_event_border_remove_cb
15. missing E_FREE(trov)
File: src/modules/tiling/e_mod_tiling.c: 3106
Function: _do_transition_overlay
Thanks & Regards,
Gwanglim
SVN revision: 80231
|
||
|---|---|---|
| config | ||
| data | ||
| doc | ||
| m4 | ||
| po | ||
| src | ||
| .gitignore | ||
| AUTHORS | ||
| BUGS | ||
| COPYING | ||
| ChangeLog | ||
| INSTALL | ||
| Makefile.am | ||
| NEWS | ||
| README | ||
| autogen.sh | ||
| configure.ac | ||
| enlightenment.pc.in | ||
| enlightenment.spec.in | ||
| netwm.txt | ||
| x-ui.sh | ||
| xdebug.sh | ||
README
Enlightenment 0.17.0 - IN DEVELOPMENT... not a RELEASE. Requirements: ------------- Must: libc libm libX11 libXext evas ecore ecore-evas ecore-file ecore-ipc ecore-con ecore-job ecore-imf ecore-img-evas edje eet embryo efreet efreet-mime edbus ecore-txt [png loader in evas, jpeg loader in evas, eet loader in evas, software_x11 engine in evas, buffer engine in evas] Recommended: libpam [xrender engine in evas] NOTE: Users of DR16 will need to rename the $prefix/bin/enlightenment file prior to installing DR17 or it will be overwritten. You can also use the configure --prefix option to put e17 in a separate tree of its own (recommended) like: ./configure --prefix=/usr/local/e17 You will, as usual need to add the subsequent bin dir to your $PATH etc. NOTES: * do NOT use -mfpmath=sse in CFLAGS - we are not sure, but it may have bugds and screws up things in edje, evas and e17. if your gcc uses this by default (which apparently gcc4.x does on amd64), turn it off with a -fpmath=387 in your CFLAGS. * your freetype2 version must be > 2.1.7 * i remember hearing of bugs with later versions of freetype on some distributions (2.1.9 and 2.1.10) with certain patches or missing certain patches. be aware of this as a possible font problem. * if you do not want security issues make sure sysactions.conf is in /etc/enlightenment (not PREFIX/etc/enlightenment) as this is the first place it looks at. This file is intended to be customized by packagers and system integrators to match your policies and scripts/tools.