8441520030
Summary: Many of the functions in the compositor do some preliminary checks, to ensure objects are valid and the right type. Most of the checks follow a consistent pattern, for example: if (!(ec = data)) return; if (e_object_is_del(E_OBJECT(ec))) return; if (ec->iconic) return; This style makes it pretty straightforward to review the pre-conditions of the function. The one exception is the check to see if an object is a wayland pixmap; this is implemented as a C macro. E_COMP_WL_PIXMAP_CHECK; The name of the macro is descriptive enough, but it conceals what is actually being checked. I think that it is clearer and fits better with the style of the rest of the pre-condition checks for this check to just be shown as regular C code: if (e_pixmap_type_get(ec->pixmap) != E_PIXMAP_TYPE_WL) return; Reviewers: zmike, cedric, devilhorns Reviewed By: devilhorns Subscribers: cedric Differential Revision: https://phab.enlightenment.org/D2066 |
||
---|---|---|
.. | ||
bin | ||
modules | ||
tests | ||
Makefile.mk |