The focused_item could be invalid if the enventor item is removed before seting it null.
Also, the previous warning is no more invalid because
it was introduced by unsafe threads workers that was already fixed before.
Summary:
when the item of file tab which is in out of file tab view needs to be shown,
It should be moved into the file tab view
Test Plan:
1. launch enventor with multi-file supports
2. add item fully to the file tab
3. click next arrow in file tab and move the selection item
4. when selection item reached end of file tab
5. check the next item which is out of file tab view comes into the file tab view
Reviewers: Hermet, Jaehyun_Cho, NikaWhite, bowonryu
Differential Revision: https://phab.enlightenment.org/D4242
Summary:
move hte functions in utils which are find_part and find_group to the edc_parser
since it is right way
Test Plan:
1. launch enventor
2. move cursor on part name in text view
3. press F3 key
4. check it works well
Reviewers: Jaehyun_Cho, NikaWhite, bowonryu, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D4240
Summary:
fix the selection function of console error message,
it was behavior broken since there is markup text in console message.
so I fixed it work well.
Test Plan:
1. launch enventor
2. make some error in text view
3. save
4. check the selection region in text view
Reviewers: Hermet, Jaehyun_Cho, NikaWhite, bowonryu
Differential Revision: https://phab.enlightenment.org/D4239
This fixes the wireframe issue that deactivated views' wireframes are appeared
when the file is updated.
This is only happened if edc collections is consisted with multiple edc files.
If edj file is updated, all generated views will be updated.
and wireframes will be also updated and appeared.
but we don't need to update the deactivated views even if the edj is
updated. we could this with an activated boolean and this will be much
optimized way for many generated views.
Summary: disable focus for resize slider bar
Test Plan:
1. launch enventor
2. show resize ctxpopup using status bar
3. check the focus is disable
Reviewers: Hermet, Jaehyun_Cho, NikaWhite, bowonryu
Differential Revision: https://phab.enlightenment.org/D4232
Summary: add the new feature to jump to the part define
Test Plan:
1. launch enventor
2. click mouse right button on "relative to" part name in text view
3. check selection is on the part define
Reviewers: Hermet, NikaWhite, bowonryu, Jaehyun_Cho
Reviewed By: Jaehyun_Cho
Tags: #enventor
Differential Revision: https://phab.enlightenment.org/D4167
change the geometry of highlight to its common geometry,
not actual text area.
This change is for consistency for wireframes,
and I expect user want it.
Summary: restore resize and move callabck for layout
Test Plan:
1. launch enventor
2. open a basic edc
3. add spacer part
4. turn on wireframe
5. resize the view
6. see the result of wireframe
Reviewers: Jaehyun_Cho, NikaWhite, bowonryu, Hermet
Differential Revision: https://phab.enlightenment.org/D4216
Conflicts:
src/lib/wireframes_obj.c
When list item's close button is clicked, this selection is triggered
prior to the close button clicked callback.
It's useless to perform this selected callback anyway this file tab
item is gonna removed soon. But, due to the list's behavior,
it's unavoidable so we need this tricky animator.
Hermet Park
Jaehyun Cho
Bowon Ryu
Taehyub Kim