Commit Graph

22 Commits

Author SHA1 Message Date
Hermet Park 265626a86b fix a invalid memoray access.
The focused_item could be invalid if the enventor item is removed before seting it null.
Also, the previous warning is no more invalid because
it was introduced by unsafe threads workers that was already fixed before.
2016-08-19 16:24:16 +09:00
Bowon Ryu c5a606e090 file_tab: update themes.
Summary:
update icon,
close button re-location.

Test Plan:
1. launch enventor with multi-file supports.
2. add items to file_tab
3. observe file_tab items.

Reviewers: Hermet, Jaehyun_Cho, herb

Differential Revision: https://phab.enlightenment.org/D4243
2016-08-19 13:05:34 +09:00
Taehyub Kim 6d109cf27a file_tab: add 'bring in' feature for the item out of file tab
Summary:
when the item of file tab which is in out of file tab view needs to be shown,
It should be moved into the file tab view

Test Plan:
1. launch enventor with multi-file supports
2. add item fully to the file tab
3. click next arrow in file tab and move the selection item
4. when selection item reached end of file tab
5. check the next item which is out of file tab view comes into the file tab view

Reviewers: Hermet, Jaehyun_Cho, NikaWhite, bowonryu

Differential Revision: https://phab.enlightenment.org/D4242
2016-08-19 12:59:06 +09:00
Hermet Park a2db164533 file_tab: avoid unnecessary selection behavior.
When list item's close button is clicked, this selection is triggered
prior to the close button clicked callback.
It's useless to perform this selected callback anyway this file tab
item is gonna removed soon. But, due to the list's behavior,
it's unavoidable so we need this tricky animator.
2016-08-12 10:29:53 +09:00
Hermet Park 65267ba2fd file tab: stablizing file switching behavior.
There are still corner case bugs.

one is issued by unsafe thread working
and the other one is group switching.

fixed all in all.
2016-08-12 04:00:17 +09:00
Hermet Park a281963ba1 sanitize compare file pathes.
let's have a full pathes for enventor items.
then we don't need to call ecore_file_realpath() at every accesses.
2016-08-09 01:02:46 +09:00
Hermet Park b3afcc4810 file_browser: stabilizing switching main edc file function. 2016-08-08 23:58:08 +09:00
Hermet Park b987e70045 fix memory leaks. 2016-08-04 23:48:50 +09:00
Hermet Park d57b173d39 file_tab: actually, list item allows to use tooltip. 2016-08-03 18:34:48 +09:00
Hermet Park 98e833ef37 file_tab: support full path tooltip info. 2016-08-03 18:30:49 +09:00
Hermet Park 96c767611b file_tab: fix a crash issue.
when user close a non selected file tab item,
Enventor occasionaly has a crash.
As investested, it seemed like an EFL issue.
But we can easily fix this by moving the function call.
2016-08-03 00:55:40 +09:00
Hermet Park e2506983ad file_tab: free item memory properly.
when file tab is terminated, free used memory.
2016-07-06 15:04:47 +09:00
Hermet Park 0176bda440 file_tab: fix invalid memory access.
list item selected callback passed file tab item, not file data!
2016-07-06 14:49:41 +09:00
Hermet Park 5b00b70fc2 file_tab: ++implementation.
allow remove item from the tab.
2016-07-04 22:17:38 +09:00
Hermet Park 68548afdde multi-file: support the function, go to line.
removed enventor_object_max_line_get()
removed enventor_object_goto_line()
added enventor_item_max_line_get()
added enventor_item_goto_line()
2016-07-02 15:39:10 +09:00
Hermet Park 731d0bed5b ++secure code. 2016-07-01 18:58:26 +09:00
Hermet Park 8c13d63a8e ++ multi file support. 2016-07-01 18:24:14 +09:00
Hermet Park f0623301d9 file_browser/file_tab: ++ multi file support implementaion 2016-06-30 16:50:20 +09:00
Hermet Park c8749390d8 file_tab: ++implementation. 2016-06-30 00:52:13 +09:00
Hermet Park 247c1e67ae file_tab: use customed list for file tab. 2016-06-29 23:29:37 +09:00
Hermet Park 5140ab5c64 code refactoring.
add a common memory fail message routine to reduce string usage.
2016-06-29 20:41:39 +09:00
Hermet Park e61cfb6124 file_tab: add a partial implmentation. 2016-06-29 20:28:11 +09:00