fix a side effect of localizing floats.
_posix_fp() uses static stringbuffer.
If this function is called multiple times in printf(),
previous buffer data will be invalid.
we are calling this for x, y twice in one func.
Summary:
Enventor live edit would generate invalid code with
the french locale.
Indeed, french uses a comma (",") as the decimal point,
instead of the dot. With localization enabled, printf()
would automatically localized the floating point,
introducing a comma in the edje code where a dot is
expected...
To avoid this, we now enclose the floats we don't want
to be localized (use the implicit POSIX local: with a dot)
in a function that looks the current locale and replace
the decimal point with a dot.
Test Plan:
(1) Without the patch, call LC_ALL=C enventor and see live
edit if correct.
(2) Without the patch, call LC_ALL=fr_FR.UTF-8 envetor and
see live edit generate invalid edje code.
(3) Apply the patch, and repeat steps (1) and (2) and observe
that both cases now success.
Reviewers: Hermet
Differential Revision: https://phab.enlightenment.org/D4146
Previously, template code was inserted before the closing bracket.
Now, template code is inserted after the closing bracket.
Test Plan
1. Open basic.edc.
2. Put mouse cursor the end of the line 18.
3. Press Ctrl + t to insert template code of image part.
Previously, line count was not correct after textblock part is inserted
in live edit mode.
Now, line count is correctly calculated after textblock part is inserted
in live edit mode.
Test Plan
1. Insert textblock part in live edit mode.
2. Check max line number.
Summary:
fix the fixed condifion for relative_to.
the condition was wrong, so I fixed it.
Test Plan:
1. Launch Enventor
2. Click a Live Edit Item
3. Check fixed_w and fixed_h
4. Insert the Live Edit Item
Reviewers: Hermet, Jaehyun_Cho, NikaWhite
Differential Revision: https://phab.enlightenment.org/D3943
Summary:
Add new interface feature about setting relative_to to make relationship esaily
between part and part. Now, we can make the relationship using just mouse interface.
Test Plan:
1. launch enventor
2. add live edit item using live edit toolbar
3. drag the item to the another part
4. move a control point that you want to make a relationship to the another part edge
5. and then relative_to ctxpopup is shown
6. select the relative_to item in the ctxpopup
7. insert the live edit item with double click
8. check the inserted code whether it is make relationship or not
Reviewers: Jaehyun_Cho, NikaWhite, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D3936
Summary:
fix the error operation of group template insertion.
The line position would be broken after inserting group template.
so I fixed it.
Test Plan:
1. launch enventor
2. insert group template using Ctrl + T
3. check the line position of source code whether it is corrected or not
Reviewers: Hermet, Jaehyun_Cho, NikaWhite
Differential Revision: https://phab.enlightenment.org/D3908
Summary:
before, we cannot move the live edit item using direction key.
now we can modify it using direction key.
@T3356
Test Plan:
1. launch enventor
2. insert a live edit item
3. move the item using direction key
Reviewers: Jaehyun_Cho, NikaWhite, Hermet
Differential Revision: https://phab.enlightenment.org/D3862
Summary:
when we insert image template or live view item,
the template code of image resource will be duplicated.
so, I added the code checking template image resource not to be duplicate
Test Plan:
1. launch enventor
2. add image part twice using ctrl + t or live view item
3. see the images block has an ENVENTOR_EMBEDDED_LOGO.png
Reviewers: Hermet, Jaehyun_Cho, NikaWhite
Differential Revision: https://phab.enlightenment.org/D3851
Summary:
Current generated part name from the live edit is too unfamiliar with users.
We need to improve for more formal naming rule like,
ex) rect_xxxx
image_xxxx
swallow_xxxx
Test Plan:
1. Open Enventor
2. Add rect, image, swllow, text, textblock, spacer
Reviewers: Hermet, Jaehyun_Cho
Reviewed By: Jaehyun_Cho
Subscribers: Jaehyun_Cho, Hermet
Differential Revision: https://phab.enlightenment.org/D3793
Summary:
select the random name after inserting live view part or template part.
Test Plan:
1. insert a part using Live View
2. see the selection region of random name of Live View
3. insert a templte using Ctrl + t
4. see the selection region of random name of template
@T3014
Reviewers: Hermet, Jaehyun_Cho, NikaWhite
Differential Revision: https://phab.enlightenment.org/D3743
Summary:
There is a memorizing cursor in wrong position, it cause undo error.
If insert the description template, undo operation is not working correctly.
@fix
Test Plan:
1. press ctrl + t in the part, then insert description part
2. press ctrl + z, undo the code
3. see the normal operation
Reviewers: Hermet, Jaehyun_Cho, NikaWhite
Differential Revision: https://phab.enlightenment.org/D3760
Set edc changed in template_insert() to save template insertion.
Test Plan:
1. write a part. (e.g. rect { "rect2";)
2. insert desc template (ctrl + t)
2. close edc
When edc is closed without saving after inserting template, warning
popup should appear.
Summary: make group, description and program tempalte code compilable
Test Plan:
1. insert template code using ctrl + t
2. see the name of the template and checkt the compile error.
Reviewers: Jaehyun_Cho, Hermet
Subscribers: NikaWhite
Differential Revision: https://phab.enlightenment.org/D3613
Since LazEDC block types were not recognized for template insertion,
inserted template type inside LazEDC block was not correct.
(e.g. inside desc { })
Now LazEDC block types are considered for template insertion by Ctrl+T.
Enable to insert image description and textblock style when image part and
textblock part are inserted.
Previously, those are inserted only if parts are inserted by the live edit.
Hermet Park
Jean Guyomarc'h
Bowon Ryu
Jaehyun Cho
Jaehyun Cho
Taehyub Kim
Yongheon, Shin
Mykyta Biliavskyi
Michelle Legrand
ChunEon Park