Summary:
if grammatically incorrect EDC file is opened, then
Undo causes error caution (with red alert) even though
there is no Undo action.
Test Plan:
1. Make incorrect EDC file. (e.g. Write "aaaa" in EDC file incorrectly)
2. Save the wrong EDC file.
3. Newly open the wrong EDC file.
4. press Undo button and it causes error caution.
Reviewers: Hermet, Jaehyun_Cho
Reviewed By: Jaehyun_Cho
Differential Revision: https://phab.enlightenment.org/D4118
Summary:
When we add a live edit item, it is convenient to be support part outline.
so I added part outline feature. It can be toggling.
@T3626
Test Plan:
1. launch enventor
2. activate parts outline item on tools
3. see the parts outline in live edit view
Reviewers: Hermet, NikaWhite, bowonryu, Jaehyun_Cho
Reviewed By: Jaehyun_Cho
Differential Revision: https://phab.enlightenment.org/D4071
Summary: change the description of fixed mode
Test Plan:
1. click a live edit item on tools
2. see the description of fixed mode in live view
Reviewers: Jaehyun_Cho, NikaWhite, bowonryu, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D4106
Summary: change the description of build setting
Test Plan:
1. show the build setting
2. see the path title
Reviewers: Hermet, Jaehyun_Cho, NikaWhite, bowonryu
Differential Revision: https://phab.enlightenment.org/D4105
Summary: change the descrtipion for the tools for live edit mode
Test Plan:
1. move the mouse cursor on part highlighting, dummy parts and mirror mode tools
2. see the tooltip messages
Reviewers: Jaehyun_Cho, NikaWhite, bowonryu, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D4103
Summary: change the description
Test Plan:
1. Open basic.edc template
2. remove the annotation of program part
3. Show EDC Navigator
4. move the mouse cursor on the button of Program which have rectangle icon.
5. move the mouse cursor on the button of program which have triangle icon.
6. see the each tooltip messages.
Reviewers: Jaehyun_Cho, NikaWhite, bowonryu, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D4102
Summary: change the description
Test Plan:
1. open setting menue
2. move the mouse cursor on View Size, Auto Hiding Console, Smart Undo/Redo and Error Message Alert
3. see the tooltip messages
Reviewers: Jaehyun_Cho, NikaWhite, bowonryu, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D4099
Summary: change the description of window layout
Test Plan:
1. move the mouse cursor on EDC Navigator and Status item of tools
2. see the tooltip messages
Reviewers: Hermet, Jaehyun_Cho, NikaWhite, bowonryu
Differential Revision: https://phab.enlightenment.org/D4098
Summary: change the description
Test Plan:
1. move the mouse cursor on each statusbar item
(Resize, Swap and Group)
2. see the tooltip messages
Reviewers: Hermet, Jaehyun_Cho, NikaWhite, bowonryu
Differential Revision: https://phab.enlightenment.org/D4097
Summary: change the description
Test Plan:
1. move the mouse cursor on each live edit item
2. see the tooltip messages
Reviewers: Hermet, NikaWhite, Jaehyun_Cho, bowonryu
Differential Revision: https://phab.enlightenment.org/D4095
Summary: change the description
Test Plan:
1. toggle dummy parts, mirror mode and parth highlighting
2. see the result
Reviewers: Jaehyun_Cho, NikaWhite, bowonryu, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D4094
Added a toggle option in setting.
and replaced the status shortcut key to F8 from F11.
Now, tools shortcut key is moved to F7.
This change is such a pre-requisition for a file tab feature.
Summary: change the description
Test Plan:
1. input some text into text view
2. click x button of enventor window
3. see the popup message
Reviewers: Jaehyun_Cho, NikaWhite, bowonryu, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D4092
Summary: change the description
Test Plan:
1. open search window
2. see the text
Reviewers: Jaehyun_Cho, NikaWhite, bowonryu, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D4090
Summary:
the line is over than 80 character.
@fix
Reviewers: Hermet, Jaehyun_Cho, NikaWhite
Differential Revision: https://phab.enlightenment.org/D4083
Summary:
ux update for text setting.
add dec & inc buttons and spinner for font_size slider.
Test Plan: esc > settings > text editor
Reviewers: Hermet, Jaehyun_Cho
Reviewed By: Jaehyun_Cho
Differential Revision: https://phab.enlightenment.org/D4057
Summary:
When we search the word or click part in live edit view and edc navigator,
The corresponding name in text view is selected, but it is not center align.
So I make it center align when the word is selected.
@T3326
Test Plan:
1. launch enventor
2. open search window
3. input any word in script
4. click ok forward button
5. check selection part if it is placed in center
6. click a part in live edit view
7. check selection part if it is placed in center
8. click a part name in edc navigator
9. check selection part if it is placed in center
Reviewers: Hermet, Jaehyun_Cho, NikaWhite, bowonryu
Differential Revision: https://phab.enlightenment.org/D4059
Summary:
There are some hole cases.
For example, if we want to input fixed part
then we had to check fixed option first.
but now, we can input fixed part in any order.
In addition, Unnecessary codes are removed
and added more comments.
Test Plan:
1. launch envnetor.
2. make a live edit item by clicking live edit item on tools.
3. set relatives for the live edit item.
4. double click and insert the item.
5. see the result.
Reviewers: Jaehyun_Cho, NikaWhite, bowonryu, Hermet
Differential Revision: https://phab.enlightenment.org/D4047
ECORE_GETOPT_STORE_METAVAR_STR() prints additional information such as
"TYPE: STR".
Not to print "TYPE: STR", ECORE_GETOPT_APPEND_METAVAR() is used for
workspace path option.
Workspace path option did not work because option type was changed
incorrectly.
Now the option type has been changed from list strings to one string
correctly.
Summary: add build setting tooltip messeges
Test Plan:
1. launch enventor
2. go settign menu
3. click EDC build tab
4. move mouse cursor on each item
5. see the tooltip messeges
Reviewers: Hermet, Jaehyun_Cho, NikaWhite
Differential Revision: https://phab.enlightenment.org/D4034
Summary: add more comments for preference
Test Plan:
1. launch enventor
2. move mouse cursor on preference of setting
3. see the tooltip messeges
Reviewers: Hermet, Jaehyun_Cho, NikaWhite
Differential Revision: https://phab.enlightenment.org/D4033
Summary: add more comments for statusbar tooltip
Test Plan:
1. launch enventor
2. move mouse cursor on statusar tooltips
3. see the message of tooltips
Reviewers: Hermet, Jaehyun_Cho, NikaWhite
Differential Revision: https://phab.enlightenment.org/D4032
Summary: add more comment for broswer tooltips
Test Plan:
1. launch enventor
2. move mouse curor on broswer tooltips
3. see the message of tooltips
Reviewers: Hermet, Jaehyun_Cho, NikaWhite
Differential Revision: https://phab.enlightenment.org/D4031
Summary: add more comment of script tooltips
Test Plan:
1. launch enventor
2. move mouse cursor on script tooltip
3. see the message of tooltips
Reviewers: Hermet, Jaehyun_Cho, NikaWhite
Reviewed By: NikaWhite
Differential Revision: https://phab.enlightenment.org/D4030
Previously, autocomp list moved to selected part name position because
autocomp list did not disappear when mouse down event occurred.
Now, an event rectangle is added to catch mouse down event and autocomp
list disappears when mouse down event occurs.
@fix T3738
Previously, part highlighting worked if part highlighting button is
clicked or enventor window moves during live edit mode.
Now, part highlighting does not work during live edit mode.
@fix T3653
Previously, part highlighting worked if part highlighting button is
clicked or enventor window moves during live edit mode.
Now, part highlighting does not work during live edit mode.
@fix T3653
if image string is in comments, image shouldn't be appeared.
but edc parser didn't compares texts elaborately and it came out error.
now fixed it.
@fix T3740
when user press a part on the live view, the part name compareing is triggered.
in that sequence, cursor is jump onto the part wrt clicked part.
since, however, the string compare is not enough
the cursor could go on other part which has a similar name.
now compare them in detail to correct this
@fix T3736
Since enventor allowed user to touch outer of editor while its ctxpopup is activated,
the context could be broken.
Block whole area and prevent the context break.
@fix T3752
Previously, template code was inserted before the closing bracket.
Now, template code is inserted after the closing bracket.
Test Plan
1. Open basic.edc.
2. Put mouse cursor the end of the line 18.
3. Press Ctrl + t to insert template code of image part.
Previously, line count was not correct after textblock part is inserted
in live edit mode.
Now, line count is correctly calculated after textblock part is inserted
in live edit mode.
Test Plan
1. Insert textblock part in live edit mode.
2. Check max line number.
Summary:
live_edit: when the live edit item's width and height are fixed,
the size of live edit item should be fixed.
Test Plan:
1. launch enventor
2. click a live edit item
3. check all of fixed options
4. do not set relative_to options
5. insert the live edit item to the live view
6. check the inserted item's size whether it is fixed or not
Reviewers: Hermet, Jaehyun_Cho, NikaWhite
Differential Revision: https://phab.enlightenment.org/D3976
Summary: add control toggle key for enabling and disabling auto align
Test Plan:
1. launch enventor
2. click a live edit item using toolbar item
3. move the item to the another part
4. press control key when the item is close to the another part
5. check auto align function whether it is disabled or not
Reviewers: Jaehyun_Cho, NikaWhite, Hermet
Differential Revision: https://phab.enlightenment.org/D3931
Previously, current font name was not visible because scroller of font
name did not move to the current font name list item.
Now, current font name is visible.
Summary:
Enventor window stops responding on double clicking "min" on Windows.
Because of approaching the index in which the cur_context doesn't exist, the crash happens.
*cur_context[] in parser_attribute_get() edc_parser.c
Test Plan:
1. launch enventor on Windows
2. add image using live edit
3. double click "min" on editor
@TSAM-3524
Reviewers: Jaehyun_Cho, Hermet
Differential Revision: https://phab.enlightenment.org/D3972
Summary: update fixed width and height interface to choose easier
Test Plan:
1. launch enventor
2. make live edit item by clicking live edit toolbar
3. click fixed width or fixed height check item on setting interface in live edit view
4. set relative_to property by dragging the edge of the part
5. insert the live edit item
6. check the result in text view
Reviewers: Jaehyun_Cho, NikaWhite, Hermet
Differential Revision: https://phab.enlightenment.org/D3962
now enventor object is nothing more than just eo interface.
actual contents are totally moved on items.
we use item interfaces to figure their zones for mouse wheel events.
Summary:
if we move a live edit item by direction key, sometimes pixel is increased by 2 pixels.
so I modified it is increaed by 1 pixed when the scale is larger than 1.0
Test Plan:
1. launch enventor
2. click a live edit item using toolbar
3. move the live edit item by direction key
4. check the change of pixel info
@T3473
Reviewers: Jaehyun_Cho, NikaWhite, Hermet
Differential Revision: https://phab.enlightenment.org/D3946
Summary:
toolbox object is not used anyware, so I remove it
@fix
Reviewers: Hermet, Jaehyun_Cho, NikaWhite
Differential Revision: https://phab.enlightenment.org/D3964
spacer margin should be removed from the image
because live edit needs accruate pixel control.
on the other hands, spacer button icon needs margin.
this implementation is a little tricky but i have no idea better than this.
Summary: update live edit item when view is resized
Test Plan:
1. add a live edit item on live view
2. resize the live view using resize item on statusbar
3. see live edit item is resing well
Reviewers: Hermet, NikaWhite, Jaehyun_Cho
Reviewed By: Jaehyun_Cho
Differential Revision: https://phab.enlightenment.org/D3940
Summary:
fix the fixed condifion for relative_to.
the condition was wrong, so I fixed it.
Test Plan:
1. Launch Enventor
2. Click a Live Edit Item
3. Check fixed_w and fixed_h
4. Insert the Live Edit Item
Reviewers: Hermet, Jaehyun_Cho, NikaWhite
Differential Revision: https://phab.enlightenment.org/D3943
Summary:
When we apply mirror mode, we need to considering swap relative_to,
but exist code was not checking null pointer.
so I fixed the logic.
Test Plan:
1. Launch Enventor
2. Apply Mirror Mode
3. Insert a live edit item with relative_set setting
Reviewers: Hermet, Jaehyun_Cho, NikaWhite
Differential Revision: https://phab.enlightenment.org/D3942
Summary:
Add new interface feature about setting relative_to to make relationship esaily
between part and part. Now, we can make the relationship using just mouse interface.
Test Plan:
1. launch enventor
2. add live edit item using live edit toolbar
3. drag the item to the another part
4. move a control point that you want to make a relationship to the another part edge
5. and then relative_to ctxpopup is shown
6. select the relative_to item in the ctxpopup
7. insert the live edit item with double click
8. check the inserted code whether it is make relationship or not
Reviewers: Jaehyun_Cho, NikaWhite, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D3936
Now tools are divided into live view tools and text editor tools based
on their functions.
Region for file browser tools and edc navigator tools is also reserved.
remove unnecessary edc usage.
and don't surprise even though refresh button generation is wierd.
That is about genlist bug and will be fixed there soon.
This was introduced from previous patches.
Now initialization point of edit_data is next to the efl lib initialization.
This broke this and now i fixed this with dispatching way.
If a search word is input, then files which contain the search word in
their file names are displayed.
To show file icons clearly in search mode, file icon images of file
browser are modified.
@T3579
Summary:
when we are layouting using live edit item,
It is hart to align the inserting item among the exist parts.
so add auto align feature to align easily.
Test Plan:
1. launch enventor
2. add a live item using the toolbar
3. move and resize the live item in live view
4. check the auto align function when the item near another part
Reviewers: Jaehyun_Cho, NikaWhite, Hermet
Differential Revision: https://phab.enlightenment.org/D3884
Previously, file browser expands all directory hierarchy.
Now, file browser expands current directory only.
Moreover, directory's sub file data is created when the directory is
expanded to support deep directory hierarchy.
By default, file browser shows resource type files only such as edc,
image, sound, and font type files.
If the "Show All Files" check is on, then file browser shows all types
of files.
@T3390
Next image word selection was broken.
so, the selection was a little twisted.
It seems something has been changed in entry.
Anyhow, it's fixed in enventor side. :(
@fix T3258
Previously, if '{' and '}' appear right after multi line comment,
the indent depth for those brackets was not calculated.
Now indent depth for those brackets is calculated correctly.
Test Plan:
1. Launch enventor.
2. Insert a group template. (Ctrl + T after collections)
3. Save the modified EDC.
4. Load the modified EDC.
Summary:
fix the error operation of group template insertion.
The line position would be broken after inserting group template.
so I fixed it.
Test Plan:
1. launch enventor
2. insert group template using Ctrl + T
3. check the line position of source code whether it is corrected or not
Reviewers: Hermet, Jaehyun_Cho, NikaWhite
Differential Revision: https://phab.enlightenment.org/D3908
Summary:
before, we cannot move the live edit item using direction key.
now we can modify it using direction key.
@T3356
Test Plan:
1. launch enventor
2. insert a live edit item
3. move the item using direction key
Reviewers: Jaehyun_Cho, NikaWhite, Hermet
Differential Revision: https://phab.enlightenment.org/D3862
File browser shows workspace directory and its sub files.
Workspace directory is set with argument "-w" and directory path.
(e.g. enventor -w ./workspace)
This commit implements T3389.
Manage text blocks, that used for autocomplete feature.
This commit make possible to undo or redo whole block of text
including user input. For example: user types "col"
and choose "collections" from ctxpopup. In normal mode
of undoredo module in case of undo action will be left
"col" text. In smart mode whole block "collections" will be deleted.
Summary:
when we insert image template or live view item,
the template code of image resource will be duplicated.
so, I added the code checking template image resource not to be duplicate
Test Plan:
1. launch enventor
2. add image part twice using ctrl + t or live view item
3. see the images block has an ENVENTOR_EMBEDDED_LOGO.png
Reviewers: Hermet, Jaehyun_Cho, NikaWhite
Differential Revision: https://phab.enlightenment.org/D3851
Summary:
Actually it is unnecessary error log below the first line.
so I skipped the log
Test Plan:
1. launch enventor
2. make an error
3. see the console log in single line
Reviewers: Jaehyun_Cho, NikaWhite, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D3845
Summary:
When mirror mode is toggled, the position of spacer parts in preview is not changed.
So I added the code to update spacer parts.
@T3367
Test Plan:
1. laucnch enventor
2. added the spacer to preview
3. toggle mirror mode more than two times.
4. see the spacer parts whether it is updated or not
Reviewers: Hermet, Jaehyun_Cho, NikaWhite
Differential Revision: https://phab.enlightenment.org/D3835
Summary:
when mirror mode is applied, the live edit item is added to wrong position.
so I added mirror mode checking to show correctly.
@T3368
Test Plan:
1. launcher enventor
2. enable mirror mode
3. add a live edit item to preview
4. check that the position of the item is right
Reviewers: Hermet, Jaehyun_Cho, NikaWhite
Differential Revision: https://phab.enlightenment.org/D3834
Summary: Added new toolbar item to support mirror mode
Test Plan:
1. luanch enventor
2. toggle mirror mode item of toolbar at the left-top or press ctrl + M
3. see the mirror mode working well
Reviewers: Jaehyun_Cho, NikaWhite, Hermet
Differential Revision: https://phab.enlightenment.org/D3813
Summary:
If we input the quotation mark("), the code under the mark are changed to gray.
so I changed the limitation from the start of quotation mark to the end of the line.
Test Plan:
1. launch enventor
2. input the quotation mark(") in the middle of the code
3. see the syntax color change range about string syntax color
Reviewers: Jaehyun_Cho, NikaWhite, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D3825
Check if edj file set is finished and do not call edje_edit functions if
edj file set is not finished.
Test Plan:
1. Open edc
2. Modify edc incorrectly (e.g. Remove semicolon)
3. Save edc
4. Open the saved edc
5. Mouse double click "target" in program.
Summary:
In my opinion, the solution can move the position of update_edj_file_internal(vd) in update_edj_file.
However, I added dummy_obj_update only above failure case of edj load.
Test Plan:
1. Run Enventor and Load basic edc file
2. Select all source code with Ctrl+A and remove them with del or backspace.
3. Check the dummy part
Reviewers: Jaehyun_Cho, Hermet
Subscribers: Jaehyun_Cho, Hermet
Differential Revision: https://phab.enlightenment.org/D3808
Summary:
improve the image's template code.
when inserting image's template code,
images block has redundant annotation.
Test Plan:
1. insert image's part using ctrl + t
2. see the images part and check the difference with before
Reviewers: Hermet, Jaehyun_Cho, NikaWhite
Differential Revision: https://phab.enlightenment.org/D3814
Hermet Park
Bowon Ryu
Taehyub Kim
Jaehyun Cho
Jaehyun Cho
Mykyta Biliavskyi
Yongheon, Shin