Summary:
selection region recovery is applied twice in entry recover.
there are selection region recovery logic before elm_entry_selection_region_set,
but we also recover using elm_entry_selection_region_set.
it is unncessary code.
@fix
Reviewers: Hermet, Jaehyun_Cho, NikaWhite
Differential Revision: https://phab.enlightenment.org/D3709
Do not insert a new line after '{', '}', ';' if it is within macro.
<Test Case>
1. Copy the following in edc.
"#define FN_COL_DEFAULT 255 255 255 255; color3: 0 0 0 128"
2. Paste
<Test Result>
Previously, a new line is inserted after ';' within the macro.
Now, the same text with the copied text is pasted.
<Test Case>
1. Copy the following in basic.edc.
"/* TODO: Please replace embedded image files to your application image files. */
images {"
2. Paste
<Test Result>
Previously, the new line between line comment and code disappears.
Now, the new line between line comment and code is preserved.
If copied code lines are in the separate lines, then paste those code
lines in the separate lines.
<Test Case>
1. Copy the following in edc.
"TILED_HORIZ(120)
visible: 0;"
2. Paste
<Test Result>
Previously, those code lines are pasted in the same line.
Now, those code lines are pasted in the separate lines like original
code lines.
<Test Case>
1. Copy "group { "main";" in basic.edc.
2. Paste
<Test Result>
Previously, a new line is inserted between "group {" and ""main";".
Now, the copied text is pasted.
Summary:
There is a delay for getting selection start position.
It cause the wrong selection recovery.
so I modified the selection recover logic
using the selection region of entry.
@fix
Reviewers: Hermet, Jaehyun_Cho, NikaWhite
Differential Revision: https://phab.enlightenment.org/D3680
Summary: select error word when error is occured
Test Plan:
1. make some error in edc script
2. press ctrl + s
3. see the selection region of error word
Reviewers: Hermet, Jaehyun_Cho, NikaWhite
Differential Revision: https://phab.enlightenment.org/D3681
Lexeme for insert indentation ends with comment line as well.
So a new line is inserted after comment line.
Lexeme for insert indentation does not end with '{' if block name is
written after the bracket.
So a new line is not inserted between '{' and block name.
Summary:
When there are some errors in the edc, console box shows the error logs.
I added error log redirecting feature to find error word in the edc script.
Now, We just double click the console box to find error logs.
Test Plan:
1. make some errors
2. press ctrl + s
3. do mouse double click in console box
4. see the selection region of error word in edc script
Reviewers: Jaehyun_Cho, Hermet
Differential Revision: https://phab.enlightenment.org/D3652
we don't need to apply bracket everytime.
Previously brackets didn't applied and current brackets are no valid either
then skip to apply bracket highlighting function.
Summary:
Add bracket highlight function in thread function.
It cause the entry scroller moving when scroller bar is unpressed.
@T3145
Reviewers: Hermet, Jaehyun_Cho
Differential Revision: https://phab.enlightenment.org/D3671
previously, editor ctxpopup had inc/dec buttons to control values elaboratly.
I removed them because user could control them using mouse wheel.
I believe it's cleaner and nicer ui for enventor.
@feature
Summary:
The selection cursor is moved at the frist
When clicking and moving the bracket using the mouse.
In entry_recover(), there is no selection cursor recover machanism.
So I added the selection recover logic in the function.
Now, it is fixed.
@fix
@T3099
Test Plan:
1. click the bracket
2. moving the cursor keeping the mouse clicking
3. see the fixed result
Reviewers: Jaehyun_Cho, Hermet
Differential Revision: https://phab.enlightenment.org/D3641
Before this change, live view won't be scaled up/down with mouse wheel
unless the live view size was fixed.
Now, it automatically fixes the size of view then change the scale of view.
Hermet Park
taehyub
Jaehyun Cho