Commit Graph

570 Commits

Author SHA1 Message Date
Hermet Park cab3e34fa4 editor/parser: fix memory leaks detected by valgrind. 2016-08-27 16:26:41 +09:00
Hermet Park 755da93bff auto_comp: fix memory leak. 2016-08-27 15:58:12 +09:00
Hermet Park a0b9d4e911 edc_editor: rewrite 5ea2c05dec
We found a side effect from that patch. So rewrite it with an other approach.
It's a hackish but no idea except it :(
2016-08-25 17:22:47 +09:00
Jaehyun Cho b3a5acf761 Revert "build: Support relative resource paths in sub edc file."
This reverts commit c17f2f3e37.
2016-08-24 21:24:40 +09:00
Jaehyun Cho 1cf5123192 Revert "build: Fix changing working directory correctly in all OS."
This reverts commit 60c5967920.
2016-08-24 21:24:25 +09:00
Jaehyun Cho 18b86be0f4 Revert "build: Fix warnings of the usage of chdir() and _chdir()."
This reverts commit 3bcf72a918.
2016-08-24 21:24:18 +09:00
Jaehyun Cho 571342bf2e Revert "code refactoring."
This reverts commit 6d5ce9daca.
2016-08-24 21:24:06 +09:00
Hermet Park 6d5ce9daca code refactoring.
centralize divergent logics.
2016-08-24 17:21:21 +09:00
Jaehyun Cho 3bcf72a918 build: Fix warnings of the usage of chdir() and _chdir(). 2016-08-24 17:09:22 +09:00
Jaehyun Cho 60c5967920 build: Fix changing working directory correctly in all OS. 2016-08-24 17:01:33 +09:00
Hermet Park 5ea2c05dec edc_editor: fix syntax color issue.
Some cases, the edc editor can't apply syntax color
when it opens a new edc file.

we can cover this scanerio by trying  syntax color logic again
until it's succeed.

@T4275
2016-08-24 16:40:18 +09:00
Hermet Park c45c13d8bc cleanup unused warning. 2016-08-24 12:53:11 +09:00
Jaehyun Cho c17f2f3e37 build: Support relative resource paths in sub edc file.
Relative resource paths in sub edc files are based on the current working
directory.
To support relative resource paths in sub edc files, set main edc file's
directory as the working directory when edje_cc is executed.

Test Plan:
1. Create "main.edc" in "./edc/" directory.
2. Create "sub.edc" in "./edc/sub/" directory.
3. Create "icon.png" in "./edc/image/" directory.
4. "main.edc" includes "sub.edc". (i.e. #include "./sub/sub.edc")
5. "sub.edc" uses "icon.png".
   (i.e. images.image: "./image/icon.png" COMP;)
6. Open "main.edc" in the current working directory.
   (i.e. enventor -w ./edc ./edc/main.edc -i ./edc/image)
2016-08-23 21:42:13 +09:00
Hermet Park 63f3fae337 edj_viewer: fix the invalid size of part highlight for the text part.
My previous patch made a side effect that part highting size
wont be correct for the text part.

For now, disable the logic.
2016-08-23 09:07:40 +09:00
Hermet Park 1e5ae3db45 stablize unstable worker threads.
Still there are unsafe thread functions that access invalid memory.
fix all of them.
2016-08-23 08:05:14 +09:00
Hermet Park 3c2a31a8ff git rid of unnessary logic.
Previously, generated views were to terminated if the edj path is changed,
but it's not quite useful at any scenarios.

User may want to change just the edj output path without any input resources
changes.
2016-08-23 01:52:42 +09:00
Jaehyun Cho 231ffaa7e1 lib: Add enventor_object_base_scale_get(). 2016-08-19 18:28:48 +09:00
Taehyub Kim f0ab0ec9a9 edc_parser: move the functions in utils which are find_part and find_group to the edc_parser
Summary:
move hte functions in utils which are find_part and find_group to the edc_parser
since it is right way

Test Plan:
1. launch enventor
2. move cursor on part name in text view
3. press F3 key
4. check it works well

Reviewers: Jaehyun_Cho, NikaWhite, bowonryu, Hermet

Reviewed By: Hermet

Differential Revision: https://phab.enlightenment.org/D4240
2016-08-19 12:56:21 +09:00
Taehyub Kim 74938a0f66 syntax_color: add NULL checking in macro_apply
Summary:
add NULL checking in macro_apply
@fix

Reviewers: Jaehyun_Cho, NikaWhite, bowonryu, Hermet

Differential Revision: https://phab.enlightenment.org/D4237
2016-08-18 17:06:23 +09:00
Hermet Park b5b39617f2 edj_viewer: don't update views if they were deactivated.
This fixes the wireframe issue that deactivated views' wireframes are appeared
when the file is updated.

This is only happened if edc collections is consisted with multiple edc files.
If edj file is updated, all generated views will be updated.
and wireframes will be also updated and appeared.

but we don't need to update the deactivated views even if the edj is
updated. we could this with an activated boolean and this will be much
optimized way for many generated views.
2016-08-18 00:27:56 +09:00
Hermet Park fa929055a2 edj_mgr: reduce the edj view caching time to 5 min. 2016-08-17 23:44:58 +09:00
Taehyub Kim 7e1a4c00a7 edc_editor: add NULL checking in edit_cursor_double_clicked_cb
Summary:
add NULL checking in edit_cursor_double_clicked_cb
@fix

Reviewers: Jaehyun_Cho, NikaWhite, bowonryu, Hermet

Reviewed By: Hermet

Differential Revision: https://phab.enlightenment.org/D4234
2016-08-17 22:29:31 +09:00
Taehyub Kim 950734d000 auto_comp: apply strncpy in context_lexem_thread_cb
Summary:
apply strncpy in context_lexem_thread_cb
@fix

Reviewers: Jaehyun_Cho, NikaWhite, bowonryu, Hermet

Reviewed By: Hermet

Differential Revision: https://phab.enlightenment.org/D4236
2016-08-17 22:28:16 +09:00
Taehyub Kim a47b12bd53 syntax_color: add NULL checking in macro_key_push function
Summary: add NULL checking in macro_key_push function

Reviewers: Jaehyun_Cho, bowonryu, NikaWhite, Hermet

Reviewed By: NikaWhite, Hermet

Differential Revision: https://phab.enlightenment.org/D4235
2016-08-17 22:22:53 +09:00
Taehyub Kim 1665ac9ba6 enventor_smart: add NULL checking
Summary:
add NULL checking in syntax_color_set and syntax_color_get API
@fix

Reviewers: Jaehyun_Cho, NikaWhite, bowonryu, Hermet

Reviewed By: Hermet

Differential Revision: https://phab.enlightenment.org/D4233
2016-08-17 22:21:16 +09:00
Taehyub Kim bc5a7b3c36 edc_editor: support to jump to the part define
Summary: add the new feature to jump to the part define

Test Plan:
1. launch enventor
2. click mouse right button on "relative to" part name in text view
3. check selection is on the part define

Reviewers: Hermet, NikaWhite, bowonryu, Jaehyun_Cho

Reviewed By: Jaehyun_Cho

Tags: #enventor

Differential Revision: https://phab.enlightenment.org/D4167
2016-08-16 22:00:01 +09:00
Hermet Park 4b22c006b1 edj_viewer: ++safety.
add a null check.
2016-08-16 17:28:54 +09:00
Hermet Park a1cabe509f updated eo syntax usage.
it's still under the beta.
2016-08-16 11:48:17 +09:00
Hermet Park 8fec9ff3c9 edc_parser: fix spinlock infinte loop issue.
nullout pointer properly to not access an invalid memory thread.
2016-08-16 11:32:34 +09:00
Hermet Park 5836cc702a edc_edit: code refactoring.
just internal function name change.
2016-08-15 15:00:37 +09:00
Hermet Park 27db1e3245 edj_viewer: set highlight geometry precisely.
change the geometry of highlight to its common geometry,
not actual text area.

This change is for consistency for wireframes,
and I expect user want it.
2016-08-15 14:57:00 +09:00
Hermet Park 7f34f53864 wireframes: fix merge conflict. 2016-08-15 14:16:16 +09:00
Taehyub Kim cb47271ff6 wireframes_obj: restore resize and move callback for layout
Summary: restore resize and move callabck for layout

Test Plan:
1. launch enventor
2. open a basic edc
3. add spacer part
4. turn on wireframe
5. resize the view
6. see the result of wireframe

Reviewers: Jaehyun_Cho, NikaWhite, bowonryu, Hermet

Differential Revision: https://phab.enlightenment.org/D4216

Conflicts:
	src/lib/wireframes_obj.c
2016-08-15 14:09:45 +09:00
Hermet Park 9d188e601e wooo.. one more eo change. 2016-08-12 10:07:10 +09:00
Hermet Park 65267ba2fd file tab: stablizing file switching behavior.
There are still corner case bugs.

one is issued by unsafe thread working
and the other one is group switching.

fixed all in all.
2016-08-12 04:00:17 +09:00
Jaehyun Cho ea4a177dcf reference: Change reference data name from md to rd.
Change reference data name to rd since rd stands for reference data.
2016-08-11 23:35:18 +09:00
Jean-Philippe Andre 3af6ede5e5 clang: Fix warnings and compilation errors
enventor wouldn't compile with clang. Also, it would print
a lot of warnings.
2016-08-10 15:17:41 +09:00
Jaehyun Cho b5e27c58d6 syntax_indent: Fix not to paste string redundantly.
Previously, indentation logic produced a duplicated string if the copied
string ends with spaces.

Test Plan:
1. Open basic template.
2. Cut string right before "}" in the text view.
   (e.g. Copy from 5th line to 7th line right before "}" in basic edc.)
3. Paste the cut string.
4. See that 6th line's string is pasted redundantly.
2016-08-09 21:19:01 +09:00
Hermet Park 6f47ad19e0 multi-file: clear edj views if main item is changed.
If the main item is changed, previous edj views won't be valid anymore.
We need to clear them.
2016-08-09 01:39:56 +09:00
Hermet Park a281963ba1 sanitize compare file pathes.
let's have a full pathes for enventor items.
then we don't need to call ecore_file_realpath() at every accesses.
2016-08-09 01:02:46 +09:00
Hermet Park e086a6edbb ++null check 2016-08-09 00:25:43 +09:00
Hermet Park 780cf89dcc edc_editor: fix missing shortcut key updation. 2016-08-08 23:59:52 +09:00
Hermet Park b3afcc4810 file_browser: stabilizing switching main edc file function. 2016-08-08 23:58:08 +09:00
Jaehyun Cho 8bcb3aa7b4 reference: Fix memory leak. 2016-08-08 16:13:22 +09:00
Hermet Park 726eabd442 edj_viewer: fix a bug that scale is applied one step after.
Logically, it used previous scale factor in updating live view.
update the scale factor first then update the live view!
2016-08-06 01:58:58 +09:00
Taehyub Kim 4f3e016ca9 wirefrmaes_obj: update wireframe when it is animated
Summary:
when animation is working, wire frame is not updated.
so I fixed it.

Test Plan:
1. launch enventor.
2. run animation template
3. see the result about update of wireframe

Reviewers: Jaehyun_Cho, NikaWhite, Hermet

Differential Revision: https://phab.enlightenment.org/D4214
2016-08-05 17:01:48 +09:00
Hermet Park b663b04096 edc_editor: add missing null out. 2016-08-05 16:34:20 +09:00
Hermet Park b987e70045 fix memory leaks. 2016-08-04 23:48:50 +09:00
Hermet Park 1901cd4699 auto_comp: this is the last thread safe code.
there is a quite complex case that non-thread safe code
that may occur crash or wrong behavior of enventor.

just improve the thread safe code to avoid the situation.
2016-08-04 23:25:52 +09:00
Hermet Park 13305c77af auto_comp: ++safe code
don't free auto comp instance if its internal thread is working.
2016-08-04 22:57:24 +09:00