Commit Graph

345 Commits

Author SHA1 Message Date
Stephen Houston 8de29d0358 Ephoto: Make changes to the flow brower, its a smoother flow now, and has a genlist that matches up with the flow browser. Interesting :)
SVN revision: 58077
2011-03-24 21:25:51 +00:00
titan 1547ddaa81 Ephoto: General cleanups.
SVN revision: 57775
2011-03-15 20:09:37 +00:00
titan ae03e70576 Okay. Ephoto back to normal. Move along.
SVN revision: 57560
2011-03-07 22:31:11 +00:00
titan 169813a679 Do not update if you are not willing to expect a different ephoto.. This is a very temporary test that won't work right for most.
SVN revision: 57559
2011-03-07 22:02:12 +00:00
titan ac899f9de4 Allow proper rotations and do proper rotations. This is temporary until edje or evas does them correctly.
SVN revision: 57532
2011-03-05 18:36:08 +00:00
titan 53cec34e73 Ephoto/Flow Browser: Actually remove this for now.. It is causing some issues because flow browser uses the same client as the thumb browser... If you want larger thumbs for flow browser.. the "hack" to do it now is zoom your thumbs all the way in the thumb browser before going to the flow browser.
SVN revision: 57522
2011-03-04 23:08:47 +00:00
titan 2165411085 Ephoto/Flow Browser: Make the flow browser thumbnails larger so when resize they don't get blurry.
SVN revision: 57521
2011-03-04 22:52:00 +00:00
titan 004acaf9f8 Ephoto/Images: Sort images so they are in alphabetical order. This seems to be a good solution as it doesn't seem to slow down Ephoto much at all.
SVN revision: 57520
2011-03-04 21:50:07 +00:00
Cedric BAIL 9ac8cb0be1 ephoto: fix DSO.
SVN revision: 57451
2011-03-01 10:04:40 +00:00
titan 8f8f25942e Whoops. Left out some key bindings.
SVN revision: 57443
2011-03-01 06:24:30 +00:00
titan f95dca17df Make the flow browser follow the same code and styles as the rest of the code.
SVN revision: 57442
2011-03-01 06:11:44 +00:00
titan aadaa80ddd Fix browsing in single view!
SVN revision: 57314
2011-02-24 22:45:00 +00:00
titan 7a11918ac3 Fix a lot of things in ephoto.. reuse some older code but in a good way. Add in a single image browser. Use externals(ugh, but its faster for some reason?)
SVN revision: 57313
2011-02-24 22:26:47 +00:00
titan 362047fe24 Speed up the ephoto thumb browser by a lot... Thanks k-s for some old cold that helped :)
SVN revision: 57227
2011-02-22 01:55:08 +00:00
titan 62f630e67c Fix title
SVN revision: 57174
2011-02-19 20:53:16 +00:00
titan 220c58503d Add some focus calls for switching between thumb and flow browsers.
SVN revision: 57138
2011-02-17 20:23:03 +00:00
titan 48d7093b5e Add slideshow back into ephoto. Works pretty well for now.
SVN revision: 57039
2011-02-14 21:16:13 +00:00
titan 05531c003c Make the starting thumb size smaller.
SVN revision: 57038
2011-02-14 20:30:42 +00:00
titan 138abeab08 Use JPEG FORMAT for ethumb where appropriate.
SVN revision: 57030
2011-02-14 17:12:28 +00:00
titan 30cbc75689 Ephoto now uses the currently selected image in the thumb view as the center of the flow view when view flow is clicked. Also double clicking an image in the thumb view will take you to the flow view and use that image as the center of the flow view.
SVN revision: 57002
2011-02-14 03:04:20 +00:00
titan 61c6ee6513 Add key bindings and mouse bindings to the flow view. You can cycle the flow using the mouse view.. left and backspace cycle the flow previous, and right and space cycle it forward. Escape goes back to the thumb view.
SVN revision: 56998
2011-02-14 01:13:27 +00:00
titan 4f3ecf243d Remove the mapping for now.. I will get it very nice outside of svn before committing next time.. For now a very nice elegant flow is being committed with border and shadows and it looks good.
SVN revision: 56955
2011-02-11 17:58:58 +00:00
titan 1c4ea07b1e Fix some icon definitions
SVN revision: 56944
2011-02-11 00:42:26 +00:00
titan 4ef79b29a5 Fix the current directory when one hasn't been provided.
SVN revision: 56943
2011-02-11 00:09:33 +00:00
titan b9432f30d6 Add the ability to change directories. Also add some 3D mapping to the flow... Please tell me your thoughts? It works great with small images... but as current right now the flow is very slow with large images(even without the mapping)... Does anyone have a solution for this?
SVN revision: 56941
2011-02-10 23:41:02 +00:00
titan 1a52097901 Fix a seg on close.
SVN revision: 56795
2011-02-08 02:51:40 +00:00
titan b48c1d7415 Cleanup the flow browsing some more.
SVN revision: 56793
2011-02-08 00:53:26 +00:00
titan b1b9700881 Use a better method of flowing that eliminates blinking. This uses images preloaded offscreen(sorry for now the preload size is hard coded).. and then when flowing image files are not changed as before, instead image1 = (offscreen_image) image2 = image1 image3 = image2 and so on.
SVN revision: 56792
2011-02-07 23:38:25 +00:00
titan 504a0babcf Fix a bug that causes a segfault by not being to find a path for thumbing.
SVN revision: 56683
2011-02-03 19:41:55 +00:00
titan 6a5164fae8 Whoops get the number we are strcmping right.
SVN revision: 56682
2011-02-03 19:30:59 +00:00
titan 2f49f3359f Whoops bad idea. Efreet is crazy right now. Go back to strncasecmp.
SVN revision: 56681
2011-02-03 19:26:56 +00:00
titan c24ccdf03e Use efreet to determine if its an image or not.
SVN revision: 56680
2011-02-03 19:18:36 +00:00
titan a3e0247f03 Stick to FDO format for now.
SVN revision: 56679
2011-02-03 19:06:57 +00:00
titan 71086703b5 Simplify extension matching. Should fix a segfault.
SVN revision: 56678
2011-02-03 18:58:20 +00:00
titan 2599859876 Speed up flowing by using preload... It doesn't look near as good and is a little glitchy... but its faster for the time being until I work out a better option.
SVN revision: 56664
2011-02-02 22:46:25 +00:00
titan c478bfdeee Clean up a lot of ephoto.. Things that weren't necessary, things that are no longer necessary, etc... Add a true flow view that is a work in progress. Currently ephoto will only open images in the current working directory or in a directory supplied in an argument when started, but this will change when directory stuff is added back in. This gives ephoto more direction and provides a solid base to move forward from. Also, yes, I removed edje externals and I am not using them. There are multiple reasons for this that are all of my opinion and if you would like to discuss it, see me on irc or send out a mail on the list.
SVN revision: 56640
2011-02-01 21:44:38 +00:00
titan cb528acc67 This is what I feel like is a middle ground for how directory browsing is handled in ephoto. Please give me useful feedback. Yes I know the directories/font of the directory labels need work, but you get the general idea, and that will be fixed soon.
SVN revision: 55098
2010-11-30 21:52:49 +00:00
titan 51f36d538b Revert my changes while I work on a new way of doing things. This will make a certain few people happy for the time being until the new way is revealed... then things will get interesting.
SVN revision: 55077
2010-11-30 02:33:22 +00:00
titan 5a22538cae Remove the directories from the gengrid. This is possibly just temporary, but for now they are hideous and ugly and I'm not even sure I want them there in the first place, but especially not looking like that.
SVN revision: 54948
2010-11-24 19:22:34 +00:00
titan d2a93f9e9e Move the parent directory icon out of the gengrid. Next the directories will be moved out of the gengrid.
SVN revision: 54941
2010-11-24 18:15:09 +00:00
Rafael Fonseca 37e9d6c757 Use default theme for gengrid items.
Some of the gengrid items from ephoto were merged into elm default theme.



SVN revision: 54696
2010-11-18 18:10:21 +00:00
Viktor Kojouharov 7a5d4c6437 loop the list when navigating
SVN revision: 54544
2010-11-14 02:20:57 +00:00
Viktor Kojouharov ae7ffbd809 allow for the commonly used space and backspace for navigation as well
SVN revision: 54543
2010-11-14 02:19:10 +00:00
Viktor Kojouharov 0d37c8668e use the entries, rather than the grid items to navigate in flow mode
SVN revision: 54542
2010-11-14 02:14:05 +00:00
Viktor Kojouharov a9a783385d Move the entry list building to the main file, since it is used by both the thumb and flow views.
Inform the relevant parties when the list starts and stops getting populated, and when an entry is created, via ecore events.
Remove the pending path stuff from the thumb browser, as it is not for it.
Remove the ability to set the currently viewed file by path alone, always rely on an entry.
Correctly set the disable states on the navigation toolbar buttons when starting ephoto directly in flow mode


SVN revision: 54541
2010-11-14 01:51:16 +00:00
Cedric BAIL 6f67f63c79 * eio: fix API to match the rest of the EFL API.
SVN revision: 54504
2010-11-12 14:08:01 +00:00
Cedric BAIL 8c554a6ea8 * ephoto: use eio_file_stat_ls.
SVN revision: 54107
2010-11-02 17:08:49 +00:00
Cedric BAIL edd9068f2b * eina: remove dirent so apps don't rely on non portable code.
SVN revision: 54103
2010-11-02 15:11:05 +00:00
Gustavo Sverzut Barbieri c4cf3f9be4 always force focus to parent.
viewer object (child) may have the focus and it would die, then there
is no focused object anymore (we should have a way to revert focus to
parent when children die).



SVN revision: 54058
2010-10-31 02:56:13 +00:00
Gustavo Sverzut Barbieri 89aa7a1991 annoyances--: proper zoom changes, add auto-fit.
after actually using it to browse a directory of pictures I realized
auto-fit is something we need, and need it by default.

as we auto-fit, the zoom range makes no sense anymore... and zoom
should be percentual changes, not absolute. So now zoom increments and
decrements of 20% of the previous value, and there is no lower/upper
limits anymore.



SVN revision: 54057
2010-10-31 02:50:05 +00:00
Gustavo Sverzut Barbieri 9d02b17892 annoyances--: comment rotation/flip as it was broken.
Raster had his word "it is broken that way, either fix it or remove"
and thus removed it is as fixing it properly takes much more time than
I have now.



SVN revision: 54056
2010-10-31 02:04:36 +00:00
Carsten Haitzler d113da0a6c use new type member. dont depend on bsd extensions.
SVN revision: 54017
2010-10-30 05:57:08 +00:00
Cedric BAIL 063248da8f * eio: break Eio error callback API to match the rest of the API.
SVN revision: 53986
2010-10-29 12:36:43 +00:00
Bruno Dilly 11487fbdb5 Fix elm_toolbar usage on several projects
SVN revision: 53896
2010-10-26 10:34:07 +00:00
titan c589ea128f Make sure to leave fullscreen mode when exiting the slideshow.
SVN revision: 53838
2010-10-24 19:10:20 +00:00
Tiago Rezende Campos Falcao 801c22f21c Force focus to scroller in flow mode.
The back action can be did with keybindings.

SVN revision: 53737
2010-10-21 19:21:15 +00:00
Tiago Rezende Campos Falcao 99aa09f9db Remove focus hard management.
Delay windows show to after criation and show of sub-objects. So, when
show windows, it give focus correctly.

SVN revision: 53736
2010-10-21 19:21:13 +00:00
Sebastian Dransfeld a1fddb6891 Only check hash if it exists
SVN revision: 53692
2010-10-20 20:46:53 +00:00
Tiago Rezende Campos Falcao 40b9a71963 Fix focus in flow mode.
You only can give focus to visible objects, hidden objects are
unfocusable.

SVN revision: 53655
2010-10-20 12:08:42 +00:00
Tiago Rezende Campos Falcao 3e1a7b64eb Do nothing when used cancel button
SVN revision: 53654
2010-10-20 12:08:39 +00:00
Lucas De Marchi ab56887638 Fix typo
opt needs some love though



SVN revision: 53465
2010-10-15 18:12:29 +00:00
Leandro Pereira efe017db8b [Ephoto] Update toolbar stuff to suit recent API changes
SVN revision: 53464
2010-10-15 17:54:28 +00:00
Tiago Rezende Campos Falcao ef5dd761e0 Elm_Layout isn't broken
SVN revision: 53463
2010-10-15 17:40:07 +00:00
Tiago Rezende Campos Falcao 0072df5d63 If use Ethumb_Client, include it
SVN revision: 53462
2010-10-15 17:40:03 +00:00
Gustavo Sverzut Barbieri 73a50e088b use elm goodies!
use elm_layout_box_append() + elm_fileselector_entry_add() to choose
directories!



SVN revision: 53386
2010-10-14 02:37:37 +00:00
Gustavo Sverzut Barbieri 8679562a81 and work nicely with empty directories
SVN revision: 53381
2010-10-13 22:32:41 +00:00
Gustavo Sverzut Barbieri 4802d3e2ef queue items to process from animators, save cpu and less flickering.
just add items from an animator so we give time to have a good queue
and do the insert in a batch. It will change the grid population less
often, and will trigger the grid recalc less often as well.



SVN revision: 53380
2010-10-13 22:28:23 +00:00
Gustavo Sverzut Barbieri c847e90429 init eio, as we use it
SVN revision: 53343
2010-10-13 06:15:16 +00:00
Gustavo Sverzut Barbieri dae342bc7d damn async things, they're always more complex than what you want.
in few cases we could quickly change directories and views would still
be populating, then they could access dt->entry
(ephoto_directory_thumb.c), so we need notifiers to know it is gone
and not mess with it any further.

Then ephoto_entry_free_listener_add() is born, added it to
flow_browser and slideshow for the sake of it... it shouldn't be
needed.



SVN revision: 53341
2010-10-13 06:11:06 +00:00
Gustavo Sverzut Barbieri 8756234b66 comment this as it seems to not play well with threads.
probably this is an eina issue with last optimizations from cedric,
but I'm commenting these out for now. (if efreet_mime is no-go from
threads, must remove it from enjoy as well).



SVN revision: 53339
2010-10-13 05:23:31 +00:00
Gustavo Sverzut Barbieri b4f63379b5 do not show up when we're at /
SVN revision: 53338
2010-10-13 05:21:45 +00:00
Gustavo Sverzut Barbieri 8bd148fa72 eio_file_cancel() is async and will run on future main loop iteration.
damn beast hard to find, but i guess ephoto is now ready (/me hides...)



SVN revision: 53337
2010-10-13 05:06:18 +00:00
Gustavo Sverzut Barbieri feba790912 some less valgrind errors.
I guess I've spotted the main problem with eio usage, will commit in
another revision.



SVN revision: 53335
2010-10-13 03:24:22 +00:00
Gustavo Sverzut Barbieri f5e062c676 handle no parameter without previous directory.
SVN revision: 53321
2010-10-12 23:46:36 +00:00
Gustavo Sverzut Barbieri 81d47b1344 ephoto is mostly ready again!
Well, at least that was what I had time and stamina to do. Please join
the development with your ideas and requirements.

The toolbar is now placed on top, because default.edc (from
elementary) says so. We better use elementary's profile to define the
theme to use, and a theme could have it at the bottom (mobiles?).

I've added all options to toolbar, which makes it very wide on single
image viewer. We'll later introduce toolbar item "visibility priority"
to auto-hide items and add a "More" menu if the elementary's profile
says so, other options will be to make it scrollable (as it is now).

EXIF rotation support is not right in my opinion. We're using map to
rotate, but it is not doing fine, as I said in another bug. We should
have code to request evas to load the image rotated, then we re-load
the image and it should work better (need to check how that would work
with region load from JPEG, used by elm_photocam).

Preferences are out as I ran out of time.



SVN revision: 53319
2010-10-12 22:54:20 +00:00
Gustavo Sverzut Barbieri ad73446df7 support more exif orientation modes.
Raster, this exposes some problems with map as well. At least flipping
seems to not work properly sometimes. In my case I just use Shift+[ to
flip horizontally and it does not work.



SVN revision: 53312
2010-10-12 18:16:42 +00:00
Gustavo Sverzut Barbieri d74d0ff7c9 alt-up for thumb browser, make orient get visible outside.
I tried to apply the orient rotation using map on the elm_photo, but
it does not work :-( If you know how to fix it, take a look.



SVN revision: 53311
2010-10-12 17:26:23 +00:00
Gustavo Sverzut Barbieri 3b4f4d0f25 remove error message, fix message and add debug.
SVN revision: 53294
2010-10-12 05:19:56 +00:00
Gustavo Sverzut Barbieri 717c438a0e ephoto autotools overhaul.
* added Vincent recommended warnings (ie: -Wshadow) and also -Wextra;
 * uses ac_attribute.m4 to define __UNUSED__;
 * uses -Wl,--as-needed
 * uses -fvisibility=hidden by default, if supported
 * uses -ffunction-sections -fdata-sections + -Wl,--gc-sections
 * added gettext (not tested yet, but should work)
 * added quicklaunch support (not tested yet, but should work)
 * make it pass make distcheck

with the optimization flags, on my 32bits machine ephoto is amazingly
44Kb binary! Of course it loads super-fast even without quicklaunch,
amazing what we can do with 44kb binary + 188kb theme (mostly about
images I'm shipping in 128x128 + 256x256 + 512x512 and other images
that should be in elementary's theme).



SVN revision: 53293
2010-10-12 04:58:04 +00:00
Gustavo Sverzut Barbieri 5064e7bf6e remember_directory is not an option anymore.
useless to have it as an option as user may already override with
command line what to show.



SVN revision: 53283
2010-10-12 03:44:17 +00:00
Gustavo Sverzut Barbieri 770baf199e slideshow is back.
toolbars still missing, will return them back tomorrow.



SVN revision: 53281
2010-10-12 03:40:14 +00:00
Gustavo Sverzut Barbieri e5c722abb2 insert thumbnails sorted.
SVN revision: 53255
2010-10-11 02:54:49 +00:00
Gustavo Sverzut Barbieri c0537216c5 load orient from jpeg, remove former code that was ifdef'ed.
maybe the code is complaining is complaining too loud of lack of exif,
we can change that later if required.

remove the rotation animation as the case 270->0 is too confusing! it
would need some logic to rotate 270->360 then make it 0.



SVN revision: 53254
2010-10-11 02:30:51 +00:00
Gustavo Sverzut Barbieri b44a686b53 one more day of work on ephoto, still not complete.
flow browser (why that name?!) is back, with the my traditional
combination of 255,0 in rgb colored buttons in edje.

tomorrow will work on slideshow and make it work.

NOTE: ProFUSION team will work on a solution to have elm_toolbar +
elm_menu to be good and provide what we have in eve/enjoy in a more
generic way without thousand lines of macros in EDC. The goal is to
have configurable implementation that would provide some UI on desktop
and another on embedded, also showing buttons as we have space, and
hidding them with an automatic "more" entry if there is no space for
all items. That should improve eve, enjoy, ephoto and possibly others.



SVN revision: 53250
2010-10-11 01:10:27 +00:00
Gustavo Sverzut Barbieri 47da8cd526 zoom actions, still barebones.
I was about to move to efenniht theme, but it will be some work I'd
not be able to finish in time... given that we'll have enjoy, eve,
envision and ephoto using the same things, it is time to consider a
better replicable solution.




SVN revision: 53240
2010-10-10 18:57:48 +00:00
Gustavo Sverzut Barbieri 9652a108bf ouch, refactor part 2 -- less is more, so get nothing ;-)
okay, still yet another partial code, it's far from ready, don't even
checkout until you're ready to code.

preferences, flow_browser, slideshow are temporarily gone.

still no toolbar in main window, layout redone using EXTERNAL... when
it go back, it will be in the same form as eve/enjoy.



SVN revision: 53238
2010-10-10 01:13:53 +00:00
Gustavo Sverzut Barbieri e21422bf65 ephoto core simplification - part 1 (UNFINISHED!!!!)
I'm rewriting parts of ephoto to simplify it, one of the things is to
avoid lots of nesting of layouts to get a simple preview
image.

So far just the thumb directory is done to the point it shows the
contents of a directory, it will do nothing on selection and
clicks. There is no toolbar either, as this is going to be replaced
later on.

EFL bugs so far:
 * eio_file_cancel() is not playing nice with ecore_pipe, with errors like: "ecore_pipe.c:517 _ecore_pipe_read() An unhandled error (ret: -1 errno: 9)occurred while reading from the pipe the length"

 * evas/edje map is broken WRT clipping! if I have map { on: 1;
   rotation.z: 10;} and this part is clipped to some other part, the
   clipper will be ignored!

Sorry, but I couldn't finish it now, trying to do it later today and
tomorrow. I still need to add the elm_genlist_item_prepend(),
elm_genlist_item_insert_before() and elm_genlist_item_insert_after()
to get the sorted insert to work.



SVN revision: 53237
2010-10-09 19:13:35 +00:00
Gustavo Sverzut Barbieri 73d91bfa90 usual paradigm is vertical scroll, let's stick to it.
SVN revision: 53226
2010-10-09 01:45:32 +00:00
Gustavo Sverzut Barbieri 20df19562f use noframe style... yeah! get ride of that annoying border inside the border!
SVN revision: 53222
2010-10-08 23:18:41 +00:00
Gustavo Sverzut Barbieri 840b2e8574 faster and better: png or jpeg, crop.
if source file is a jpeg, then speed up and generate thumbnails in
format "JPEG" that are smaller and faster to load.

also define the aspect to be cropped rather than keep aspect as we're
showing the images in a fixed square. The aspect one would be good if
we did not use a grid, rather a flow layout.



SVN revision: 53218
2010-10-08 23:03:22 +00:00
Gustavo Sverzut Barbieri e3a1481bb9 what about generating thumbnails that match the expected view size?
now generating thumbnails at 128, 256 and 512, the generation is
delayed to avoid unnecessary work for ethumbd.



SVN revision: 53217
2010-10-08 22:48:12 +00:00
Gustavo Sverzut Barbieri 2fd24ddbac hack not needed anymore.
SVN revision: 53213
2010-10-08 21:47:40 +00:00
Gustavo Sverzut Barbieri e434b9aaee refactor, improve sizing of icons.
use super-duper-nice edje features to choose image based on the
current object size and provide icons at 128, 256 and 512 so we're
always high quality.



SVN revision: 53212
2010-10-08 21:43:57 +00:00
Gustavo Sverzut Barbieri dc2f3c47c9 avoid directories starting with '.' and faster check for directory.
SVN revision: 53210
2010-10-08 20:31:04 +00:00
Gustavo Sverzut Barbieri ccaa92a949 better min/max values.
SVN revision: 53209
2010-10-08 20:25:18 +00:00
Gustavo Sverzut Barbieri 50c67f7ad6 simplify, move thumb count to theme, min limit to contents.
If we used such a large border with small item sizes, the content size
would be zero and thus icons did turn invisible. Limit that to 16x16.

"thumbs" in group will say how many thumbnails are desired, instead of
hardcoding it to 3.

countless code simplifications.



SVN revision: 53207
2010-10-08 20:21:29 +00:00
Gustavo Sverzut Barbieri 5637a4879f oops, remaining shutdowns that should die.
SVN revision: 53201
2010-10-08 19:48:32 +00:00
Gustavo Sverzut Barbieri 2e88dacb27 whitespace cleanup, log domain to lowercase.
SVN revision: 53200
2010-10-08 19:04:34 +00:00
Gustavo Sverzut Barbieri 844d8b6529 simplify, just init efreet_mime once, etc.
make code simpler, just init efreet_mime at startup, just need ethumb
once as well.



SVN revision: 53199
2010-10-08 19:03:21 +00:00
Gustavo Sverzut Barbieri cc899e3325 couple of minor improvements to ephoto.
* fix a bit of coding style (damn, it's totally off with SVN coding style!)

 * save basename to avoid calculating it over and over again.

 * ignore hidden files and folders (those that start with ".")

 * rename "top" to "Up" as we just go one level.

 * add TODO that requires adding eio_file_ls_direct()... the current
   version is not that useful, we really could use dirent, basename
   and lengths while filtering.

 * add TODO to speed up matches of JPG, PNG, and like... these will
   account for most of the files we browse, thus they should be fast
   and not rely on efreet (which may not be that good to use from
   threads... if it is, then it's more expensive as we need to lock)



SVN revision: 53198
2010-10-08 18:51:19 +00:00