Commit Graph

206 Commits

Author SHA1 Message Date
Gustavo Sverzut Barbieri 840b2e8574 faster and better: png or jpeg, crop.
if source file is a jpeg, then speed up and generate thumbnails in
format "JPEG" that are smaller and faster to load.

also define the aspect to be cropped rather than keep aspect as we're
showing the images in a fixed square. The aspect one would be good if
we did not use a grid, rather a flow layout.

SVN revision: 53218
2010-10-08 23:03:22 +00:00
Gustavo Sverzut Barbieri e3a1481bb9 what about generating thumbnails that match the expected view size?
now generating thumbnails at 128, 256 and 512, the generation is
delayed to avoid unnecessary work for ethumbd.

SVN revision: 53217
2010-10-08 22:48:12 +00:00
Gustavo Sverzut Barbieri 2fd24ddbac hack not needed anymore.
SVN revision: 53213
2010-10-08 21:47:40 +00:00
Gustavo Sverzut Barbieri e434b9aaee refactor, improve sizing of icons.
use super-duper-nice edje features to choose image based on the
current object size and provide icons at 128, 256 and 512 so we're
always high quality.

SVN revision: 53212
2010-10-08 21:43:57 +00:00
Gustavo Sverzut Barbieri dc2f3c47c9 avoid directories starting with '.' and faster check for directory.
SVN revision: 53210
2010-10-08 20:31:04 +00:00
Gustavo Sverzut Barbieri ccaa92a949 better min/max values.
SVN revision: 53209
2010-10-08 20:25:18 +00:00
Gustavo Sverzut Barbieri 50c67f7ad6 simplify, move thumb count to theme, min limit to contents.
If we used such a large border with small item sizes, the content size
would be zero and thus icons did turn invisible. Limit that to 16x16.

"thumbs" in group will say how many thumbnails are desired, instead of
hardcoding it to 3.

countless code simplifications.

SVN revision: 53207
2010-10-08 20:21:29 +00:00
Gustavo Sverzut Barbieri 5637a4879f oops, remaining shutdowns that should die.
SVN revision: 53201
2010-10-08 19:48:32 +00:00
Gustavo Sverzut Barbieri 2e88dacb27 whitespace cleanup, log domain to lowercase.
SVN revision: 53200
2010-10-08 19:04:34 +00:00
Gustavo Sverzut Barbieri 844d8b6529 simplify, just init efreet_mime once, etc.
make code simpler, just init efreet_mime at startup, just need ethumb
once as well.

SVN revision: 53199
2010-10-08 19:03:21 +00:00
Gustavo Sverzut Barbieri cc899e3325 couple of minor improvements to ephoto.
* fix a bit of coding style (damn, it's totally off with SVN coding style!)

 * save basename to avoid calculating it over and over again.

 * ignore hidden files and folders (those that start with ".")

 * rename "top" to "Up" as we just go one level.

 * add TODO that requires adding eio_file_ls_direct()... the current
   version is not that useful, we really could use dirent, basename
   and lengths while filtering.

 * add TODO to speed up matches of JPG, PNG, and like... these will
   account for most of the files we browse, thus they should be fast
   and not rely on efreet (which may not be that good to use from
   threads... if it is, then it's more expensive as we need to lock)

SVN revision: 53198
2010-10-08 18:51:19 +00:00
Nicolas Aguirre f83df173c9 Add missing file
SVN revision: 52999
2010-10-03 14:45:53 +00:00
Nicolas Aguirre 53a83a021f Apply Otavio Pontes patch about displaying directories and modify it to display thumbnails when photos are present into this directory.
Author: Otavio Pontes <>
Date:   Mon Sep 27 15:26:55 2010 -0300

    Displaying directories in thumb browser
    It is possible also to open an directory to see images in it.

SVN revision: 52994
2010-10-03 09:50:00 +00:00
Viktor Kojouharov 1a73a71d36 add an option to sort the images before displaying them.
SVN revision: 52989
2010-10-03 00:13:02 +00:00
Nicolas Aguirre 1c512b83f8 Avoid photocam zoom effect on picture load.
SVN revision: 52956
2010-10-01 18:06:05 +00:00
Cedric BAIL 7a3e11d737 * ephoto: call exif only on jpeg file.
SVN revision: 52927
2010-09-30 16:23:54 +00:00
Nicolas Aguirre 153e9d89d6 commit c0d355a3438ba4e9c731d190fa292c0eb9acde23
Author: Otavio Pontes <>
Date:   Mon Sep 27 11:32:34 2010 -0300

    Fixing some bugs in image exibition.
    Using photocan to show png files in flow browser and using elm_image
    instead of elm_bg to display thumbs in thumb_browser. elm_bg was
    creating a strange border in images with white(or transparent)

SVN revision: 52902
2010-09-29 17:57:43 +00:00
Otavio Pontes ad063ce60e From: Otavio Pontes <>
Date: Thu, 23 Sep 2010 16:39:58 -0300
Subject: [PATCH 4/5] Adding new keyboard shortcuts to ephoto.

Also adds:
 - zoom in/out function to flow_browser and buttons in toolbar
for zoom and rotation.
 - Fullscreen mode to slideshow.

SVN revision: 52899
2010-09-29 17:34:35 +00:00
Nicolas Aguirre 4da0ca1b85 The second patch fixes on bug related to an invalid memory access that was
causing segmentation fault in my computer (valgrind was complaining
about it too).

patch from Otávio Pontes.

SVN revision: 52898
2010-09-29 17:09:42 +00:00
Nicolas Aguirre 7e44cd9256 First patch fixes one warning about integer comparison.
patch from Otávio Pontes

SVN revision: 52897
2010-09-29 17:06:32 +00:00
Viktor Kojouharov d9c7cfd80e add the external editor support (currently by pressing "e" in the flow browser)
SVN revision: 52820
2010-09-27 22:02:10 +00:00
Viktor Kojouharov 5d473ea800 fix a few segfaults that happened on a specific computer
SVN revision: 52483
2010-09-20 09:06:53 +00:00
titan e2fed73485 Fix toolbar items.
SVN revision: 52481
2010-09-19 22:32:56 +00:00
titan e5cee3de65 Don't swallow the toolbar twice.
SVN revision: 52479
2010-09-19 21:59:05 +00:00
titan 19243a1ae1 Swallow the toolbar in the correct place.
SVN revision: 52478
2010-09-19 21:54:58 +00:00
Viktor Kojouharov ca05627df0 Preferences dialog. Users can change the slideshow parameters, and tell ephoto to start from the last remembered dir, if it was started with no arguments
SVN revision: 52464
2010-09-19 15:30:36 +00:00
titan 574483bb47 Remove a lot of warnings.
SVN revision: 52424
2010-09-18 20:18:43 +00:00
Viktor Kojouharov 35c4b294bd optional libexif support.
initial rotation support with edje map (the swallow still needs to be refitted in the available space after the rotation)

SVN revision: 52238
2010-09-14 08:35:42 +00:00
Viktor Kojouharov 1dcf8aef39 always save the config on exit
SVN revision: 52236
2010-09-14 07:02:04 +00:00
Viktor Kojouharov cbdc82096b limit thumb scrolling to the horizontal axis, since it doesn't overflow vertically
SVN revision: 52202
2010-09-13 22:27:00 +00:00
Viktor Kojouharov cdb8b51c3f eet configuration. only stores the slider value for now. eina log domain macros
SVN revision: 52201
2010-09-13 22:24:59 +00:00
Nicolas Aguirre 368ed28cce remove debug messages and formatting
SVN revision: 52194
2010-09-13 17:36:16 +00:00
Nicolas Aguirre bd1ed51ead Add a callback when a new directory is selected : "directory,changed".
SVN revision: 52193
2010-09-13 17:02:32 +00:00
Nicolas Aguirre ea18ee503b Use evas_smart objects for flow and thumb browsers, we can now use them as regular evas smart objects with evas_object_show/del/hide ...
SVN revision: 52192
2010-09-13 16:40:33 +00:00
Nicolas Aguirre a13304ff1d Change ephoto to use an edje layout instead of elm boxes.
SVN revision: 52191
2010-09-13 16:29:39 +00:00
Cedric BAIL fc3497295d * ephoto: no need to destroy window at that point.
SVN revision: 52137
2010-09-10 12:30:59 +00:00
Cedric BAIL 11ee1079e1 * ephoto: some cleanup.
SVN revision: 51943
2010-09-07 13:12:08 +00:00
Cedric BAIL 24c98b891b * ephoto: fix use of unitialized data.
SVN revision: 51659
2010-08-26 13:42:38 +00:00
titan a8a45932f3 Move the toolbar to the bottom for consistency and fix segv when clicking View Large while no pictures are populated.
SVN revision: 51649
2010-08-26 00:40:31 +00:00
Lucas De Marchi 182fd84af4 Convert (hopefully) all comparisons to NULL
Apply badzero.cocci, badnull.coci and badnull2.cocci

This should convert all cases where there's a comparison to NULL to simpler
forms. This patch applies the following transformations:

code before patch               ||code after patch

return a == NULL;                 return !a;

return a != NULL;                 return !!a;

func(a == NULL);                  func(!a);

func(a != NULL);                  func(!!a);

b = a == NULL;                    b = !a;

b = a != NULL;                    b = !!a;

b = a == NULL ? c : d;            b = !a ? c : d;

b = a != NULL ? c : d;            b = a ? c : d;

other cases:

a == NULL                         !a
a != NULL                         a

SVN revision: 51487
2010-08-21 13:52:25 +00:00
Lucas De Marchi c3a6049d53 Fix wrong usages of malloc, calloc and E_NEW
Patch by bad-alloc.cocci

SVN revision: 50828
2010-08-05 00:50:43 +00:00
titan 133c3b83e0 Whoops. Fix for real.
SVN revision: 50776
2010-08-03 17:57:10 +00:00
titan 98bb42c6a2 Make changes to match api changes in eio.
SVN revision: 50772
2010-08-03 17:14:54 +00:00
titan 82f69119b6 Add slideshow to ephoto.. It uses elm_slideshow, and this is likely temporary, because in the f uture I am going to do some more extensive slideshow stuff. I'm not happy with this, it seems pretty slow on transitions(I'll take a look at speeding things up), but it will do for now.
SVN revision: 50569
2010-07-28 02:06:03 +00:00
Cedric BAIL 7f75caca3a * eio: Add an error callback, some docs and a small README.
SVN revision: 50446
2010-07-23 11:00:44 +00:00
Cedric BAIL e2c35a285b * ephoto: use eio to simplify and make a small nice example.
SVN revision: 50432
2010-07-22 16:15:16 +00:00
Cedric BAIL a1af3e8605 * ephoto: simplify code and make it easy to add new keys.
SVN revision: 50430
2010-07-22 16:09:31 +00:00
titan a6e087843a Allow you to browse through the large images using arrow keys, left and right.
SVN revision: 50423
2010-07-21 23:40:49 +00:00
titan 56d4da9fd3 Fix ephoto's gengrid theme so photos show again.
SVN revision: 50261
2010-07-14 23:23:54 +00:00
titan f1a200c4c3 Add the ability to specify a directory or file to run ephoto with.
SVN revision: 50176
2010-07-10 21:52:14 +00:00