From a1341ac74cf32e8893d6d69250e7fbf44cbf7548 Mon Sep 17 00:00:00 2001 From: Daniel Zaoui Date: Fri, 18 May 2018 17:20:56 +0300 Subject: [PATCH] Fix Valgrind issue It was complaining of an invalid read size because it was accessing bytes after the pixels buffer. --- src/lib/unit.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/lib/unit.c b/src/lib/unit.c index f1142e3..a215222 100644 --- a/src/lib/unit.c +++ b/src/lib/unit.c @@ -339,8 +339,8 @@ exactness_image_compare(Exactness_Image *img1, Exactness_Image *img2, Exactness_ { for (h = 0; h < hO; h++) { - Eina_Bool valid1 = img1 ? w <= w1 && h <= h1 : EINA_FALSE; - Eina_Bool valid2 = img2 ? w <= w2 && h <= h2 : EINA_FALSE; + Eina_Bool valid1 = img1 ? w < w1 && h < h1 : EINA_FALSE; + Eina_Bool valid2 = img2 ? w < w2 && h < h2 : EINA_FALSE; int px1 = valid1 ? pxs1[h * w1 + w] : 0; int px2 = valid2 ? pxs2[h * w2 + w] : 0; int r1 = (px1 & 0x00FF0000) >> 16;