From 8788cf72a37613ecdc4ee6a3c4d7c47bcd138540 Mon Sep 17 00:00:00 2001 From: Srivardhan Hebbar Date: Mon, 7 Sep 2015 13:30:48 +0200 Subject: [PATCH] ecore_example: Fixing NULL deference. Summary: pd was dereferenced and then checked for NULL. If it was NULL, the program would crash much before. So fixed that. Signed-off-by: Srivardhan Hebbar Reviewers: cedric, stefan_schmidt Subscribers: cedric Differential Revision: https://phab.enlightenment.org/D3031 --- unsorted/ecore/ecore_buffer_provider_example.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/unsorted/ecore/ecore_buffer_provider_example.c b/unsorted/ecore/ecore_buffer_provider_example.c index 112854b4..5d1d5b01 100644 --- a/unsorted/ecore/ecore_buffer_provider_example.c +++ b/unsorted/ecore/ecore_buffer_provider_example.c @@ -246,7 +246,7 @@ main(void) pd = (Provider_Data *)calloc(sizeof(Provider_Data), 1); - if (!(pd->provider = ecore_buffer_provider_new(name))) + if (!pd || !(pd->provider = ecore_buffer_provider_new(name))) { LOG("Failed to create provider"); goto shutdown; @@ -267,7 +267,7 @@ shutdown: ecore_buffer_free(b); } if (pd->provider) ecore_buffer_provider_free(pd->provider); - if (pd) free(pd); + free(pd); shutdown_all(); return 0;