Evas.Smart: Comment out a warning for an issue we can't fix

When a smart event has event_info we need to convert it to a Python object.
We rely on the C library documentation to inform us when an event includes event_info
and assign a conversion function to the event handler based on this and pass the Python
object as an extra parameter to the callback. However when the documentation has omitted
this information we erroneously leave the extra parameter out, making the callbacks have
one less parameter, which our users rely on. Finding out the error after release is
useless since fixing it would mean breaking user callbacks.

This warning informed us at runtime when event_info was non-null but it's pretty much
useless so let's remove it.

Our smart callbacks should never have had two different signatures.
This commit is contained in:
Kai Huuhko 2016-08-05 18:56:29 +03:00
parent fbabb111d8
commit f86234dd25
1 changed files with 5 additions and 5 deletions

View File

@ -426,11 +426,11 @@ cdef void _smart_callback(void *data, Evas_Object *o, void *event_info) with gil
except Exception:
traceback.print_exc()
elif event_info != NULL and spec.event_conv == NULL:
EINA_LOG_DOM_WARN(
PY_EFL_EVAS_LOG_DOMAIN,
'event_info for event "%s" is not NULL and there is no event_conv!',
<const char*>event
)
#EINA_LOG_DOM_WARN(
# PY_EFL_EVAS_LOG_DOMAIN,
# 'event_info for event "%s" is not NULL and there is no event_conv!',
# <const char*>event
# )
try:
tmp_args = [spec.obj]
tmp_args.extend(spec.args)