so if you slide up and down the seek bar without an existing thumb
file (al my videos had thumb fils because i've been using the browser
which generates the thumb files for me mostly), then rage may spawn
several thumbnailersfor the same file. this is not a good thing. so
avoid it and only have 1 thumbnailer per file
so if someone is sily and sets their videos dir to be $HOME ... don't
use it as frankly that makes the video browser useless. it is not
meant for such a mess of dirs. it's meant for a special subdirectory
system which is primarly just media files and nothing else ... not $HOME
so now sizing and count and spacing of items change, header
sizes/style change and more when switching to/from fullscreen mode.
fullscreen == "i want to be a media cener now on a big screen tv" vs
"i'm a video collection browser in a window on your desktop". far
nicer now. i think this is getting close to another release. maybe
after 1.18
it seems either the ecore timer changes or eodel/unref changes have
caused something bad. timers even tho deleted by ecore_timer_del still
go ticking. this seems to happen in range with the thumb objects. the
smart del deletes the timer - explicitly then LATER the callback is
called still. bad bad bad. for now - don't segv... but eo complaints
about invalid obj id's are due to eo/efl changes.
-> cedric
-> tasn
:S
This reverts commit 25ffdc470c.
go back to good 'old subdir build. it's just too much of a pain having
to always build from a toplevel dir. see all the issues with efl doing
this.
if you have
file.mp4
then this will use
file.mp4.png
file.mp4.jpg
file.mp3.jpeg
in that order (first found wins) in the same dir instead of googling
for an image. it will also try after the abover, in order:
file.png
file.jpg
file.jpeg
.file.mp4.png
.file.mp4.jpg
.file.mp4.jpeg
.file.png
.file.jpg
.file.jpeg
.thumb/file.mp4.png
.thumb/file.mp4.jpg
.thumb/file.mp3.jpeg
.thumb/file.png
.thumb/file.jpg
.thumb/file.jpeg
first one found wins. if none of these exist, then google shall be
consulted. :)
make video hide on stop so when browser i sback there isnt a dead
video in the background
make poster mode explicit so timeline thumbs work again
add spacing between browser item and make label multi-line
...
1. guess if it's a move by aspectr ratio and lenght.
2. if it meets this - search for a file poster online instead of
generating thumbnails.
3. make thumbs now taller than wide to accomodate poster sizes
looks nicer now.
Summary: Dropping a directory into Rage added everything before this patch, complaining about some files and definitely not playing them. This adds `emotion_object_extension_may_play_get()` checks.
Test Plan:
Drop a non-playable file and a directory containing non-playable files.
The file(s) get(s) added (but cannot be played, obviously) before this patch and after this they're ignored.
Reviewers: raster
Projects: #rage
Differential Revision: https://phab.enlightenment.org/D3162
this adds a video browser that indexes everything in ~/Videos
flattening subdirs into categories. It also will handle music and
fetch album art. browser can be mouse or key controlled. makes rage
almost media-centerey. not intended as a replacement tho, but just
that it's handy to throw in.
Summary:
Emotion lib ref count is incremented by video_add and by emotion_object_add.
This ref count should be also decremented when the object returned by video_add is
destroyed.
An other way to fix this leak is to remove emotion_init from video_add since
it's already initialised by emotion_object_add.
Projects: #rage
Differential Revision: https://phab.enlightenment.org/D3060
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
A crash happens when a movie finishes and the program terminates.
An access to the "inf" data is done, although this data has been freed
during the win deletion.
It crashes only if the mouse is not over the progress bar.
@fix
Eduardo Lima (Etrunko)
Markus Törnqvist
Thomas Guillem
Daniel Zaoui