Summary: Dropping a directory into Rage added everything before this patch, complaining about some files and definitely not playing them. This adds `emotion_object_extension_may_play_get()` checks.
Test Plan:
Drop a non-playable file and a directory containing non-playable files.
The file(s) get(s) added (but cannot be played, obviously) before this patch and after this they're ignored.
Reviewers: raster
Projects: #rage
Differential Revision: https://phab.enlightenment.org/D3162
this adds a video browser that indexes everything in ~/Videos
flattening subdirs into categories. It also will handle music and
fetch album art. browser can be mouse or key controlled. makes rage
almost media-centerey. not intended as a replacement tho, but just
that it's handy to throw in.
Summary:
Emotion lib ref count is incremented by video_add and by emotion_object_add.
This ref count should be also decremented when the object returned by video_add is
destroyed.
An other way to fix this leak is to remove emotion_init from video_add since
it's already initialised by emotion_object_add.
Projects: #rage
Differential Revision: https://phab.enlightenment.org/D3060
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
A crash happens when a movie finishes and the program terminates.
An access to the "inf" data is done, although this data has been freed
during the win deletion.
It crashes only if the mouse is not over the progress bar.
@fix
rage was trying to fetch albumart for videos mistakenly. i thought
this may have been an emotion mess-up. no. rage mess-up. fix by
delaying until emotion back-end has figured out the new stream. this
does point out that curl is managing to block the mainloop and perhaps
we should stuff it off into a slave thread in ecore_con. :(
If the file is a real url (with urlencoded chars) then use
efreet_uri_decode to decode the uri and use the decoded
string in place of the raw file in window title and playlist items
Summary:
It's somewhat annoying to keep restarting rage in order to manipulate the playlist. Having a keybind for clearing it
goes a long way for usability.
Test Plan: Add files. Hit c. Add more files. Skip around in the playlist. Clear. Add.
Reviewers: etrunko, raster
Projects: #rage
Differential Revision: https://phab.enlightenment.org/D1484
* fix mem leak of vid content
Summary:
So you have unorganized files, or pseudo-organized files, and you dump them into rage. A song or video comes up that you don't want to bother with, so you want to hit delete to not play it.
This will be more useful later with a "loop all" feature, but I implemented it now because I often bump into this situation.
Reviewers: etrunko, raster
Projects: #rage
Differential Revision: https://phab.enlightenment.org/D1486
* also fix mem leak in not freeing vid struct content
Summary:
When doing other patches, I was constantly distracted by this printf and I couldn't see a purpose for having it in there.
You may reject this patch if you want, but I think it warrants some thought :)
Reviewers: etrunko, raster
Projects: #rage
Differential Revision: https://phab.enlightenment.org/D1483
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
They were being called on the wrong object (the video smart instead of the emotion object),
now all the functions get called on the emotion object as they should.
if the track is audio only, it'll look in a cache of albumart, if not,
request the big google in the sky for an image with some search terms
guessed from id3/metadata/filename and then use that. tak'es the first
thing found. not very smart, but pretty damned good most of the time.
these thumbnails are generated in the bg by rage_thumb and will appear
once generated (or already found cached). it'll generate new thumbs if
modified dates are equal or newer on tthe src vs the thumbnail cache.
the caches store 160xN thumbs (keep aspect) with 70% lossy jpeg
quality in an eet file with one thumb per 10 second interval. so it
has limited accuracy.
Carsten Haitzler
Markus Törnqvist
Thomas Guillem
Daniel Zaoui
Eduardo Lima (Etrunko)
Davide Andreoli
Amitesh Singh
Cedric BAIL
Mike Blumenkrantz
Tom Hacohen