ERR("Hello '%c'", ESC) would result in "Hello '\033'" which means
the parent terminal (another terminology, maybe) would then try to
interpret ' as an escape char (ESC is \033 or 0x1b), and so it would
then forward more escapes to the parent.
Also, avoid printing BEL (and, well, beeping) when we are just
printing an error log.
I believe all those "Unhandled escape" logs should go to WRN or higher
log levels. Any thoughts, @billiob ?
See T2506 (for the test file)
This reverts commit 1f3f779258.
this breaks terminal scrolling entirely! can't scroll anymore at all
in standard shell. just try a simple: find / -print
There are still some oddities because the shell doesn't expect us to
reflow.
Let's say we have the following where X is the cursor.
+-------+
|foobar$|
|X |
+-------+
Here, the shell explicitly told us to go to a new line after '$'. We don't
consider '$' is on the same line as 'foobar'.
Decrease the width of that window.
+------+
|foobar|
|$ |
|X |
+------+
Let the shell know the new size. It decides to redraw the prompt. It
remembers it told us to go to a new line, so the first thing it tells us
is to go one line up: to '$' and not 'foobar'. Then it tells us to clear
the screen downward from there and to print "foobar$" (and go to new
line).
Thus we have the following:
+------+
|foobar|
|foobar|
|$ |
|X |
+------+
"Do not let CUU and CUD scroll off screen."
Previously I missed how the default values are implemented.
Reviewers: billiob, cedric
Differential Revision: https://phab.enlightenment.org/D417
Signed-off-by: Cedric BAIL <cedric.bail@samsung.com>
This reverts commit 5ab7a6f827.
This patch did completely break emacs for me. I have no idea what the intent was, but
at least my application/OS is broken.
Boris Faure
Jean-Philippe Andre
Carsten Haitzler
godfath3r
Sebastian Dransfeld
Aleksandar Popadić
Cedric BAIL