XPM loader: Correct signature check (avoid accessing unset data)

2019-11-22 17:07:22 +01:00 · 2019-11-22 17:07:22 +01:00 · 9b0ab12697
parent 947b602cca
commit 9b0ab12697
1 changed files with 3 additions and 2 deletions
--- a/src/modules/loaders/loader_xpm.c
+++ b/src/modules/loaders/loader_xpm.c
@ -125,10 +125,11 @@ load(ImlibImage * im, ImlibProgressFunction progress, char progress_granularity,
   if (!f)
      return 0;

-   if (fread(s, 1, sizeof(s) - 1, f) < 9)
+   len = fread(s, 1, sizeof(s) - 1, f);
+   if (len < 9)
      goto quit;

-   s[sizeof(s) - 1] = '\0';
+   s[len] = '\0';
   if (!strstr(s, " XPM */"))
      goto quit;