From 5448c43bab7d054dde57dcc50e9d7239ff891729 Mon Sep 17 00:00:00 2001 From: Yeongjong Lee Date: Mon, 9 Dec 2019 12:59:19 -0300 Subject: [PATCH] eolian_mono: remove unused EventArgs parameter of OnXXXEvent Summary: if a event doesn't have `EventArgs`, parameter `EventArgs e` of its OnXXXEvent is naver used. ref T8414 Test Plan: meson setup -Dbindings=mono,cxx -Dmono-beta=true Reviewers: lauromoura Reviewed By: lauromoura Subscribers: cedric, #reviewers, #committers Tags: #efl Maniphest Tasks: T8414 Differential Revision: https://phab.enlightenment.org/D10656 --- src/bin/eolian_mono/eolian/mono/events.hh | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/src/bin/eolian_mono/eolian/mono/events.hh b/src/bin/eolian_mono/eolian/mono/events.hh index abd5368ccd..04789256b8 100644 --- a/src/bin/eolian_mono/eolian/mono/events.hh +++ b/src/bin/eolian_mono/eolian/mono/events.hh @@ -508,10 +508,19 @@ struct event_definition_generator } } + // Close summary + if (!as_generator(scope_tab << "/// \n").generate(sink, nullptr, context)) + return false; + + if (evt.type.is_engaged()) + { + if (!as_generator(scope_tab << "/// Event to raise.\n" + ).generate(sink, nullptr, context)) + return false; + } + if (!as_generator( - scope_tab << "/// \n" - << scope_tab << "/// Event to raise.\n" - << scope_tab << (is_concrete ? "public" : "protected virtual") << " void On" << event_name << "(" << event_args_type << " e)\n" + scope_tab << (is_concrete ? "public" : "protected virtual") << " void On" << event_name << "(" << (!evt.type.is_engaged() ? "" : event_args_type + " e") << ")\n" << scope_tab << "{\n" << scope_tab << scope_tab << "var key = \"_" << upper_c_name << "\";\n" << scope_tab << scope_tab << "IntPtr desc = Efl.EventDescription.GetNative(" << library_name << ", key);\n"