hugok
/
efl
forked from enlightenment/efl
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

edje_cc: fix a memory leak issue when edje_cc writes images 

Summary:
If there is no given pathes for image files as parameter of edje_cc,
"img_dirs" will be NULL. Then, a local variable "load_err" is always
EVAS_LOAD_ERROR_NONE. Because of this, the "if" condition just after
EINA_LIST_FOREACH() will fail. It causes memory leak from "iw".
@fix

Test Plan: N/A

Reviewers: raster, cedric, jpeg, woohyun

Differential Revision: https://phab.enlightenment.org/D5285

Signed-off-by: Cedric Bail <cedric@osg.samsung.com>
This commit is contained in:
Youngbok Shin 2017-10-13 11:55:02 -07:00 committed by Cedric Bail
parent 1f6d3b40e4
commit 5a24f1404a
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/bin/edje/edje_cc_out.c
View File

@ -1390,7 +1390,7 @@ data_write_images(Eet_File *ef, int *image_num)
break;
}
}
if (load_err != EVAS_LOAD_ERROR_NONE)
if (!img_dirs || (load_err != EVAS_LOAD_ERROR_NONE))
{
evas_object_image_file_set(im, img->entry, NULL);
load_err = evas_object_image_load_error_get(im);