From 8912b4aa1d6ddc18a6ead4a612d8d942ab889d63 Mon Sep 17 00:00:00 2001 From: Lucas De Marchi Date: Mon, 11 Oct 2010 19:12:26 +0000 Subject: [PATCH] Simplify the checks in ecore_con_url_http_post_send. By checking for the validity of the Ecore_Con_Url struct before anything else and merging some if's, the code can get much cleaner. By: Raphael Kubo da Costa SVN revision: 53274 --- legacy/ecore/src/lib/ecore_con/ecore_con_url.c | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/legacy/ecore/src/lib/ecore_con/ecore_con_url.c b/legacy/ecore/src/lib/ecore_con/ecore_con_url.c index 0f56b5569b..be64054f08 100644 --- a/legacy/ecore/src/lib/ecore_con/ecore_con_url.c +++ b/legacy/ecore/src/lib/ecore_con/ecore_con_url.c @@ -935,11 +935,6 @@ EAPI Eina_Bool ecore_con_url_http_post_send(Ecore_Con_Url *url_con, void *httppost) { #ifdef HAVE_CURL - if (url_con->post) - curl_formfree(url_con->post); - - url_con->post = NULL; - if (!ECORE_MAGIC_CHECK(url_con, ECORE_MAGIC_CON_URL)) { ECORE_MAGIC_FAIL(url_con, ECORE_MAGIC_CON_URL, @@ -947,14 +942,11 @@ ecore_con_url_http_post_send(Ecore_Con_Url *url_con, void *httppost) return EINA_FALSE; } + if ((url_con->active) || (!url_con->url)) + return EINA_FALSE; + url_con->post = httppost; - if (url_con->active) - return EINA_FALSE; - - if (!url_con->url) - return EINA_FALSE; - curl_easy_setopt(url_con->curl_easy, CURLOPT_HTTPPOST, httppost); return ecore_con_url_send(url_con, NULL, 0, NULL);