From a89186069ed816e6e6cf04aa8502dbfda4128707 Mon Sep 17 00:00:00 2001 From: Chris Michael Date: Thu, 21 Jul 2016 12:58:03 -0400 Subject: [PATCH] elementary: Remove logically dead code Coverity reports that this is logically dead code. As we check the validity of 'model' above this function, then testing 'model' for validity again in this expression is just logically dead. Fixes Coverity CID1356617 @fix Signed-off-by: Chris Michael --- src/lib/elementary/elc_fileselector.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib/elementary/elc_fileselector.c b/src/lib/elementary/elc_fileselector.c index 095ad3a5ea..566aa1e91d 100644 --- a/src/lib/elementary/elc_fileselector.c +++ b/src/lib/elementary/elc_fileselector.c @@ -102,7 +102,7 @@ _elm_fileselector_replace_model(Elm_Fileselector *fs, Elm_Fileselector_Data *sd, if (model && path) { - sd->model = model ? eo_ref(model) : NULL; + sd->model = eo_ref(model); eina_stringshare_replace(&sd->path, path); _monitoring_start(fs, sd, sd->model); /* TODO: sub directory should be monitored for expand mode */