From bbd213bcfb4e8dc3a809b8346cdfba2144f963ed Mon Sep 17 00:00:00 2001 From: Bowon Ryu Date: Fri, 30 Aug 2019 08:47:19 -0400 Subject: [PATCH] elm_entry: add null check logic on elm_entry_text_set API Summary: If current_text is NULL, a segmentation fault is occured. Test Plan: N/A Reviewers: cedric, Hermet, Jaehyun_Cho, zmike Reviewed By: zmike Subscribers: zmike, cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D9780 --- src/lib/elementary/elm_entry.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib/elementary/elm_entry.c b/src/lib/elementary/elm_entry.c index 582762f7b2..317c58f0b2 100644 --- a/src/lib/elementary/elm_entry.c +++ b/src/lib/elementary/elm_entry.c @@ -3365,7 +3365,7 @@ _elm_entry_text_set(Eo *obj, Elm_Entry_Data *sd, const char *part, const char *e /* If old and new text are the same do nothing */ current_text = edje_object_part_text_get(sd->entry_edje, "elm.text"); - if (current_text == entry || !strcmp(entry, current_text)) + if (eina_streq(current_text, entry)) goto done; ELM_SAFE_FREE(sd->text, eina_stringshare_del);