Check the return value of fwrite. There is nothing
sensible to do as the receiver needs to handle the error
gracefully.
CID 1356613, 1356614, 1356615, 1356200
The module was not able to load any PDF with a single page (since
the index starts from 0, not 1 as it was assumed).
Also, fix a CID where Coverity was very very right.
Fixes CID 1356608:
The operaton may have an undefined behavior or yield to an
unexpected result.
In poppler_load_image(int, int): A bit shift operation has
a shift amount which is too large or has a negative value.
technically we dont handle a failed fwrite to stdout according to
coverity, but this is harmless as it doesnt matter if it fails - the
owner process cares. slave does not. silence CID 1356615
Summary: This ports the loader to the stable cpp api.
Test Plan: Please test this patch and tell me if there are differences
Reviewers: DaveMDS
Subscribers: jayji
Differential Revision: https://phab.enlightenment.org/D4039
Now configure should abort in case poppler is not found (unless explicitly disabled)
I'm still not sure about the hard "poppler < 0.40" requirement
added by jpeg yesterday, we should fix the issue instead of
tell "we don't support it"