Summary:
Previously in colorclasses.edc border_frame dialog_base along with other base elements were defined to the default font color "White". This means if you change the default font color there are many unrelated side effects.
To fix this issue i have added a new Color define in colorclasses.edc to be used with window related items as opposed to text related items.
Reviewers: raster
CC: seoz, stefan_schmidt
Maniphest Tasks: T1269
Differential Revision: https://phab.enlightenment.org/D879
Since SHADOW adds one pixel padding, the whole object size
was calculated with one extra pixel. Let's add it back
to keep the overall visual balance of buttons.
A few other widgets might visually change after the edje
padding fix:
- Check (looks better)
- Naviframe (smaller height)
- E date widget
- ...
But I did not see anything "weird" that needs fixing.
See EFL 5bf1f0c9187525cf40782b26d7fa49d2676f91bb:
edje_calc: Don't add padding twice to text objects
Text objects declared in Edje will see their padding added twice,
as the Evas_Object_Text itself contains the padding already.
This WILL break some EDC files. It's a bug nonetheless.
since we're not changing broken default behavior in edje_cc, all newly-compiled .edj files with min: 1 X are now possibly (almost definitely) broken. update text descriptions in other themes as necessary
Summary:
In win.edc add blocker for its content and programs for it. Add
Eina_Bool blocked and was_enabled to _Elm_Menu_Item for correctly blocking
and unblocking of main_menu. They used for saving state which was before modal
win was apeared. Add callbacks and private functions in menu.c for blocking and
unblocking menu. Add integer modal_count to Elm_Win_Smart_Data for creating
enum of modal wins. Add changes in win.c for blocking content, in_focus callback
and menu while modal win is exist.
Reviewers: cedric, seoz, raster
Reviewed By: raster
CC: reutskiy.v.v, raster
Differential Revision: https://phab.enlightenment.org/D607
this adds a hand1 sample cursor theme/image so the theme can find
cursors, (more should be added later), and now actually makes the elm
cursor handling properly set the cursor and update the hotx/y as
needed by tracking the hot swallow object. this relies on a fix in efl
as well.
When focus highlight animation is enabled, focus highlight can be
resized only by animator inside edje. So, if there is no animation
by some reasons, focus highlight just keeps its original.
@fix
this now has elm themes have a version number. we start at 110 (just
matches efl/elm 1.10 that this will be released in) and this means
theme files that do not claim a recent enough version (or claim no
version at all) will not load/be used. default should/would always
provide this so you always will fall back.
Summary:
If item loop feature is enabled, item is moved infinitely.
1. add new widget api - item_loop_enabled
2. add smart event using new config - elm_list.c
3. add demo - test_list.c/list_focus
Reviewers: seoz, woohyun, raster, jaehwan, Hermet
CC: singh.amitesh, c
Differential Revision: https://phab.enlightenment.org/D619
Summary:
Sub components(fields, disable clippers) were shown even if datetime object has no size (0, 0).
To resolve the problem, I made a global clipper,
@fix
Test Plan:
1. create datetime object.
2. evas_object_show without size.
--> datetime object shouldn't be shown
Reviewers: raster, seoz, woohyun, Hermet
CC: seoz
Differential Revision: https://phab.enlightenment.org/D655
compatibility.
- "elm.drag_button,mouse,up" -> "elm,action,up,drag_button"
- "elm.drag_button,mouse,down" -> "elm,action,down,drag_button"
- "elm.drag_button,mouse,move" -> "elm,action,move,drag_button"
This is not the target of backport.
@fix
Summary:
The name of the signal in edc (elm,right,mouse,down) was
different from c (elm.right,mouse,down). After changed
the signal name, mouse event is working as expected.
Test Plan: elementary_test -to actionslider (click right left & center by mouse)
Reviewers: seoz, singh.amitesh
Differential Revision: https://phab.enlightenment.org/D618
Summary:
Implemented the following function
1. _item_unfocused
2. _item_focused
3. _item_focus_up
4. _item_focus_down
5. _item_focus_left : Currently this function return EINA_FALSE. It means focus will move out of genlist to the another left widget
6. _item_focus_right : Currently this function return EINA_FALSE. It means focus will move out of genlist to the right widget
7. _item_focus_set_hook
8. _item_focus_get_hook
9. _elm_genlist_focus_highlight_geometry_get
10. _elm_genlist_focused_item_get
11. Changes in the smart_event, smart_on_focus, pan_smart_calculate, mouse up callback.
Currently selected/focus logic are both present in the smart_event function and its
will be separate out.
Reviewers: seoz, woohyun
CC: singh.amitesh
Differential Revision: https://phab.enlightenment.org/D558
Conflicts:
src/lib/elm_genlist.c
This use the infrastructure of Edje to set the AUTHORS of the theme. It now
make sense to track who did contribute to the theme only. Maybe we could use
those information into Enlightenment About Theme dialog.
Summary:
Previously text colors were specfied in the form color: XXX XXX XXX AAA throughout all the edc files, eg color: 255 255 255 255 this made it imposible to write a script to change text colors with sed as it changed many other parts of the theme as well.
Some colors had been defined in fonts.edc and in some places these were used but not many. This change means that all non textblock font colors are defined in fonts.edc and the defined names are used throughout the entire code base. This means that sed only needs to be run on 1 file to change the text color or it is easy to do manually
textblock colors were not done for 2 reasons
1. They hadn't been done in the past so there was no standard for me to follow.
2. They are all specified in html notation eg #FFFFFF which means that they can be changed with sed without effecting the rest of the theme.
If a standard can be come up with for doing this and people think it is worthwhile i can probably fix them at a later date
Reviewers: raster, zmike
Reviewed By: raster
CC: seoz
Differential Revision: https://phab.enlightenment.org/D577
Conflicts:
data/themes/edc/battery.edc
data/themes/edc/xkbswitch.edc
@feature
Summary:
# Added "item,focused" and "item,unfocused" smart callbacks.
# Added elm_object_focused_item_get() in elm_widget
# Added elm_object_item_focus_set and elm_object_item_focus_get() APIs for
# Added one argument in existing _focus_highlight_geometry_get(...,is_next)
This is required to find out previous and current widget item.
# Added a elm_win function _focus_highlight_start() which starts the focus
Test Plan: elementary_test->List Focus , List Horizontal Focus
Reviewers: seoz, woohyun
Reviewers Comments: SeoZ - there are some known bugs. we will actively
fix them in a near future.
CC: nirajkr
Differential Revision: https://phab.enlightenment.org/D532
This commit add the following new tags:
title, subtitle, bigger, big, small, smaller, code, comment,
string, number, brace, type, class, function, param, keyword,
preprocessor, line_added, line_removed, line_changed.
Tags has been unified in 3 new utility macros:
COMMON_TEXTBLOCK_TAGS, ENABLED_TEXTBLOCK_TAGS, and DISABLED_TEXTBLOCK_TAGS
to avoid repeating too much in the theme.
Also a new test is in: "Entry Style Default" that show all the new styles.
Docs will follow soon.
Summary:
Added noicon menu item state to default menu theme.
Now you can hide icon by setting it to "" (empty string)
Removed check for resetting the same icon name. This allows setting an icon
after it was hidden.
Reviewers: cedric, seoz, raster
Reviewed By: raster
CC: reutskiy.v.v
Differential Revision: https://phab.enlightenment.org/D522
Summary:
When custom style is applyed to menu the same style will be applyed to
its internal hover object.
Moved hover styles used by menu from hover.edc to menu.edc
Reviewers: cedric, seoz, raster
Reviewed By: raster
CC: reutskiy.v.v
Differential Revision: https://phab.enlightenment.org/D514
This reverts commit 3d0eb4137359134eac2c815194a34472e2762c03.
this breaks shadows completely. no more dicking with shadows until the object that they should come from gets finalized.
New icon for the E module as discussed on T427, I'm not
really happy by all the bits but its a good start. Also put
in the inkscape svg mockup file.
Thanks to ragecryx that draw the base icon!
This breaks elementary_config (open it and you'll see the weird bugs on
the top left corner). Please fix it and recommit as needed. I have no
time to dive into naviframe and see what this patch is meant to be
doing.
This reverts commit e3784b68e01849a99e06f31e02192ffb19d1275c.
Summary:
Previously, previous view was hidden by evas_object_hide.
However, this method is no longer correct because size calculation of naviframe causes evas_object_show.
Now, previous view is hidden by emitting signal to naviframe theme and clipper hides the previous view.
Reviewers: Hermet
Reviewed By: Hermet
CC: seoz
Differential Revision: https://phab.enlightenment.org/D484
Summary:
To support naviframe title transition effect, naviframe title enabled APIs are applied.
To remove the duplicate functionalities, naviframe title visible APIs are deprecated.
Reviewers: Hermet
Reviewed By: Hermet
CC: seoz, raster
Differential Revision: https://phab.enlightenment.org/D426
* shadows should be uniformly moved to whatever thing they're supposed to be on (WIP)
* trans-clipper was a failure idea, this is now done in C
* signals renamed to be more consistent
* groups renamed to comp/frame/*
* comp/border/* groups preserved for compat
Panes smart callback depends on the signals from theme but it was broken
when dark theme was introduced.
"clicked" does not work yet, it should be fixed.
Thanks for the report, JackDanielZ.
Summary:
Currently the focus was only on popup-content and popup-action area.
New API elm_layout_content_swallow_list_get() which returns the list of
swallow parts.
Test Plan: elementary_test -to popup. click on "subpopup + X button"
Reviewers: seoz, raster, woohyun
Reviewed By: raster
CC: nirajkr, aryarockstar, kashish
Differential Revision: https://phab.enlightenment.org/D375