Chris Michael
b0fd93a564
Revert "ecore-wayland: Fix formatting"
...
This reverts commit e14f40a46d
.
2014-08-13 10:34:49 -04:00
Chris Michael
3291d32bf9
Revert "ecore-wayland: Add missing EINA_UNUSED for unused function paramater"
...
This reverts commit 67766929ca
.
Revert all the xdg_shell changes. Should not have been pushed due to
new API function.
2014-08-13 10:34:28 -04:00
Chris Michael
75c166cd1d
Revert "Added support for xdg-shell protocol in ecore-wayland."
...
This reverts commit e591dff56d
.
Revert this. Should not have been pushed yet. Sorry Stefan !! :)
2014-08-13 10:29:58 -04:00
Chris Michael
15064d51c9
evas-software-x11: Remove EINA_UNUSED for function paramater that is
...
used
Render_Mode is used here so we don't need EINA_UNUSED for it in the
function.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-08-13 10:23:47 -04:00
Srivardhan Hebbar
e591dff56d
Added support for xdg-shell protocol in ecore-wayland.
...
Summary: Signed-off-by: Srivardhan Hebbar <sri.hebbar@samsung.com>
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric
Projects: #efl
Differential Revision: https://phab.enlightenment.org/D1328
2014-08-13 09:41:27 -04:00
Chris Michael
67766929ca
ecore-wayland: Add missing EINA_UNUSED for unused function paramater
...
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-08-13 09:41:27 -04:00
Chris Michael
e14f40a46d
ecore-wayland: Fix formatting
...
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-08-13 09:41:27 -04:00
Chris Michael
a49835a8d1
ecore-wayland: Calloc Can fail, so check that it works (or return if
...
not).
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-08-13 09:41:27 -04:00
Chris Michael
ff29972703
ecore-wayland: Fix formatting
...
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-08-13 09:41:27 -04:00
vivek
2f4db577b5
Added support for xdg-shell protocol in ecore-wayland
...
Summary: Signed-off-by: vivek <vivek.ellur@samsung.com>
Reviewers: devilhorns
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D1326
2014-08-13 09:41:26 -04:00
Chris Michael
4ad176e481
evas-gl-common: Fix invalid use of Texture
...
We cannot use the texture to find a valid format Before the texture is
actually created. This is invalid, leads to "warning: tex is used
uninitialized' message from the compiler, and just plain wrong.
Instead, use the alpha property of the Evas_GL_Image to find the
proper texture format, Then create the texture.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-08-13 09:38:33 -04:00
Savio Sena
8d3d12282b
autotools: Renamed --disable-c++11 to --disable-cxx-bindings.
...
The name was misleading.
Fix T1438
2014-08-13 10:17:53 -03:00
Savio Sena
07c6cadee3
eolian-cxx: Renamed event_*_callback_{add,call} to callback_*_{add,call}.
2014-08-13 10:17:53 -03:00
Stefan Schmidt
37d20553bd
ecore_drm_dbus: Do not use the same name for global and local variables
...
We use conn here for a global Dbus connection variable as well as sometimes
in a local scope. Better rename the global one to avoid confusion and
potential failures when the code would fallback to the global one even if
the local scope should be used and the var was simply forgotten.
2014-08-13 14:06:18 +02:00
Carsten Haitzler
72f1a2600b
evas 3d - fix error handling for ftell from coverity
...
coverity was right again - CID 1222453 - fix.
2014-08-13 20:57:33 +09:00
Carsten Haitzler
dad62cc323
evas 3d - fix null access for fopen on 3d mesh save
...
this fixes CID 1222455 yes fopen for write may fail!
2014-08-13 20:54:32 +09:00
Carsten Haitzler
0d05039f37
evas key bitshifts for 64bit type - fix.
...
coverity is right. this is another set of thse bitshift problems with
unsigned long long. fix 1224346, 1224345, 1224344 1224343 and 1224342
2014-08-13 20:49:36 +09:00
Carsten Haitzler
f6ef5c229f
edje - remove logically dead code
...
fixes CID 1224348 - coverity is right
2014-08-13 20:46:52 +09:00
Carsten Haitzler
65ec494c32
edje - fix coverity complaint about invalid mem access
...
fixes real issue for invalid object - CID 1224349
2014-08-13 20:39:17 +09:00
Carsten Haitzler
fa5b052911
fix coveirty range complaint on modifer bit mask
...
this fixes CID 1224356, 1224355, 1224354, 1224353 and 1224352
2014-08-13 20:21:14 +09:00
Carsten Haitzler
a44f15ec8e
evas software generic engine - fix tb configuring to be consistent
...
this addresses CID 1224761 - consistent checks for tb in render engine
2014-08-13 19:11:49 +09:00
Carsten Haitzler
f93fb3c7f6
eina thread queue - check write return
...
this addresses CID 1226191. this should never have an error as the fd
should always be valid as long as needed.
2014-08-13 19:06:40 +09:00
Carsten Haitzler
05d839e854
evas gl x11 engine do extra check to make coverity happen
...
this fixes CID 1226192
2014-08-13 18:27:46 +09:00
Carsten Haitzler
e430ee9467
ecore x vsync - be more conservative about DISPLAY string src
...
i hope this addresses CID 1229131 - don't trust the DISPLAY var
content much at all - limit it to [a-z][A-Z][0-9][-] only. hopefully
coverity is happier.
2014-08-13 18:10:58 +09:00
Carsten Haitzler
6f0f046b83
fix eina unicode realloc fix of coverity complaints - return right buf.
2014-08-13 18:01:48 +09:00
Carsten Haitzler
c012e6939c
eina thread queue - fix possible deadlock
...
coverity pointed out a deadlock - CID 1226193. i hope this fixes it
(need to wait days for a coverity re-run). tests pass and real life
usage works, so i assume its ok. in theory i see no problem either.
2014-08-13 17:36:00 +09:00
Carsten Haitzler
970968daab
embyro-cc - fix coverity overruun issue
...
overrun in fatal msg access - fix CID 1039315
2014-08-13 17:14:53 +09:00
Carsten Haitzler
84e032a252
embryo_cc - coverity mem access issue - fix
...
this fixes CID 1039316 in case error num is beyond errmsg bounds
2014-08-13 17:13:12 +09:00
Carsten Haitzler
b0e9886635
embryo_cc - fix coverity buffer overrun
...
fixes CID 1039317
2014-08-13 16:19:17 +09:00
Carsten Haitzler
8ea2356bcd
fix coverity leak detection in ecore_evas_x hints...
...
this fixes CID 1188012
2014-08-13 16:15:42 +09:00
Carsten Haitzler
6974a67f6f
evas - cserve - dummy slave - shut coverity up and unmap mmaped mem
...
while right, coverity doest know that this is just a dummy example,
so... make it happy by unmapping. fixes CID 1193218
2014-08-13 15:24:00 +09:00
Carsten Haitzler
8a7e70705c
fix possible resource leak in edje entry - coverity spotted
...
this should fix CID 1193228
2014-08-13 15:11:06 +09:00
Carsten Haitzler
dcc55bbfd4
eina - and follow-on calloc fixup - 0 terminate first calloced string
...
this follows on from 6dc52db881
2014-08-13 11:52:59 +09:00
Carsten Haitzler
6dc52db881
eina unicode - fix calloc stupidity
...
in looking at CID 1230994 i noticed that eina_unicode_unicode_to_utf8
and eina_unicode_utf8_to_unicode are really dumb. they calloc an array
of bytes then proceed to fill them all in anyway. why? also the
realloc handing in eina_unicode_unicode_to_utf8 wasn't strictly corect
and could leak memory. so this just fixes silly slow code and a leak.
2014-08-13 09:05:37 +09:00
Carsten Haitzler
d539152156
address non nul terminated string due to strncpy
...
this addresses CID 1230994. as such eina_unicode_unicode_to_utf8()
always returns a nul terminated string. so it's guaranteed. but yes -
if string is 7 bytes or longer it will not put a nul byte on the
destination. as such for a single unicode char this can never happen
as in utf8 it's 6 bytes. but since eina_unicode_unicode_to_utf8()
safely returns a nul terminated string at all times - we can just use
strcpy safely. no need for strncpy. also handle null return from
eina_unicode_unicode_to_utf8()
2014-08-13 09:03:02 +09:00
Carsten Haitzler
2ac4f520d6
fix resource leak on format lookup fail
...
so in fixing one CID for a format lookup failing and thus invalid mem
access, a possible leak was made in this case. fix that by doing
lookup before any allocation and if lookup fails, return there
this fixes CID 1230999 1230998 1230997
2014-08-13 08:49:07 +09:00
Carsten Haitzler
c0ca1bcf44
ecore-con - fix possible leak due to other fix
...
this fixes potential leak due to
ff652084e0
fixing a valgrind access
issue. make sure the server is in the list before handling error
conditions in case a callback sets delete_me (should never though).
2014-08-13 08:44:44 +09:00
Carsten Haitzler
db447bece5
fix non 0 terminated buffer in ethmubd slave
...
this fixes a potential non 0 terminated string buffer in ethumb slave
process - harmless for apps, but might happen. this fixes CID 1193232
2014-08-12 22:24:43 +09:00
Cedric BAIL
b91012f62c
autotools: try to simplify our Makefile.am to reduce warnings.
2014-08-12 11:19:57 +02:00
Cedric BAIL
d8dd0e1f62
autotools: use non deprecated macro.
...
I still don't know why there is still a warning.
2014-08-12 11:19:57 +02:00
Cedric BAIL
b7ddba65c8
autotools: do not build upower module on Windows system.
2014-08-12 11:19:57 +02:00
Tom Hacohen
90c0eb15a4
Evas textblock: strcpy->strncpy (although the buffer is always big enough).
...
Many tools will complain about the use of strcpy, and it's not that hard to use
strncpy anyway.
CID1039581.
2014-08-12 10:11:41 +01:00
Tom Hacohen
5d021658ad
Evas bidi: Make code more explicit (silence coverity).
...
CID1039922.
2014-08-12 10:05:52 +01:00
Tom Hacohen
1d6960867d
Evas textblock: remove checks for impossible null derefs.
...
This improves code clarity based on input from coverity.
CID1190401
CID1190402
2014-08-12 09:52:18 +01:00
Tom Hacohen
add6c216a8
Edje dbg_info: Mark root as not null (will never be).
2014-08-12 09:36:37 +01:00
Carsten Haitzler
a97f5d7bb8
evas gl common - fix possible negative array accesses if search format fails
...
this should fix CID 1223506, 1223505, 1223504
2014-08-12 17:32:04 +09:00
Carsten Haitzler
8845ecb2b2
evas gl common - fix potential invalid access during texture free
...
this should address CID 1223507
2014-08-12 17:25:15 +09:00
Gwanglim Lee
55715ccf05
evas-wayland-egl: Add missing free
...
Summary:
Add free to eng_gl_context_free
@fix
Test Plan: N/A
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D1315
2014-08-11 11:47:25 -04:00
Gwanglim Lee
d4c76753c9
evas-wayland-egl: Fix typos about egl context attribute list
...
Summary:
Fix typos 3 to 2.
@fix
Test Plan: N/A
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D1314
2014-08-11 11:45:30 -04:00
Chris Michael
3311729f3c
wayland-egl: Fix Outbuf structure not having evas & engine info
...
gl_generic functions expect the Outbuf to contain the canvas, so we
fixed the eng_window_new function to accept that, And the engine info.
This simplifies the calls to eng_window_new.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-08-11 11:29:33 -04:00