jf_simon
/
enlightenment_my
forked from enlightenment/enlightenment
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

tempget: Check return values from fgets() 

Without this checking we might operate on wrong data read in. Better check.

SVN revision: 71445
This commit is contained in:
Stefan Schmidt 2012-05-26 22:50:06 +00:00
parent 9432f762d0
commit 1ced507bf4
1 changed files with 12 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/modules/temperature/tempget.c
View File

@ -401,7 +401,8 @@ check(void)
{
char dummy[4096];
fgets(buf, sizeof(buf), f);
if (fgets(buf, sizeof(buf), f) == NULL) goto error;
buf[sizeof(buf) - 1] = 0;
if (sscanf(buf, "%s %s %i", dummy, dummy, &temp) == 3)
ret = 1;
@ -417,7 +418,8 @@ check(void)
f = fopen(sensor_path, "rb");
if (f)
{
fgets(buf, sizeof(buf), f);
if (fgets(buf, sizeof(buf), f) == NULL) goto error;
fclose(f);
buf[sizeof(buf) - 1] = 0;
if (sscanf(buf, "%i", &temp) == 1)
@ -434,7 +436,8 @@ check(void)
f = fopen(sensor_path, "r");
if (f)
{
fgets(buf, sizeof(buf), f);
if (fgets(buf, sizeof(buf), f) == NULL) goto error;
buf[sizeof(buf) - 1] = 0;
/* actually read the temp */
@ -453,7 +456,8 @@ check(void)
f = fopen(sensor_path, "r");
if (f)
{
fgets(buf, sizeof(buf), f);
if (fgets(buf, sizeof(buf), f) == NULL) goto error;
buf[sizeof(buf) - 1] = 0;
/* actually read the temp */
@ -474,7 +478,8 @@ check(void)
{
char *p, *q;
fgets(buf, sizeof(buf), f);
if (fgets(buf, sizeof(buf), f) == NULL) goto error;
buf[sizeof(buf) - 1] = 0;
fclose(f);
p = strchr(buf, ':');
@ -497,7 +502,8 @@ check(void)
f = fopen(sensor_path, "r");
if (f)
{
fgets(buf, sizeof(buf), f);
if (fgets(buf, sizeof(buf), f) == NULL) goto error;
buf[sizeof(buf) - 1] = 0;
fclose(f);
temp = atoi(buf);