jf_simon
/
enlightenment_my
forked from enlightenment/enlightenment
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

gadgets: pager (fix crash on mouse up). 

Summary:
Animator was crashing due to invalid memory access.

This resolves this problem.

Test Plan:
* Add new gadget pager to desktop/bryce.
* Move window within pager boundaries.
* Finish window drag within pager.
* CRASH of animator thread (or worse).
* Apply patch.
* Use new peger without fear of disaster.

Reviewers: raster, zmike, cedric, stephenmhouston, devilhorns

Reviewed By: zmike

Tags: #enlightenment-git

Differential Revision: https://phab.enlightenment.org/D7536
This commit is contained in:
Alastair Poole 2019-01-03 18:51:08 +00:00
parent a19c968973
commit 569722a4ed
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/modules/pager/gadget/pager.c
View File

@ -2423,6 +2423,10 @@ _pager_desk_cb_mouse_up(void *data, Evas *e EINA_UNUSED, Evas_Object *obj EINA_U
Pager_Desk *pd;
Pager *p;
pd = data;
if (!pd) return;
if (ev->event_flags & EVAS_EVENT_FLAG_ON_HOLD)
{
pd->drag.start = 0;
@ -2431,9 +2435,6 @@ _pager_desk_cb_mouse_up(void *data, Evas *e EINA_UNUSED, Evas_Object *obj EINA_U
}
if (_pager_check_modifiers(ev->modifiers)) return;
pd = data;
if (!pd) return;
p = pd->pager;
/* FIXME: pd->pager->dragging is 0 when finishing a drag from desk to desk */