Commit Graph

12173 Commits

Author SHA1 Message Date
Mike Blumenkrantz f8efeed3e8 fix in-place directory opening in efm: statinfo resolves link targets now, so only call "selected" if link target is not a directory
ticket #1863


SVN revision: 80026
2012-12-03 08:57:15 +00:00
Mike Blumenkrantz 362531b082 Dear all,
I'm attaching a patch for some minor bugs in the e17.
 Please take a look at attached patch.

 01. missing E_FREE(inst)
     File: src/bin/e_exec.c: 347
     Function: _e_exec_cb_exec

 02. missing null check
     File: src/bin/e_fm.c: 10173
     Function: _e_fm_error_dialog
     I'm not sure, but all other codes always check the return
     value of e_fm2_op_registry_entry_get except here.

 03. missing free(slave)
     File: src/bin/e_fm_ipc.c: 804
     Function: _e_fm_ipc_slave_run

 04. eina_list_remove after free
     File: src/bin/e_fm/e_fm_ipc.c :1325
     Function: _e_fm_ipc_cb_fop_trash_idler

 05. invalid check for _udisks_del, it might be _udisks_chg.
     File: src/bin/e_fm/e_fm_main_udisks.c : 162
     Function: _e_fm_main_udisks_test

 06. uninitialized gx and gy values
     File: src/bin/e_gadcon_popup.c: 172
     Function: _e_gadcon_popup_position
     These could be changed in e_gadcon_client_geometry_get
     if gcc->o_base is null.

 07. unnecessary code 'evas = e_win_evas_get(dia->win)'
     File: src/bin/e_import_config_dialog.c: 456
     Function: e_import_config_dialog_show

 08. missing free(sizes)
     src/bin/e_randr_11_serialization.c: 136
     Function: _11_try_restore_configuration()

 09. unnecessary variable output_info
     File: src/bin/e_randr_12.c: 560
     Function: _output_property_change_event_cb

 10. eina_list_remove after free
     File: src/bin/e_randr_12_serialization.c : 357
     Function: _12_serialized_setup_update

 11. no check of the return value of symlink.
     File: src/bin/e_widget_fsel.c: 84
     Function: _e_wid_fsel_favorites_add

 12. no evr->var check before comparing string values
     File: src/modules/conf_applications/e_int_config_defapps.c: 432
     Function: _basic_apply

 13. missing error message or check return value of edje_file_group_exists
     File: src/modules/conf_theme/e_int_config_theme.c: 333
     Function: _open_test_cb
     Anyway, I've added e_util_dialog_show if failed. Is it okay?

 14. missing index range check
     File: src/modules/gadman/e_mod_config.c: 153
     Function: _cb_config
     It could read negative array index, because return value of
     e_widget_ilist_selected_get might be negative.

 BR,
 Gwanglim


SVN revision: 80020
2012-12-03 07:54:07 +00:00
Bruno Dilly 17e0f6d24a e/connman: use zone percentage for popup list
Initially try to set the popup list as w = 30%,
h = 40%, but keep it in min / max limits.



SVN revision: 80001
2012-12-03 03:38:58 +00:00
Carsten Haitzler 5f4189636d theme isnt gtk specific for apps... especially not icon theme.
SVN revision: 79999
2012-12-03 01:45:11 +00:00
Carsten Haitzler 63286be95d lets make e_alert noto also be bag with valgrind eh?
SVN revision: 79998
2012-12-03 00:46:34 +00:00
Carsten Haitzler 8fa7ba94bb doing configure checks for arpa/inet.h and so on is all fine and
great.. but if the src file htis was intended for doesn't include e.h
so it include config.h... then its kind of pointless isn't it? :)



SVN revision: 79997
2012-12-03 00:27:52 +00:00
Mike Blumenkrantz 97a7e3affb cast to void in delete macro
SVN revision: 79986
2012-12-02 19:27:25 +00:00
Mike Blumenkrantz dfe7117ba6 force enable gc edit flag if gcc is being edited to prevent crash when deleting just-added gadman gadgets from dialog
SVN revision: 79972
2012-12-01 16:08:39 +00:00
Carsten Haitzler 93289954af oh - this was irking me - client region of comp preview was pure solid
white. not nice. make it semit-trans black. :) should work better on
more themes.



SVN revision: 79971
2012-12-01 16:08:32 +00:00
Boris Faure aaf43c0bad e:tiling: disabling module restores original borders and sizes
SVN revision: 79965
2012-12-01 13:53:51 +00:00
Mike Blumenkrantz 18ceb3defd formatting by request
SVN revision: 79962
2012-12-01 08:42:33 +00:00
Vincent Torri ffe6ab106c E17: fix warning on freebsd
Patch by Maxime Villard (rustyBSD)


SVN revision: 79961
2012-12-01 07:22:31 +00:00
Vincent Torri 688aa066a1 E17: define htonl correctly
SVN revision: 79960
2012-12-01 07:19:18 +00:00
Carsten Haitzler 6eae31c107 as part of theme redo.. i get to find all the evil little "didnt
namespace this" stuff... fix namespacing of bat popup with fallback to
old one.



SVN revision: 79958
2012-12-01 04:22:05 +00:00
Sebastian Dransfeld af9abdede9 e/wizard: this is a file, not dir
SVN revision: 79953
2012-11-30 21:46:53 +00:00
Sebastian Dransfeld 6998babefc e/wizard: check if icon theme cache already exists
SVN revision: 79952
2012-11-30 21:38:08 +00:00
Mike Blumenkrantz 011dfdccf5 only block fsel updating if path is already set
SVN revision: 79951
2012-11-30 21:26:24 +00:00
Sebastian Dransfeld 5d64abb461 e: omit path in .desktop file if in xdg dir
SVN revision: 79950
2012-11-30 21:25:30 +00:00
Mike Blumenkrantz 43be5378b6 ensure restart always occurs after language change
SVN revision: 79947
2012-11-30 20:12:46 +00:00
Mike Blumenkrantz 21c5355c18 remove menu fixme
SVN revision: 79946
2012-11-30 20:04:11 +00:00
Mike Blumenkrantz 700373e3dd wizard now uses inlist
SVN revision: 79911
2012-11-30 15:48:52 +00:00
Mike Blumenkrantz 1eda0a3417 some text fixes from thomasg
SVN revision: 79910
2012-11-30 15:39:17 +00:00
Mike Blumenkrantz c6a9c34e7f giant header overhaul which removes all the stupid one line function prototype headers and e_mod_main.h headers that contain nothing but unnecessary module api prototypes
SVN revision: 79908
2012-11-30 14:38:34 +00:00
Mike Blumenkrantz 5b0d598091 only set mixer volume if we've truly saved mixer volume, prvents mixer being muted every time wizard is run
SVN revision: 79889
2012-11-30 12:55:47 +00:00
Mike Blumenkrantz 49f4670d7b cached menus now listen to efreet cache update events
ticket #1888


SVN revision: 79883
2012-11-30 11:50:21 +00:00
Mike Blumenkrantz 4e500e5767 huge wizard commit:
* disable all dummy wizard callbacks in pages
* shutdown callbacks in pages are now actually called
* pages are no longer shown repeatedly by xdg wait callback
* first page no longer accidentally the whole second page
* scaling initially set to 1.2 so the text is actually readable
* page states added so we have some idea where the hell the pages are at
ticket #1883


SVN revision: 79879
2012-11-30 10:46:48 +00:00
Mike Blumenkrantz 6502761657 fix dangling gadman gadgets during dnd and fix edit mode toggling when gadgets are dragged in and out of desktop gadcon
SVN revision: 79876
2012-11-30 08:52:57 +00:00
Mike Blumenkrantz fbc12f2e3f only save gcc during edit end if the gcc has a config
SVN revision: 79875
2012-11-30 08:50:12 +00:00
Mike Blumenkrantz a7cea557ee fix some pulse shutdown magic fails
SVN revision: 79874
2012-11-30 08:49:31 +00:00
Christopher Michael 9b465c8a95 Add ECORE_X_CURSOR_EXCHANGE to e_pointer for a 'rotate' cursor.
Signed-off-by: Christopher Michael <cp.michael@samsung.com>

SVN revision: 79867
2012-11-30 07:26:19 +00:00
Mike Blumenkrantz 9f24a15665 E17 is no longer in birthday mode :(
SVN revision: 79866
2012-11-30 07:04:48 +00:00
Bruno Dilly 526c7c3680 e/connman: increase networks popup size
Requested by tasn.
I was a bit conservative here.



SVN revision: 79843
2012-11-29 17:02:26 +00:00
Bruno Dilly 77d0c34587 e/connman: just update popup list at each 5 secs
If time is not good enough, can be fine tunned
very easily (just change the define).

I couldn't test this commit, so if tasn
or other could, it would be great.

I believe it won't be a perfect solution
yet, since this way it will take some time
to confirm visually the network states
(association / configuration / connect)
in the popup. We need to handle this
case properly (if I'm correct).



SVN revision: 79842
2012-11-29 16:53:29 +00:00
Mike Blumenkrantz 98a1ef6bd1 more gadman dnd rewrites to fix this stupid, awful piece of garbage that I can't wait to delete.
ticket #1820 (again)


SVN revision: 79841
2012-11-29 16:03:54 +00:00
Mike Blumenkrantz fd95d45c9b okay, only try the gadcon config gcc unref if it's a custom gadcon that's editing
SVN revision: 79840
2012-11-29 16:02:33 +00:00
Mike Blumenkrantz 2a6d8d9f74 unref drag gcc when deleting gcc from gc config dialog to ensure it is deleted properly
SVN revision: 79837
2012-11-29 15:22:12 +00:00
Mike Blumenkrantz 6600e453ec delete gcc drag object if it exists when gcc is deleted
SVN revision: 79836
2012-11-29 15:19:24 +00:00
Mike Blumenkrantz f371980da8 entry leak--
SVN revision: 79835
2012-11-29 15:06:32 +00:00
Mike Blumenkrantz 3f8c09d6a0 fix continual leak in efm file names
SVN revision: 79834
2012-11-29 15:02:00 +00:00
Mike Blumenkrantz c21b0240ba don't show gcc drag object when dragging desktop icons on same zone
SVN revision: 79833
2012-11-29 13:42:42 +00:00
Mike Blumenkrantz d7a5385b2b only run a gadcon populate event after module init end
SVN revision: 79829
2012-11-29 12:15:50 +00:00
Mike Blumenkrantz 6d4150fcad increase shelf show timeout after module init end
SVN revision: 79828
2012-11-29 12:15:11 +00:00
Mike Blumenkrantz 25853a0c2a fix possible null deref crash when deleting gadcon client config
SVN revision: 79827
2012-11-29 11:48:34 +00:00
Mike Blumenkrantz ab52c7a2ee unselecting all ilist items will no longer fail to unselect all ilist items
SVN revision: 79826
2012-11-29 11:25:02 +00:00
Mike Blumenkrantz af38ddf0a6 delete any invalid gadcon clients for custom gadcons since we don't validate as much here
SVN revision: 79823
2012-11-29 10:09:28 +00:00
Mike Blumenkrantz 11fb8c3858 fix uk flag image in wizard
SVN revision: 79822
2012-11-29 09:09:03 +00:00
Mike Blumenkrantz 8db2b8bb69 disable "internal_fileman" border setting since there's no theme which supports it and all it does is break border config
ticket #1830


SVN revision: 79820
2012-11-29 08:57:20 +00:00
Mike Blumenkrantz eb2ae4dfb2 improve and homogenize system action dialog texts
SVN revision: 79817
2012-11-29 07:20:17 +00:00
Mike Blumenkrantz d9792a7777 improve randr rotate snapping calculations
SVN revision: 79815
2012-11-29 06:59:29 +00:00
Mike Blumenkrantz 82ab56808b fix randr config registry name, fixes reopen on restart
SVN revision: 79809
2012-11-29 05:40:35 +00:00
Mike Blumenkrantz 1af4e65b56 fix shelf crash when attempting to animate an autohide during screen rotation
SVN revision: 79804
2012-11-29 05:23:52 +00:00
Mike Blumenkrantz 7f9e4979fc fix gadman crash when container shape changes
SVN revision: 79803
2012-11-29 05:19:41 +00:00
Mike Blumenkrantz 397b96574b more exchange cruft
SVN revision: 79802
2012-11-29 05:01:42 +00:00
Mike Blumenkrantz fff13bc94a fix gadget popup positioning bug for top/left shelves
SVN revision: 79801
2012-11-29 04:31:23 +00:00
Mike Blumenkrantz bd19ea1330 fix max menu size clamping
ticket #1691


SVN revision: 79800
2012-11-29 03:02:16 +00:00
Mike Blumenkrantz b75f8bf596 for the next 24 hours, E17 is in BIRTHDAY MODE!!!!!!!!!!!!!!!!!
HAPPY BIRTHDAY RASTER!


SVN revision: 79798
2012-11-29 02:30:06 +00:00
Davide Andreoli cd0fdfc3a7 filema_opingo gadget: when an operation need attention show a red led with a strobe (similar to terminology).
when the led is shown the user can press the notification to jump to the relative window.

NOTE:Atm this is implemented only in the gadget, if no one object I will port also in the filman window.

raster: hope your eagle-eye will like ;)




SVN revision: 79792
2012-11-28 22:38:34 +00:00
Mike Blumenkrantz 0ccafb765f notification module no longer has a broken and buggy gadget. bug hunters everywhere rejoice in the streets
SVN revision: 79773
2012-11-28 10:05:21 +00:00
Shinwoo Kim da0c0f3eb7 [access] enhance access features
1. support double down and move
  2. add debug related label - would be better to be configurable



SVN revision: 79772
2012-11-28 08:34:40 +00:00
Carsten Haitzler ef76974ffc lets not break dnd onto dirs.. within the same efm view.
SVN revision: 79763
2012-11-28 04:11:33 +00:00
Carsten Haitzler 022e768010 fix segv in efm! dnd 2 files into another dir - yay!
SVN revision: 79762
2012-11-28 03:51:24 +00:00
Tom Hacohen 81efa66d66 E entry: Use stringshare instead of strdup.
The string is usually shared already and this saves us the allocation.

SVN revision: 79753
2012-11-27 18:14:03 +00:00
Tom Hacohen cf7f76c329 E entry: Fix password mode toggle.
It's just a straightforward fix. Some cleanup is needed there to make
everything nicer, but that's not important for the time being as it'll be
replaced with elm_entry "soon" anyway.

SVN revision: 79750
2012-11-27 15:50:53 +00:00
Carsten Haitzler b1b5f7c09d less offensive import dialog layout. :)
SVN revision: 79742
2012-11-27 10:45:09 +00:00
Sebastian Dransfeld 80decbdb9e e/wizard: better implementation of xdg wait
SVN revision: 79741
2012-11-27 10:13:41 +00:00
Cedric BAIL 85b27ab7e3 e: detect when sysactions.conf doesn't let us run gdb.
SVN revision: 79731
2012-11-27 03:48:05 +00:00
Davide Andreoli 003fa1bfbd Revamp the fileman-operation-info desktop gadget using the same theme as efm.
Some feature are lost (window jump and detailed info), hope I can work on that
in the next few days.
Also updated the module icon.



SVN revision: 79728
2012-11-26 23:53:24 +00:00
Mike Blumenkrantz 16fc340345 "Show Calendar" action correctly renamed to "Toggle Calendar"
SVN revision: 79720
2012-11-26 14:13:21 +00:00
Mike Blumenkrantz 2ac82d5a0c gadcon popups will no longer pop over the gadget if popping for a shelf in autohide mode
SVN revision: 79719
2012-11-26 14:10:00 +00:00
Mike Blumenkrantz e2a529f0dc click focus in wizard now unsets winlist pointer warping
SVN revision: 79718
2012-11-26 13:37:19 +00:00
Mike Blumenkrantz fd5d4bedb2 resetting keybindings no longer creates bindings with ctrl+shift left/right which may block selection attempts
SVN revision: 79714
2012-11-26 13:00:09 +00:00
Mike Blumenkrantz f1aeea751f it is no longer possible to add blank edge bindings
SVN revision: 79712
2012-11-26 12:56:58 +00:00
Mike Blumenkrantz 6fb9514d9e edge binding grab dialog can no longer outlive the edge bindings config dialog, preventing a crash and other awkward behavior
SVN revision: 79711
2012-11-26 12:51:01 +00:00
Carsten Haitzler 50f83c3db9 chlog isnt being used :)
SVN revision: 79710
2012-11-26 12:41:29 +00:00
Carsten Haitzler 4dcc47508e merge authors in from tiling.
SVN revision: 79709
2012-11-26 12:41:09 +00:00
Sebastian Dransfeld 8ddf5f934b e/wizard: improve waiting for cache build
SVN revision: 79708
2012-11-26 12:40:31 +00:00
Carsten Haitzler 8e103026d9 remove authors too - merged
SVN revision: 79707
2012-11-26 12:40:03 +00:00
Carsten Haitzler 0598a7a710 merge notification with AUTHORS and remove duplicatre files. icon also
now trimmed. also use propr module namespacing for theme.



SVN revision: 79706
2012-11-26 12:37:34 +00:00
Sebastian Dransfeld d31424391e TODO++
SVN revision: 79702
2012-11-26 12:28:04 +00:00
Mike Blumenkrantz 327391da95 new wizard page to enable tasks by default
ticket #1663


SVN revision: 79701
2012-11-26 11:58:04 +00:00
Mike Blumenkrantz 4c10701ee3 connman wizard page now always shows, but changes text and disables default conf connman gadget if connman support disabled
SVN revision: 79697
2012-11-26 11:30:16 +00:00
Carsten Haitzler ec20c1f9c5 eww notification gagdte box... nasty stuff. needs work.
SVN revision: 79695
2012-11-26 11:09:45 +00:00
Mike Blumenkrantz c244e1f9b7 module config dialog now listens for module status update events and adjusts module status accordingly
ticket #1816


SVN revision: 79693
2012-11-26 10:58:58 +00:00
Mike Blumenkrantz 8debb65fce simplify comp module dropshadow disable detect
SVN revision: 79692
2012-11-26 10:37:52 +00:00
Mike Blumenkrantz 0f46bd2d98 module update event module name is now stringshared
SVN revision: 79691
2012-11-26 10:30:00 +00:00
Mike Blumenkrantz 5e6b21a3e4 ensure wizard waits for cache rebuild, reduce delay after rebuild
ticket #1838


SVN revision: 79690
2012-11-26 10:20:34 +00:00
Carsten Haitzler 0683ecf7b3 ummm pager - when dragging a whole DESKTOP... dont set a white bg..
theme haqndles this with the pager setup itself.



SVN revision: 79689
2012-11-26 10:13:54 +00:00
Mike Blumenkrantz c85681718a max efm thumbnail size slider now uses smaller increments
SVN revision: 79688
2012-11-26 10:13:37 +00:00
Carsten Haitzler 8f03dcc9ed dont hardcode overlay part as its not namespace - accept right click
on ANYTHING to stop move/resize in gadman.



SVN revision: 79686
2012-11-26 10:06:50 +00:00
Mike Blumenkrantz bc6bd1b4c5 typo in previous fileman commit, unbreak desktop path setting
SVN revision: 79685
2012-11-26 10:01:55 +00:00
Mike Blumenkrantz 2d1f1ba0d0 new ibar sources now try to copy default source before writing dummy source
SVN revision: 79684
2012-11-26 09:59:44 +00:00
Mike Blumenkrantz d8edcec5f1 add function for cloning an e_order
SVN revision: 79683
2012-11-26 09:36:11 +00:00
Mike Blumenkrantz 4d92a1de3c patch from Deon Thomas fixing some lost window behavior bugs
ticket #1821


SVN revision: 79681
2012-11-26 09:09:16 +00:00
Mike Blumenkrantz 90ab501433 efm no longer restores non-default desktop paths if desktop navigation option is disabled
ticket #1835


SVN revision: 79680
2012-11-26 09:01:26 +00:00
Sebastian Dransfeld 20efaa2d66 e: try to improve text
SVN revision: 79679
2012-11-26 09:01:25 +00:00
Sebastian Dransfeld 4de7b95f4a e: honor XDG_DESKTOP_DIR
SVN revision: 79678
2012-11-26 08:45:03 +00:00
Sebastian Dransfeld f5c645b793 e: keep code in same scope
SVN revision: 79677
2012-11-26 08:44:47 +00:00
Mike Blumenkrantz 011b6c7b02 NULL check gadcon dnd enter events so we don't crash on efm drag operations
ticket #1820


SVN revision: 79676
2012-11-26 08:29:22 +00:00
Mike Blumenkrantz 8d30916e09 set flag in fsel for when preview is a directory so we can grab the right path
ticket #1815


SVN revision: 79675
2012-11-26 08:16:25 +00:00
Carsten Haitzler 92d53b87a5 and remvoe debugging.
SVN revision: 79670
2012-11-26 06:40:35 +00:00