Summary: If we get here when curpage is NULL, we'll crash later, so we should test for it.
Reviewers: zmike
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D2793
Summary: If we get here when curpage is NULL, we'll crash later, so we should test for it.
Reviewers: zmike
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D2789
str(n)dupa are GNU extensions that duplicate a string, using an alloca'd
buffer. This patch removes their definitions from e.h (which should only
contain E's own API, without fallback definitions for libc functions)
which were wrong anyway (they failed in cases where str(n)dupa was an
actual function, not a macro).
Instead, we replace them depending on context with alloca+memcpy+strlen
or a static buffer (used in contexts where we are sure that the buffer
will contain the string entirely)
@fix
Summary:
@fix The list of icon themes in the search list is quite out of date
it doesn't include the icon themes used by gnome3 or kde4/5 this means
for a lot of users at first boot e has alot of missing icons.
The Icon sets that have been added are as follows
"Oxygen", /* KDE 4 */
"Adwaita", /* Gnome 3 */
"Breeze", /* KDE 5 */
"HighContrast"
This change will cause T1732 and T1923 to not occur for almost all users
but it does not fix them properly the code should be modified to fall back
to pick up icons from fallback locations such as the hicolor theme if no
icon theme is set.
It would be nice if someone could backport this to e19 I don't know how to
Reviewers: bu5hm4n, zmike, raster
Reviewed By: raster
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D2377
there is only one E_Comp which can now be accessed by the e_comp global.
if you're editing a file with some uses of these deprecated functions, replace their usages with appropriate references to this variable
pass -Wno-deprecated-declarations to ignore these warnings during build
Summary:
Commit rE5b992bdc4a76 added the free for the list, the list is filed
with static pointers from the .c file, soo free will crash.
This pointer does not need to be freed, just freeing the list.
Test Plan: Just run the wizard
Reviewers: zmike
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D1679
There was a bug there, that caused the one after the standard to be
selected, instead of the standard one.
This was caused because directories and the default profile were not
properly ignored.
this option provides the functionality which was intended by the old and broken "raise on focus" option. it raises windows ONLY when reverting focus in cases not directly triggered by the user or any application
huge fustercluck commit because there wasn't really a way to separate out the changes. better to just rip it all out at once.
* compositor and window management completely rewritten. this was the goal for E19, but it pretty much required everything existing to be scrapped since it wasn't optimized, streamlined, or sensible. now instead of having the compositor strapped to the window manager like an outboard motor, it's housed more like an automobile engine.
** various comp structs have been merged into other places (eg. E_Comp_Zone is now just part of E_Zone where applicable), leading to a large deduplication of attributes
** awful E_Comp_Win is totally dead, having been replaced with e_comp_object smart objects which work just like normal canvas objects
** protocol-specific window management and compositor functionality is now kept exclusively in backend files
** e_pixmap api provides generic client finding and rendering api
** screen/xinerama screens are now provided directly by compositor on startup and re-set on change
** e_comp_render_update finally replaced with eina_tiler
** wayland compositor no longer creates X windows
** compositor e_layout removed entirely
* e_container is gone. this was made unnecessary in E18, but I kept it to avoid having too much code churn in one release. its sole purpose was to catch some events and handle window stacking, both of which are now just done by the compositor infra
* e_manager is just for screensaver and keybind stuff now, possibly remove later?
* e_border is gone along with a lot of its api. e_client has replaced it, and e_client has been rewritten completely; some parts may be similar, but the design now relies upon having a functional compositor
** window configuration/focus functions are all removed. all windows are now managed solely with evas_object_X functions on the "frame" member of a client, just as any other canvas object can be managed.
*** do NOT set interceptors on a client's comp_object. seriously.
* startup order rewritten: compositor now starts much earlier, other things just use attrs and members of the compositor
* ecore_x_pointer_xy_get usage replaced with ecore_evas_pointer_xy_get
* e_popup is totally gone, existing usage replaced by e_comp_object_util_add where applicable, otherwise just placed normally on the canvas
* deskmirror is (more) broken for now
* illume is totally fucked
* Ecore_X_Window replaced with Ecore_Window in most cases
* edge binding XWindows replaced with regular canvas objects
* some E_Win functionality has changed such that delete callbacks are now correctly called in ALL cases. various dialogs have been updated to not crash as a result
comp files and descriptions:
e_comp.c - overall compositor functions, rendering/update loop, shape cutting
e_comp_x.c - X window management and compositor functionality
e_comp_wl.c - Wayland surface management and compositor functionality
e_comp_canvas.c - general compositor canvas functions and utilities
e_comp_object.c - E_Client->frame member for managing clients as Evas_Objects, utility functions for adding objects to the compositor rendering systems
additional authors: ivan.briano@intel.com
feature: new compositor
removal: e_border, e_container, e_popup
this adds moldova (moldavian?) flag for layouts of keyboards and
refreshes some of the generic images for unknown, latin america, brail
and arabic "flag" images, and forces flag icons to be 2:1 aspect
ration with icon centered within that area to address T647
if someone were to ... replace the default theme... and would be missing
groups... in theory the min size calc may fail thus leaving min w/h
unset, so just set them anyway.
buckle up. for the first time in history, a config option is getting removed instead of added.
the reasons for this removal are many, but let's go way back to the beginning and see why it was added:
oh wait, we can't because the commit message (from 2006) is
>> patches that i said were in - commit. (see my reply emails)
>> also finish off a TODO item or 2
reading through the TODO items which were also crossed off in that commit, I'm assuming that this was the "option to NOT raise on focus in click to focus" item.
== REASON 1 ==
the problem here is that there's another, BETTER option called "click raises window" (always_click_to_raise) which does the same thing, except it doesn't totally fuck you when you get a random X focus event, which happens more often than you might think.
this means that, to avoid broken behavior which might cause your windows to spastically raise for a few frames in common cases (using winlist...) with click-to-focus, you have to know that this is the default-enabled option that's fucking you, and you have to remember to manually disable it every time. if you DON'T know that this is the option that's fucking you, and you just see windows randomly raising on their own, you'll probably either ignore it or file a bug, when this is supposed to be a "feature" that actually worked in reverse, since it was intended only for disabling.
== REASON 2 ==
there's also auto-raise, which can be set to 0.0s, which is effectively the same thing since it also triggers on focus but can be configured not to fuck your window stack
== REASON 3 ==
aaand finally, this option makes any sort of pointer focus model impossible to use, since your windows will constantly be raising all over as you move the mouse
tl;dr: I'm removing it, e-dealwithit.gif
this was, I guess, an attempt to provide users with an easily accessible ibar icon when starting a new config. problem: xterm isn't installed by default on ANY distributions! so now we end up providing a launcher which is guaranteed to fail, and that makes us look pretty stupid. same thing goes for mplayer.
regardless of whether they're installed, however, these aren't our apps, so we shouldn't be trying to provide .desktops for them: doing that tell users that we support and recommend the use of these apps, and I'm not prepared to make that claim for any app other than powerpoint.
Implemented temp sensor detection for linux, it is basically a light
detection, most info came from the temperature module,
_wizard_temperature_get_bus_files == temperature_get_bus_files from
temperature module. tested on 4 systems, and one really old system
which does not have sensors and it seems to work very good.
* added a number of new e_comp functions and macros
* options for disabling effects on objects: this option does not currently have any effect
* all modules which used gadcon popups have been adjusted
* all modules which used input windows to detect close events for gadcon popups have been adjusted to use new popup autoclose functionality
* shelves are now always drawn on the compositor canvas, meaning objects will never get clipped by the shelf (ticket #1810)
* shelves no longer have an event object
SVN revision: 84060
* Move compositor to core, but letting the configuration there
* Rename all files and functions from e_mod_comp_* to e_comp_*
* Move the config dialogs to a new module named conf_comp. It still
uses a domain config, otherwise it would not pick the current
user's configuration. Maybe it would be wise to later on move these
options to e_config
* Fixup the wizard mess linking the header in the build tree in order
to be able to create the config. Since now it's in core, we don't
need to play linking games in the build system
I'm not sure if the wayland part works. It was not even building
previously so I'll let for who cares about this to actually test and
report bugs.
SVN revision: 82454
dropshadow module conflicts with composite, which will be always enabled
by future commits. Remove the module to allow turning composite as
always-enabled.
SVN revision: 82224
We were missing a edbus_connection_unref() + edbus_shutdown() in case
neither connman responded or the timetout triggered. It's actually
easier to only shutdown edbus when page is hidden.
SVN revision: 81983
* disable all dummy wizard callbacks in pages
* shutdown callbacks in pages are now actually called
* pages are no longer shown repeatedly by xdg wait callback
* first page no longer accidentally the whole second page
* scaling initially set to 1.2 so the text is actually readable
* page states added so we have some idea where the hell the pages are at
ticket #1883
SVN revision: 79879
by having a disabled button "next" doesn't tell much to the user except
a feeling of "the button not works", instead of that, when disabled the
text should be changed to something like "please wait"
Patch by Thanatermesis <thanatermesis.ecvs@gmail.com>.
SVN revision: 79662
return value. it WAITS for efreet to be happy and give an update
event. this event doesnt come and thats currently some efreet bug.
SVN revision: 79120
Simon Lees
Mike Blumenkrantz
Derek Foreman
Daniel Kolesa
Chris Michael
Marcel Hollerbach
kabeer khan
maxerba
Mike Blumenkrantz
Sebastian Dransfeld
Cedric BAIL
Thanatermesis
Tom Hacohen
Carsten Haitzler
Mike Blumenkrantz
Igor Murzov
discomfitor
Deon Thomas
Lucas De Marchi
José Roberto de Souza
Cedric BAIL
Vincent Torri