jsuya
/
efl
forked from enlightenment/efl
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Evas filters: Prevent division by zero 

These can not happen, as all weights > 0.
Add a CRI message in case of div0.
Fixes CID 1174081, CID 1174080.
This commit is contained in:
Jean-Philippe Andre 2014-02-14 11:23:04 +09:00
parent 568c014dc9
commit eb1c452156
1 changed files with 14 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/lib/evas/filters/evas_filter_blur.c
View File

@ -452,6 +452,7 @@ _gaussian_blur_step_alpha(DATA8 *src, DATA8 *dst, int radius, int len, int step,
acc += (*s) * weights[j + radius - k];
divider += weights[j + radius - k];
}
if (!divider) goto div_zero;
*dst = acc / divider;
}
@ -476,8 +477,14 @@ _gaussian_blur_step_alpha(DATA8 *src, DATA8 *dst, int radius, int len, int step,
acc += (*s) * weights[j];
divider += weights[j];
}
if (!divider) goto div_zero;
*dst = acc / divider;
}
return;
div_zero:
CRI("Division by zero avoided! Something is very wrong here!");
}
static void
@ -504,6 +511,7 @@ _gaussian_blur_step_rgba(DATA32 *src, DATA32 *dst, int radius, int len, int step
acc[BLUE] += B_VAL(s) * weights[weightidx];
divider += weights[weightidx];
}
if (!divider) goto div_zero;
A_VAL(dst) = acc[ALPHA] / divider;
R_VAL(dst) = acc[RED] / divider;
G_VAL(dst) = acc[GREEN] / divider;
@ -542,11 +550,17 @@ _gaussian_blur_step_rgba(DATA32 *src, DATA32 *dst, int radius, int len, int step
acc[BLUE] += B_VAL(s) * weights[j];
divider += weights[j];
}
if (!divider) goto div_zero;
A_VAL(dst) = acc[ALPHA] / divider;
R_VAL(dst) = acc[RED] / divider;
G_VAL(dst) = acc[GREEN] / divider;
B_VAL(dst) = acc[BLUE] / divider;
}
return;
div_zero:
CRI("Division by zero avoided! Something is very wrong here!");
}
static void