From 38ae2285ec65732411830c5e50247187dc4fde08 Mon Sep 17 00:00:00 2001 From: Dave Andreoli Date: Mon, 9 Jul 2018 22:36:55 +0200 Subject: [PATCH] PackageKit gadget: fix hiding of progbar in bryce This seems to me more an hack than a fix, but this is how elm works :( ref T7119 --- src/modules/packagekit/e_mod_packagekit.c | 9 +++++---- src/modules/packagekit/e_mod_packagekit.h | 1 + 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/src/modules/packagekit/e_mod_packagekit.c b/src/modules/packagekit/e_mod_packagekit.c index e7983bae2..286d9e230 100644 --- a/src/modules/packagekit/e_mod_packagekit.c +++ b/src/modules/packagekit/e_mod_packagekit.c @@ -258,10 +258,10 @@ packagekit_popup_update(E_PackageKit_Instance *inst, Eina_Bool rebuild_list) elm_genlist_clear(inst->popup_genlist); elm_progressbar_value_set(inst->popup_progressbar, ctxt->transaction_progress); - evas_object_show(inst->popup_progressbar); + evas_object_show(inst->popup_progressbar_frame); } else - evas_object_hide(inst->popup_progressbar); + evas_object_hide(inst->popup_progressbar_frame); // update title and error lables if (ctxt->transaction) @@ -538,7 +538,7 @@ packagekit_popup_new(E_PackageKit_Instance *inst, Eina_Bool is_gadcon) evas_object_show(li); // central area (progress bar) (inside a padding frame) - fr = elm_frame_add(table); + fr = inst->popup_progressbar_frame = elm_frame_add(table); elm_object_style_set(fr, "pad_large"); E_EXPAND(fr); E_FILL(fr); @@ -596,7 +596,8 @@ packagekit_popup_del(E_PackageKit_Instance *inst) if (inst->ctxpopup) elm_ctxpopup_dismiss(inst->ctxpopup); - inst->popup_genlist = inst->popup_title_entry = inst->popup_progressbar = NULL; + inst->popup_genlist = inst->popup_title_entry = NULL; + inst->popup_progressbar = inst->popup_progressbar_frame = NULL; if (inst->popup_genlist_itc) { elm_genlist_item_class_free(inst->popup_genlist_itc); diff --git a/src/modules/packagekit/e_mod_packagekit.h b/src/modules/packagekit/e_mod_packagekit.h index 8e0742611..df09a6622 100644 --- a/src/modules/packagekit/e_mod_packagekit.h +++ b/src/modules/packagekit/e_mod_packagekit.h @@ -84,6 +84,7 @@ typedef struct _E_PackageKit_Instance Evas_Object *popup_error_label; Evas_Object *popup_install_button; Evas_Object *popup_progressbar; + Evas_Object *popup_progressbar_frame; Evas_Object *popup_genlist; Elm_Genlist_Item_Class *popup_genlist_itc; Eina_Bool popup_help_mode;