From 6d0a11236f5605a595c3f5b9c691716886fda0f7 Mon Sep 17 00:00:00 2001 From: Mike Blumenkrantz Date: Thu, 13 Dec 2012 12:03:41 +0000 Subject: [PATCH] fix possible buffer overflow in module config dialog SVN revision: 80832 --- src/bin/e_int_config_modules.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/bin/e_int_config_modules.c b/src/bin/e_int_config_modules.c index 0e9f3fd5f..3e9d4a0e4 100644 --- a/src/bin/e_int_config_modules.c +++ b/src/bin/e_int_config_modules.c @@ -463,9 +463,7 @@ _cftype_new_from_key(const char *key) memcpy(name, key, key_len + 1); name[0] = toupper(name[0]); - memcpy(icon, "enlightenment/", sizeof("enlightenment/") - 1); - memcpy(icon + sizeof("enlightenment/") - 1, key, key_len + 1); - + snprintf(icon, sizeof(icon), "enlightenment/%s", key); return _cftype_new(key, name, icon); }