diff --git a/TODO b/TODO index 912fab338..d979b6298 100644 --- a/TODO +++ b/TODO @@ -8,6 +8,9 @@ Some of the things (in very short form) that need to be done to E17... BUGS / FIXES ------------------------------------------------------------------------------- +* BUG: performance bug: e_app_new() is amazingly slow and heavy. see the FIXME + comment in e_fm.c in _e_fm2_icon_icon_set()... this needs to be traced, + profiled and leaned down by many factors :) * BUG: add applications to ibar etc. is broken now (indirect references from all applications menu don't work when trying to add - nothing happens) * BUG: adding app using "applications" dialog to a bar dir ends up with blank diff --git a/src/bin/e_fm.c b/src/bin/e_fm.c index d24b6817b..e3b01e0a0 100644 --- a/src/bin/e_fm.c +++ b/src/bin/e_fm.c @@ -1658,9 +1658,12 @@ _e_fm2_icon_icon_set(E_Fm2_Icon *ic) E_App *app; if (ic->info.pseudo_link) - snprintf(buf, sizeof(buf), "%s/%s", ic->info.pseudo_dir, ic->info.file); + snprintf(buf, sizeof(buf), "%s/%s", ic->info.pseudo_dir, ic->info.file); else snprintf(buf, sizeof(buf), "%s/%s", ic->sd->realpath, ic->info.file); +/* FIXME FIXME FIXME: e_app_new() is SLOOOOOOOOOOOOOOOOOOOOOOOOOOOOOW. it can + * be a complete hog. this destroys performance in fm2. :(:(:( + */ app = e_app_new(buf, 0); if (app) {