kimcinoo
/
efl
forked from enlightenment/efl
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

emotion: Fix data race condition 

Coverity reports that we access vfmapped here without holding a lock.
This patch implements eina_lock_take/release while accessing
priv->vfmapped.

Fixes Coverity CID1381624

@fix

Signed-off-by: Chris Michael <cp.michael@samsung.com>
This commit is contained in:
Chris Michael 2017-11-06 10:07:48 -05:00
parent fd79e32dbd
commit 01920b996a
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/modules/emotion/gstreamer1/emotion_sink.c
View File

@ -137,6 +137,7 @@ emotion_video_sink_dispose(GObject* object)
sink = EMOTION_VIDEO_SINK(object);
priv = sink->priv;
eina_lock_take(&priv->m);
if (priv->vfmapped)
{
if (priv->evas_object)
@ -166,6 +167,7 @@ emotion_video_sink_dispose(GObject* object)
priv->last_buffer = NULL;
}
eina_lock_release(&priv->m);
eina_lock_free(&priv->m);
eina_condition_free(&priv->c);