From 04c4bb583469757fdd2cd18fb27e5845b17edaea Mon Sep 17 00:00:00 2001 From: Daniel Kolesa Date: Mon, 12 Nov 2018 15:23:58 +0100 Subject: [PATCH] eolian: use 'free' for owned mstring but not string Summary: Strings are const and if these are meant to be owned then it should define its own special free func. Mstrings are mutable and therefore can be owned and freed using standard free() by default. This fixes some warnings around the EFL caused by empty fallback free funcs created by the eolian generator, and these mutable strings were not being freed and potentially leaked. Reviewers: bu5hm4n, stefan_schmidt Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D7261 --- src/lib/eolian/database_validate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib/eolian/database_validate.c b/src/lib/eolian/database_validate.c index 8858818dff..4217ba9431 100644 --- a/src/lib/eolian/database_validate.c +++ b/src/lib/eolian/database_validate.c @@ -261,7 +261,7 @@ _validate_type(Validate_State *vals, Eolian_Type *tp) if (!tp->freefunc) switch (id) { - case KW_string: + case KW_mstring: tp->freefunc = eina_stringshare_add(eo_str_free); break; case KW_stringshare: