kimcinoo
/
efl
forked from enlightenment/efl
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

eo: protect efl_isa from thread race condition.

This commit is contained in:
Cedric Bail 2016-09-02 09:59:09 -07:00
parent 3ab60a1564
commit 05f05dde5c
1 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/lib/eo/eo.c
View File

@ -1441,14 +1441,21 @@ static Eina_Bool cached_isa = EINA_FALSE;
EAPI Eina_Bool
efl_isa(const Eo *eo_id, const Efl_Class *klass_id)
{
eina_spinlock_take(&_eoid_lock);
if (cached_isa_id == eo_id && cached_klass == klass_id)
return cached_isa;
{
eina_spinlock_release(&_eoid_lock);
return cached_isa;
}
eina_spinlock_release(&_eoid_lock);
EO_OBJ_POINTER_RETURN_VAL(eo_id, obj, EINA_FALSE);
EO_CLASS_POINTER_RETURN_VAL(klass_id, klass, EINA_FALSE);
const op_type_funcs *func = _vtable_func_get(obj->vtable,
klass->base_id + klass->desc->ops.count);
eina_spinlock_take(&_eoid_lock);
// Caching the result as we do a lot of serial efl_isa due to evas_object_image using it.
cached_isa_id = eo_id;
cached_klass = klass_id;
@ -1457,6 +1464,8 @@ efl_isa(const Eo *eo_id, const Efl_Class *klass_id)
* _eo_class_isa_func. */
cached_isa = (func && (func->func == _eo_class_isa_func));
eina_spinlock_release(&_eoid_lock);
return cached_isa;
}