kimcinoo
/
efl
forked from enlightenment/efl
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

exactness-inspect: remove abscure xor check 

this is a obscure check, if this was ever reached, then it would simply
crash, because one pointer will be NULL, but strcmp will be called on
it.

CID 1419854

Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D11722
This commit is contained in:
Marcel Hollerbach 2020-04-17 15:17:52 +02:00 committed by Stefan Schmidt
parent e7f4bc4c2a
commit 114412d547
1 changed files with 2 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/bin/exactness/inspect.c
View File

@ -326,13 +326,8 @@ _grp_text_get(void *data, Evas_Object *gl, const char *part EINA_UNUSED)
Eo *gl2 = eina_list_nth(_gls, 1);
Exactness_Unit *unit1 = efl_key_data_get(gl1, "unit");
Exactness_Unit *unit2 = efl_key_data_get(gl2, "unit");
if (!!unit1->fonts_path || !!unit2->fonts_path)
sprintf(buf2, "Fonts directory comparison: XXXXX");
else if (!strcmp(unit1->fonts_path, unit2->fonts_path))
sprintf(buf2, "Fonts directory comparison: %s", unit1->fonts_path);
else
sprintf(buf2, "Fonts directory comparison: "LDIFF(%s)"/"RDIFF(%s),
unit1->fonts_path, unit2->fonts_path);
sprintf(buf2, "Fonts directory comparison: "LDIFF(%s)"/"RDIFF(%s),
unit1 ? unit1->fonts_path : "(NULL)", unit2 ? unit2->fonts_path : "(NULL)");
}
return strdup(buf2);
}